From: Junio C Hamano <gitster@pobox•com>
To: Quentin Neill <quentin.neill@gmail•com>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH] blame: add blame.showemail config option
Date: Thu, 30 Apr 2015 09:10:40 -0700 [thread overview]
Message-ID: <xmqq1tj138cf.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACfD1vtfO_rqr4wv4oHm7W7DSn-Gk-du6nCuJzYvpPXK_d=y=g@mail.gmail.com> (Quentin Neill's message of "Thu, 30 Apr 2015 09:03:03 -0500")
Quentin Neill <quentin.neill@gmail•com> writes:
> On Fri, Apr 24, 2015 at 12:22 AM, Eric Sunshine <sunshine@sunshineco•com> wrote:
>> Despite being case-insensitive and despite existing inconsistencies,
>> in documentation, it is customary to use camelCase for configuration
>> options, so "blame.showEmail".
>
> I noticed while testing that git_config()/git_value() lowercase
> everything, so to be clear this camelCase custom for configuration
> names is for documentation only, right?
Correct. Write "section.variableName" in documentation and
invocations of "git config" command in scripts. Compare key
with "section.variablename" in git_config() callback.
> I'm thinking of a test file that will test all the git blame options,
> but for this
> patch it will only test the new showEmail config. I read t/README and
> tentatively named the new test file "t/8009-blame-config.sh".
I'd suggest
[PATCH 1/2] blame: add blame.showEmail configuration
which would be the polished version of the patch we have been
discussing, plus tests for this particular feature, and
[PATCH 2/2] blame: more tests
which would widen test coverage to other configuration variables and
features.
next prev parent reply other threads:[~2015-04-30 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 2:13 [PATCH] blame: add blame.showemail config option Quentin Neill
2015-04-24 5:22 ` Eric Sunshine
2015-04-27 13:46 ` Quentin Neill
2015-04-27 18:10 ` Junio C Hamano
2015-04-27 19:23 ` Eric Sunshine
2015-04-28 7:08 ` Junio C Hamano
2015-04-30 14:03 ` Quentin Neill
2015-04-30 16:10 ` Junio C Hamano [this message]
2015-04-30 21:33 ` Eric Sunshine
2015-04-30 21:43 ` Junio C Hamano
2015-04-27 19:57 ` Eric Sunshine
2015-05-29 19:40 ` Junio C Hamano
2015-05-30 20:31 ` Quentin Neill
2015-05-30 21:38 ` [PATCH v2] blame: add blame.showEmail configuration Quentin Neill
2015-05-31 18:13 ` Junio C Hamano
2015-05-31 19:24 ` Quentin Neill
2015-05-31 19:27 ` [PATCH v3] " Quentin Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tj138cf.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=quentin.neill@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox