From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Quentin Neill <quentin.neill@gmail•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH] blame: add blame.showemail config option
Date: Thu, 30 Apr 2015 14:43:06 -0700 [thread overview]
Message-ID: <xmqqk2wtxpg5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cQ1JNeg5eoJib07nc6UrREE80pssokbk+xthXTXDcQz1g@mail.gmail.com> (Eric Sunshine's message of "Thu, 30 Apr 2015 17:33:30 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Thu, Apr 30, 2015 at 10:03 AM, Quentin Neill <quentin.neill@gmail•com> wrote:
>> I'm thinking of a test file that will test all the git blame options,
>> but for this
>> patch it will only test the new showEmail config. I read t/README and
>> tentatively named the new test file "t/8009-blame-config.sh".
>
> I'm not sure that these new proposed tests warrant a new test script.
> Moreover, the tests presumably will be testing combinations of
> configuration options and command-line switches, so having "config" in
> the script name doesn't seem quite correct.
>
> t8002-blame.sh already contains a test for --show-email, so it may be
> logical to add the new tests there, alongside the existing one. On the
> other hand, if you do add a new test script, then perhaps the existing
> --show-email test in t8002-blame.sh should be moved to the new script.
Good thinking. I would vote for the former, unless the number of
additional tests exceed 20 (as t8002 has about 100 tests).
next prev parent reply other threads:[~2015-04-30 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 2:13 [PATCH] blame: add blame.showemail config option Quentin Neill
2015-04-24 5:22 ` Eric Sunshine
2015-04-27 13:46 ` Quentin Neill
2015-04-27 18:10 ` Junio C Hamano
2015-04-27 19:23 ` Eric Sunshine
2015-04-28 7:08 ` Junio C Hamano
2015-04-30 14:03 ` Quentin Neill
2015-04-30 16:10 ` Junio C Hamano
2015-04-30 21:33 ` Eric Sunshine
2015-04-30 21:43 ` Junio C Hamano [this message]
2015-04-27 19:57 ` Eric Sunshine
2015-05-29 19:40 ` Junio C Hamano
2015-05-30 20:31 ` Quentin Neill
2015-05-30 21:38 ` [PATCH v2] blame: add blame.showEmail configuration Quentin Neill
2015-05-31 18:13 ` Junio C Hamano
2015-05-31 19:24 ` Quentin Neill
2015-05-31 19:27 ` [PATCH v3] " Quentin Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2wtxpg5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=quentin.neill@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox