From: Junio C Hamano <gitster@pobox•com>
To: Elijah Newren <newren@gmail•com>
Cc: "Phillip Wood" <phillip.wood@dunelm•org.uk>,
git@vger•kernel.org, "René Scharfe" <l.s.r@web•de>,
"Brian M . Carlson" <sandals@crustytoothpaste•net>,
"Eric Sunshine" <sunshine@sunshineco•com>
Subject: Re: [PATCH v2 0/3] C99: declare bool experiment a success
Date: Tue, 15 Jul 2025 11:53:39 -0700 [thread overview]
Message-ID: <xmqqtt3dgua4.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BHoTxT1UQtgy2bH=mc1re_LPngKX-50GPh_wbtMMZZpyQ@mail.gmail.com> (Elijah Newren's message of "Tue, 15 Jul 2025 10:19:27 -0700")
Elijah Newren <newren@gmail•com> writes:
>> Since 8277dbe987 (git-compat-util: convert skip_{prefix,suffix}{,_mem}
>> - to bool, 2023-12-16) a number of our sting predicates have been
>> - returning bool instead of int. Now we've declared that experiment
>> - a success lets convert the return type the case independent
>> + to bool, 2023-12-16) a number of our string predicates have been
>> + returning bool instead of int. Now that we've declared that experiment
>> + a success, let's convert the return type of the case-independent
>> skip_iprefix() and skip_iprefix_mem() functions to match the return
>> - type of their case dependent equivalents. Returning bool instead of
>> + type of their case-dependent equivalents. Returning bool instead of
>> int makes it clear that these functions are predicates.
>>
>> Signed-off-by: Phillip Wood <phillip.wood@dunelm•org.uk>
>> 3: 7eaf8042061 = 3: 66968714739 strbuf: convert predicates to return bool
>> --
>> 2.49.0.897.gfad3eb7d210
>
> This version looks good to me, thanks!
Thanks, looking good.
next prev parent reply other threads:[~2025-07-15 18:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:26 [PATCH 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-14 13:27 ` [PATCH 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-14 16:37 ` Junio C Hamano
2025-07-14 13:27 ` [PATCH 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-14 16:46 ` Eric Sunshine
2025-07-14 17:20 ` Elijah Newren
2025-07-14 21:14 ` brian m. carlson
2025-07-15 9:36 ` Phillip Wood
2025-07-14 13:27 ` [PATCH 3/3] strbuf: convert " Phillip Wood
2025-07-15 13:52 ` [PATCH v2 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-15 13:52 ` [PATCH v2 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-16 4:38 ` Jeff King
2025-07-16 4:46 ` Jeff King
2025-07-16 5:06 ` Elijah Newren
2025-07-15 13:52 ` [PATCH v2 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-15 13:52 ` [PATCH v2 3/3] strbuf: convert " Phillip Wood
2025-07-15 17:19 ` [PATCH v2 0/3] C99: declare bool experiment a success Elijah Newren
2025-07-15 18:23 ` rsbecker
2025-07-15 19:35 ` Elijah Newren
2025-07-15 20:47 ` rsbecker
2025-07-15 21:06 ` Junio C Hamano
2025-07-15 18:53 ` Junio C Hamano [this message]
2025-07-15 21:48 ` brian m. carlson
2025-07-15 22:09 ` Junio C Hamano
2025-07-16 9:38 ` [PATCH v3 " Phillip Wood
2025-07-16 9:38 ` [PATCH v3 1/3] CodingGuidelines: allow the use of bool Phillip Wood
2025-07-16 9:38 ` [PATCH v3 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-16 10:26 ` Karthik Nayak
2025-07-16 9:38 ` [PATCH v3 3/3] strbuf: convert " Phillip Wood
2025-07-16 10:28 ` Karthik Nayak
2025-07-16 10:29 ` [PATCH v3 0/3] C99: declare bool experiment a success Karthik Nayak
2025-07-17 15:21 ` Phillip Wood
2025-07-22 8:09 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtt3dgua4.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=newren@gmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox