From: Junio C Hamano <gitster@pobox•com>
To: Phillip Wood <phillip.wood123@gmail•com>
Cc: git@vger•kernel.org, "René Scharfe" <l.s.r@web•de>
Subject: Re: [PATCH 1/3] CodingGuildlines: allow the use of bool
Date: Mon, 14 Jul 2025 09:37:32 -0700 [thread overview]
Message-ID: <xmqqv7nuu3sj.fsf@gitster.g> (raw)
In-Reply-To: <352f80c49b74053d611e7d64991fed1c16d857a4.1752499610.git.phillip.wood@dunelm.org.uk> (Phillip Wood's message of "Mon, 14 Jul 2025 14:27:00 +0100")
Phillip Wood <phillip.wood123@gmail•com> writes:
> From: Phillip Wood <phillip.wood@dunelm•org.uk>
>
> We have had a test balloon for C99's bool type since 8277dbe987
> (git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
> 2023-12-16). As we've had it over 18 months without any complaints
> let's declare it a success.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm•org.uk>
> ---
> Documentation/CodingGuidelines | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index 6350949f2ef..528b42d1dd1 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -298,6 +298,9 @@ For C programs:
> . since late 2021 with 44ba10d6, we have had variables declared in
> the for loop "for (int i = 0; i < 10; i++)".
>
> + . since late 2023 with 8277dbe987 we have been using the bool type
> + from <stdbool.h>.
Let's see the other ones in the same list.
* initializer elements that are not static (used since 2b6854c8
(Cleanup variables in cat-file, 2007-04-21), declared official
with 442c27dd (CodingGuidelines: mention dynamic C99 initializer
elements, 2022-10-10).
* trailing comma in enum definition (used since e1327023 (grep:
refactor the concept of "grep source" into an object,
2012-02-02), declared official with cc0c4297 (CodingGuidelines:
spell out post-C89 rules, 2019-07-16).
* designated initialiers for struct and arrays (used since cbc0f81d
(strbuf: use designated initializers in STRBUF_INIT, 2017-07-10)
and 512f41cf (clean.c: use designated initializer, 2017-07-14),
declared official with cc0c4297 (CodingGuidelines: spell out
post-C89 rules, 2019-07-16).
* variadic macros (used since 765dc168 (git-compat-util: always
enable variadic macros, 2021-01-28), declared official with
56a29d2c (C99: remove hardcoded-out !HAVE_VARIADIC_MACROS code,
2022-02-21).
* declaring a control variable in for(;;) loop (used since 44ba10d6
(revision: use C99 declaration of variable in for() loop,
2021-11-14), declared official with 82dd01d8 (CodingGuidelines:
allow declaring variables in for loops, 2022-10-10).
A year and a half sounds roughly the average timespan.
Will queue. Thanks.
next prev parent reply other threads:[~2025-07-14 16:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:26 [PATCH 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-14 13:27 ` [PATCH 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-14 16:37 ` Junio C Hamano [this message]
2025-07-14 13:27 ` [PATCH 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-14 16:46 ` Eric Sunshine
2025-07-14 17:20 ` Elijah Newren
2025-07-14 21:14 ` brian m. carlson
2025-07-15 9:36 ` Phillip Wood
2025-07-14 13:27 ` [PATCH 3/3] strbuf: convert " Phillip Wood
2025-07-15 13:52 ` [PATCH v2 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-15 13:52 ` [PATCH v2 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-16 4:38 ` Jeff King
2025-07-16 4:46 ` Jeff King
2025-07-16 5:06 ` Elijah Newren
2025-07-15 13:52 ` [PATCH v2 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-15 13:52 ` [PATCH v2 3/3] strbuf: convert " Phillip Wood
2025-07-15 17:19 ` [PATCH v2 0/3] C99: declare bool experiment a success Elijah Newren
2025-07-15 18:23 ` rsbecker
2025-07-15 19:35 ` Elijah Newren
2025-07-15 20:47 ` rsbecker
2025-07-15 21:06 ` Junio C Hamano
2025-07-15 18:53 ` Junio C Hamano
2025-07-15 21:48 ` brian m. carlson
2025-07-15 22:09 ` Junio C Hamano
2025-07-16 9:38 ` [PATCH v3 " Phillip Wood
2025-07-16 9:38 ` [PATCH v3 1/3] CodingGuidelines: allow the use of bool Phillip Wood
2025-07-16 9:38 ` [PATCH v3 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-16 10:26 ` Karthik Nayak
2025-07-16 9:38 ` [PATCH v3 3/3] strbuf: convert " Phillip Wood
2025-07-16 10:28 ` Karthik Nayak
2025-07-16 10:29 ` [PATCH v3 0/3] C99: declare bool experiment a success Karthik Nayak
2025-07-17 15:21 ` Phillip Wood
2025-07-22 8:09 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7nuu3sj.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=phillip.wood123@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox