From: James Clark <james.clark@linaro•org>
To: Leo Yan <leo.yan@arm•com>
Cc: linux-arm-kernel@lists•infradead.org, coresight@lists•linaro.org,
linux-perf-users@vger•kernel.org,
Arnaldo Carvalho de Melo <acme@kernel•org>,
John Garry <john.g.garry@oracle•com>,
Will Deacon <will@kernel•org>, Mike Leach <mike.leach@arm•com>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Namhyung Kim <namhyung@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Jiri Olsa <jolsa@kernel•org>, Ian Rogers <irogers@google•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Al Grant <al.grant@arm•com>,
Paschalis Mpeis <paschalis.mpeis@arm•com>,
Amir Ayupov <aaupov@fb•com>
Subject: Re: [PATCH v6 1/8] perf cs-etm: Decode ETE exception packets
Date: Thu, 4 Jun 2026 15:10:53 +0100 [thread overview]
Message-ID: <047a6470-9afa-41f7-8942-9d9b6d15eff8@linaro.org> (raw)
In-Reply-To: <20260526-b4-arm_cs_callchain_support_v1-v6-1-f9f49f53c9dd@arm.com>
On 26/05/2026 5:59 pm, Leo Yan wrote:
> ETE shares the same packet format as ETMv4, but exception decoding
> handled ETMv4 packets only. As a result, ETE exception packets were
> not classified.
>
> Recognize the ETE magic for exception number decoding.
>
> Signed-off-by: Leo Yan <leo.yan@arm•com>
> ---
> tools/perf/util/cs-etm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 6ec48de29441012f3d827d50616349c6c0d1f037..ab79d08f5a6095448470e2c3ec85ff3db2fb5634 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -2138,7 +2138,7 @@ static bool cs_etm__is_syscall(struct cs_etm_queue *etmq,
> * HVC cases; need to check if it's SVC instruction based on
> * packet address.
> */
> - if (magic == __perf_cs_etmv4_magic) {
> + if (magic == __perf_cs_etmv4_magic || magic == __perf_cs_ete_magic) {
> if (packet->exception_number == CS_ETMV4_EXC_CALL &&
> cs_etm__is_svc_instr(etmq, trace_chan_id, prev_packet,
> prev_packet->end_addr))
> @@ -2161,7 +2161,7 @@ static bool cs_etm__is_async_exception(struct cs_etm_traceid_queue *tidq,
> packet->exception_number == CS_ETMV3_EXC_FIQ)
> return true;
>
> - if (magic == __perf_cs_etmv4_magic)
> + if (magic == __perf_cs_etmv4_magic || magic == __perf_cs_ete_magic)
> if (packet->exception_number == CS_ETMV4_EXC_RESET ||
> packet->exception_number == CS_ETMV4_EXC_DEBUG_HALT ||
> packet->exception_number == CS_ETMV4_EXC_SYSTEM_ERROR ||
> @@ -2192,7 +2192,7 @@ static bool cs_etm__is_sync_exception(struct cs_etm_queue *etmq,
> packet->exception_number == CS_ETMV3_EXC_GENERIC)
> return true;
>
> - if (magic == __perf_cs_etmv4_magic) {
> + if (magic == __perf_cs_etmv4_magic || magic == __perf_cs_ete_magic) {
> if (packet->exception_number == CS_ETMV4_EXC_TRAP ||
> packet->exception_number == CS_ETMV4_EXC_ALIGNMENT ||
> packet->exception_number == CS_ETMV4_EXC_INST_FAULT ||
>
Reviewed-by: James Clark <james.clark@linaro•org>
next prev parent reply other threads:[~2026-06-04 14:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 16:59 [PATCH v6 0/8] perf cs-etm: Support thread stack and callchain Leo Yan
2026-05-26 16:59 ` [PATCH v6 1/8] perf cs-etm: Decode ETE exception packets Leo Yan
2026-06-04 14:10 ` James Clark [this message]
2026-05-26 16:59 ` [PATCH v6 2/8] perf cs-etm: Refactor instruction size handling Leo Yan
2026-06-04 14:11 ` James Clark
2026-05-26 16:59 ` [PATCH v6 3/8] perf cs-etm: Use thread-stack for last branch entries Leo Yan
2026-06-04 14:09 ` James Clark
2026-05-26 16:59 ` [PATCH v6 4/8] perf cs-etm: Flush thread stacks after decoder reset Leo Yan
2026-06-04 14:12 ` James Clark
2026-05-26 16:59 ` [PATCH v6 5/8] perf cs-etm: Support call indentation Leo Yan
2026-06-04 14:24 ` James Clark
2026-05-26 16:59 ` [PATCH v6 6/8] perf cs-etm: Filter synthesized branch samples Leo Yan
2026-06-04 14:42 ` James Clark
2026-05-26 16:59 ` [PATCH v6 7/8] perf cs-etm: Synthesize callchains for instruction samples Leo Yan
2026-06-04 15:07 ` James Clark
2026-05-26 16:59 ` [PATCH v6 8/8] perf test: Add Arm CoreSight callchain test Leo Yan
2026-05-29 14:57 ` [PATCH v6 0/8] perf cs-etm: Support thread stack and callchain Arnaldo Carvalho de Melo
2026-06-01 11:03 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047a6470-9afa-41f7-8942-9d9b6d15eff8@linaro.org \
--to=james.clark@linaro$(echo .)org \
--cc=aaupov@fb$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=al.grant@arm$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=coresight@lists$(echo .)linaro.org \
--cc=irogers@google$(echo .)com \
--cc=john.g.garry@oracle$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=leo.yan@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mike.leach@arm$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=paschalis.mpeis@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox