From: James Clark <james.clark@linaro•org>
To: Leo Yan <leo.yan@arm•com>
Cc: linux-arm-kernel@lists•infradead.org, coresight@lists•linaro.org,
linux-perf-users@vger•kernel.org, Leo Yan <leo.yan@linux•dev>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
John Garry <john.g.garry@oracle•com>,
Will Deacon <will@kernel•org>, Mike Leach <mike.leach@arm•com>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Namhyung Kim <namhyung@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Jiri Olsa <jolsa@kernel•org>, Ian Rogers <irogers@google•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Al Grant <al.grant@arm•com>,
Paschalis Mpeis <paschalis.mpeis@arm•com>,
Amir Ayupov <aaupov@fb•com>
Subject: Re: [PATCH v6 7/8] perf cs-etm: Synthesize callchains for instruction samples
Date: Thu, 4 Jun 2026 16:07:07 +0100 [thread overview]
Message-ID: <ba6008d5-930e-466a-ade8-7a3fe9f4e306@linaro.org> (raw)
In-Reply-To: <20260526-b4-arm_cs_callchain_support_v1-v6-7-f9f49f53c9dd@arm.com>
On 26/05/2026 5:59 pm, Leo Yan wrote:
> From: Leo Yan <leo.yan@linaro•org>
>
> CS ETM already records branches into the thread stack, but instruction
> samples do not carry synthesized callchains. It misses to support the
> callchain and no output with the itrace option 'g'.
>
> Allocate a callchain buffer per queue and use thread_stack__sample()
> when synthesizing instruction samples. Advertise PERF_SAMPLE_CALLCHAIN
> on the synthetic instruction event.
>
> Allocate the callchain stack with one more entry than requested, as the
> first entry is reserved for storing context information.
>
> After:
>
> perf script --itrace=g16l64i100
>
> callchain_test 9187 [002] 599611.826599: 1 instructions:
> aaaae3ed0774 do_svc+0xc (/home/kernel/leoy/test_cs_callchain/callchain_test)
> aaaae3ed0798 print+0xc (/home/kernel/leoy/test_cs_callchain/callchain_test)
> aaaae3ed07b0 foo+0xc (/home/kernel/leoy/test_cs_callchain/callchain_test)
> aaaae3ed07c8 main+0xc (/home/kernel/leoy/test_cs_callchain/callchain_test)
> ffff8331225c __libc_start_call_main+0x7c (/usr/lib/aarch64-linux-gnu/libc.so.6)
> ffff8331233c call_init+0x9c (inlined)
> ffff8331233c __libc_start_main_impl+0x9c (inlined)
> aaaae3ed0670 _start+0x30 (/home/kernel/leoy/test_cs_callchain/callchain_test)
>
> Signed-off-by: Leo Yan <leo.yan@linaro•org>
> Signed-off-by: Leo Yan <leo.yan@arm•com>
> ---
> tools/perf/util/cs-etm.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 48 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 8d98e772ecb307381b5ed1b4bbc4056e8779b261..90e0beb910156093d8bd0f320bb0210aca95dd26 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -17,6 +17,7 @@
> #include <stdlib.h>
>
> #include "auxtrace.h"
> +#include "callchain.h"
> #include "color.h"
> #include "cs-etm.h"
> #include "cs-etm-decoder/cs-etm-decoder.h"
> @@ -85,6 +86,7 @@ struct cs_etm_auxtrace {
> struct cs_etm_traceid_queue {
> u8 trace_chan_id;
> u64 period_instructions;
> + u64 kernel_start;
> union perf_event *event_buf;
> struct thread *thread;
> struct thread *prev_packet_thread;
> @@ -92,6 +94,7 @@ struct cs_etm_traceid_queue {
> ocsd_ex_level el;
> unsigned int br_stack_sz;
> struct branch_stack *last_branch;
> + struct ip_callchain *callchain;
> struct cs_etm_packet *prev_packet;
> struct cs_etm_packet *packet;
> struct cs_etm_packet_queue packet_queue;
> @@ -640,6 +643,16 @@ static int cs_etm__init_traceid_queue(struct cs_etm_queue *etmq,
> tidq->br_stack_sz = etm->synth_opts.last_branch_sz;
> }
>
> + if (etm->synth_opts.callchain) {
> + size_t sz = sizeof(struct ip_callchain);
> +
> + /* Add 1 to callchain_sz for callchain context */
> + sz += (etm->synth_opts.callchain_sz + 1) * sizeof(u64);
> + tidq->callchain = zalloc(sz);
You can use struct_size() to get the size for a flexible array struct:
zalloc(struct_size(tidq->callchain, ips,
etm->synth_opts.callchain_sz + 1));
> + if (!tidq->callchain)
> + goto out_free;
> + }
> +
> tidq->event_buf = malloc(PERF_SAMPLE_MAX_SIZE);
> if (!tidq->event_buf)
> goto out_free;
> @@ -647,6 +660,7 @@ static int cs_etm__init_traceid_queue(struct cs_etm_queue *etmq,
> return 0;
>
> out_free:
> + zfree(&tidq->callchain);
> zfree(&tidq->last_branch);
> zfree(&tidq->prev_packet);
> zfree(&tidq->packet);
> @@ -939,6 +953,7 @@ static void cs_etm__free_traceid_queues(struct cs_etm_queue *etmq)
> thread__zput(tidq->thread);
> thread__zput(tidq->prev_packet_thread);
> zfree(&tidq->event_buf);
> + zfree(&tidq->callchain);
> zfree(&tidq->last_branch);
> zfree(&tidq->prev_packet);
> zfree(&tidq->packet);
> @@ -1431,6 +1446,7 @@ static void cs_etm__set_thread(struct cs_etm_queue *etmq,
> tidq->thread = machine__idle_thread(machine);
>
> tidq->el = el;
> + tidq->kernel_start = machine__kernel_start(machine);
> }
>
> int cs_etm__etmq_set_tid_el(struct cs_etm_queue *etmq, pid_t tid,
> @@ -1561,6 +1577,25 @@ static int cs_etm__synth_instruction_sample(struct cs_etm_queue *etmq,
> sample.branch_stack = tidq->last_branch;
> }
>
> + if (etm->synth_opts.callchain) {
> + if (tidq->kernel_start)
> + thread_stack__sample(tidq->thread, tidq->packet->cpu,
> + tidq->callchain,
> + etm->synth_opts.callchain_sz + 1,
> + sample.ip, tidq->kernel_start);
> + else
> + /*
> + * Clear the callchain when the kernel start address is
> + * not available yet. The empty callchain can then be
> + * consumed by cs_etm__inject_event().
> + */
> + memset(tidq->callchain, 0,
> + sizeof(struct ip_callchain) +
> + (etm->synth_opts.callchain_sz + 1) * sizeof(u64));
Ditto, but the rest looks good:
Reviewed-by: James Clark <james.clark@linaro•org>
> +
> + sample.callchain = tidq->callchain;
> + }
> +
> if (etm->synth_opts.inject) {
> ret = cs_etm__inject_event(etm, event, &sample,
> etm->instructions_sample_type);
> @@ -1724,6 +1759,9 @@ static int cs_etm__synth_events(struct cs_etm_auxtrace *etm,
> attr.branch_sample_type |= PERF_SAMPLE_BRANCH_HW_INDEX;
> }
>
> + if (etm->synth_opts.callchain)
> + attr.sample_type |= PERF_SAMPLE_CALLCHAIN;
> +
> if (etm->synth_opts.instructions) {
> attr.config = PERF_COUNT_HW_INSTRUCTIONS;
> attr.sample_period = etm->synth_opts.period;
> @@ -3457,6 +3495,14 @@ int cs_etm__process_auxtrace_info_full(union perf_event *event,
> PERF_IP_FLAG_TRACE_BEGIN |
> PERF_IP_FLAG_TRACE_END;
>
> + if (etm->synth_opts.callchain && !symbol_conf.use_callchain) {
> + symbol_conf.use_callchain = true;
> + if (callchain_register_param(&callchain_param) < 0) {
> + symbol_conf.use_callchain = false;
> + etm->synth_opts.callchain = false;
> + }
> + }
> +
> etm->session = session;
>
> etm->num_cpu = num_cpu;
> @@ -3508,7 +3554,8 @@ int cs_etm__process_auxtrace_info_full(union perf_event *event,
> }
>
> etm->use_thread_stack = etm->synth_opts.thread_stack ||
> - etm->synth_opts.last_branch;
> + etm->synth_opts.last_branch ||
> + etm->synth_opts.callchain;
>
> err = cs_etm__synth_events(etm, session);
> if (err)
>
next prev parent reply other threads:[~2026-06-04 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 16:59 [PATCH v6 0/8] perf cs-etm: Support thread stack and callchain Leo Yan
2026-05-26 16:59 ` [PATCH v6 1/8] perf cs-etm: Decode ETE exception packets Leo Yan
2026-06-04 14:10 ` James Clark
2026-05-26 16:59 ` [PATCH v6 2/8] perf cs-etm: Refactor instruction size handling Leo Yan
2026-06-04 14:11 ` James Clark
2026-05-26 16:59 ` [PATCH v6 3/8] perf cs-etm: Use thread-stack for last branch entries Leo Yan
2026-06-04 14:09 ` James Clark
2026-05-26 16:59 ` [PATCH v6 4/8] perf cs-etm: Flush thread stacks after decoder reset Leo Yan
2026-06-04 14:12 ` James Clark
2026-05-26 16:59 ` [PATCH v6 5/8] perf cs-etm: Support call indentation Leo Yan
2026-06-04 14:24 ` James Clark
2026-05-26 16:59 ` [PATCH v6 6/8] perf cs-etm: Filter synthesized branch samples Leo Yan
2026-06-04 14:42 ` James Clark
2026-05-26 16:59 ` [PATCH v6 7/8] perf cs-etm: Synthesize callchains for instruction samples Leo Yan
2026-06-04 15:07 ` James Clark [this message]
2026-05-26 16:59 ` [PATCH v6 8/8] perf test: Add Arm CoreSight callchain test Leo Yan
2026-05-29 14:57 ` [PATCH v6 0/8] perf cs-etm: Support thread stack and callchain Arnaldo Carvalho de Melo
2026-06-01 11:03 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba6008d5-930e-466a-ade8-7a3fe9f4e306@linaro.org \
--to=james.clark@linaro$(echo .)org \
--cc=aaupov@fb$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=al.grant@arm$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=coresight@lists$(echo .)linaro.org \
--cc=irogers@google$(echo .)com \
--cc=john.g.garry@oracle$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=leo.yan@arm$(echo .)com \
--cc=leo.yan@linux$(echo .)dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mike.leach@arm$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=paschalis.mpeis@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox