From: Anshuman Khandual <anshuman.khandual@arm•com>
To: David Laight <david.laight.linux@gmail•com>,
Dave Hansen <dave.hansen@intel•com>
Cc: linux-arm-kernel@lists•infradead.org,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>,
Ryan Roberts <ryan.roberts@arm•com>,
Mark Rutland <mark.rutland@arm•com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle•com>,
Andrew Morton <akpm@linux-foundation•org>,
David Hildenbrand <david@kernel•org>,
Mike Rapoport <rppt@kernel•org>,
Linu Cherian <linu.cherian@arm•com>,
Usama Arif <usama.arif@linux•dev>,
linux-kernel@vger•kernel.org, linux-mm@kvack•org
Subject: Re: [RFC V2 01/14] mm: Abstract printing of pxd_val()
Date: Mon, 1 Jun 2026 11:56:13 +0530 [thread overview]
Message-ID: <1e50b8f4-22ae-4ff7-aac9-fa3242bb23ca@arm.com> (raw)
In-Reply-To: <20260521104206.1c7d3fe0@pumpkin>
On 21/05/26 3:12 PM, David Laight wrote:
> On Tue, 19 May 2026 07:28:17 -0700
> Dave Hansen <dave.hansen@intel•com> wrote:
>
>> On 5/12/26 21:45, Anshuman Khandual wrote:
>>> if (!p4d_present(p4d) || p4d_leaf(p4d)) {
>>> - pr_alert("pgd:%08llx p4d:%08llx\n", pgdv, p4dv);
>>> + pr_alert("pgd:%" __PRIpxx " p4d:%" __PRIpxx "\n",
>>> + __PRIpxx_args(pgdv), __PRIpxx_args(p4dv));
>>> return;
>>> }
>>
>> That's not the most readable result. Could a printk() format specifier
>> make this nicer? Maybe use "%pT"?
>>
>> pr_alert("pgd:%pT p4d:%pT\n", &pgd, &p4d);
>>
>> I _think_ it could even get rid of the p??v variables.
>>
>
> Adding another %p variant that is only used in a few places just makes
> it all harder to read.
> Perhaps a local helper that lets you do:
> char pdgv_buf[??]:
> pr_alert("... %s ...", ... fmt_pdgv(pdgv_buf, pdgv) ...)
> might be a reasonable compromise.
But will not that also create a similar code churn as adding %p variant ?
As mentioned earlier a draft implementation could be found here.
https://lore.kernel.org/all/1d694f9d-4f40-428b-aa28-9d6e0febd54c@arm.com/
next prev parent reply other threads:[~2026-06-01 6:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 4:45 [RFC V2 00/14] arm64/mm: Enable 128 bit page table entries Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 01/14] mm: Abstract printing of pxd_val() Anshuman Khandual
2026-05-17 18:57 ` Mike Rapoport
2026-05-19 14:28 ` Dave Hansen
2026-05-20 10:41 ` David Hildenbrand (Arm)
2026-05-21 3:43 ` Anshuman Khandual
2026-05-21 9:42 ` David Laight
2026-06-01 6:26 ` Anshuman Khandual [this message]
2026-05-13 4:45 ` [RFC V2 02/14] mm: Add read-write accessors for vm_page_prot Anshuman Khandual
2026-05-17 18:59 ` Mike Rapoport
2026-05-13 4:45 ` [RFC V2 03/14] arm64/mm: Convert READ_ONCE() as pmdp_get() while accessing PMD Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 04/14] arm64/mm: Convert READ_ONCE() as pudp_get() while accessing PUD Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 05/14] arm64/mm: Convert READ_ONCE() as p4dp_get() while accessing P4D Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 06/14] arm64/mm: Convert READ_ONCE() as pgdp_get() while accessing PGD Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 07/14] arm64/mm: Route all pgtable reads via pxxval_get() Anshuman Khandual
2026-05-27 14:11 ` Ryan Roberts
2026-06-01 5:01 ` Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 08/14] arm64/mm: Route all pgtable writes via pxxval_set() Anshuman Khandual
2026-05-27 14:12 ` Ryan Roberts
2026-05-13 4:45 ` [RFC V2 09/14] arm64/mm: Route all pgtable atomics to central helpers Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 10/14] arm64/mm: Abstract printing of pxd_val() Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 11/14] arm64/mm: Override read-write accessors for vm_page_prot Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 13/14] arm64/mm: Add an abstraction level for tlbi_op Anshuman Khandual
2026-05-27 14:50 ` Ryan Roberts
2026-05-29 4:02 ` Linu Cherian
2026-06-01 5:36 ` Anshuman Khandual
2026-06-01 11:06 ` Dev Jain
2026-05-13 4:45 ` [RFC V2 14/14] arm64/mm: Add initial support for FEAT_D128 page tables Anshuman Khandual
2026-05-27 14:54 ` Ryan Roberts
2026-06-01 10:52 ` Linu Cherian
2026-05-13 9:39 ` [RFC V2 00/14] arm64/mm: Enable 128 bit page table entries Lorenzo Stoakes
2026-05-18 4:20 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e50b8f4-22ae-4ff7-aac9-fa3242bb23ca@arm.com \
--to=anshuman.khandual@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=david.laight.linux@gmail$(echo .)com \
--cc=david@kernel$(echo .)org \
--cc=linu.cherian@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=lorenzo.stoakes@oracle$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=ryan.roberts@arm$(echo .)com \
--cc=usama.arif@linux$(echo .)dev \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox