From: Linu Cherian <linu.cherian@arm•com>
To: Ryan Roberts <ryan.roberts@arm•com>
Cc: Anshuman Khandual <anshuman.khandual@arm•com>,
linux-arm-kernel@lists•infradead.org,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle•com>,
Andrew Morton <akpm@linux-foundation•org>,
David Hildenbrand <david@kernel•org>,
Mike Rapoport <rppt@kernel•org>,
Usama Arif <usama.arif@linux•dev>,
linux-kernel@vger•kernel.org, linux-mm@kvack•org
Subject: Re: [RFC V2 13/14] arm64/mm: Add an abstraction level for tlbi_op
Date: Fri, 29 May 2026 09:32:52 +0530 [thread overview]
Message-ID: <ahkP7IWLX-0QCoul@a079125.arm.com> (raw)
In-Reply-To: <37917d56-ae26-4789-ac4c-15f8ee12398b@arm.com>
Hi Ryan,
On Wed, May 27, 2026 at 03:50:10PM +0100, Ryan Roberts wrote:
> On 13/05/2026 05:45, Anshuman Khandual wrote:
> > From: Linu Cherian <linu.cherian@arm•com>
> >
> > With FEAT_D128, a new instruction aka TLBIP is being introduced for the TLB
> > range operations which has an argument size of 128 bit.
>
> nit: TLB range operations -> TLBI-by-range operations ?
Ack.
>
> >
> > Add an abstraction level to void (*tlbi_op)(u64 arg) helpers to support the
> > D128 variations when applicable.
> >
> > No functional changes are introduced with this patch.
> >
> > Signed-off-by: Linu Cherian <linu.cherian@arm•com>
> > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm•com>
> > ---
> > arch/arm64/include/asm/tlbflush.h | 70 ++++++++++++++++---------------
> > 1 file changed, 37 insertions(+), 33 deletions(-)
> >
> > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
> > index c0bf5b398041..361d74ef8016 100644
> > --- a/arch/arm64/include/asm/tlbflush.h
> > +++ b/arch/arm64/include/asm/tlbflush.h
> > @@ -162,49 +162,53 @@ static inline void sme_dvmsync_batch(struct arch_tlbflush_unmap_batch *batch)
> >
> > #define TLBI_TTL_UNKNOWN INT_MAX
> >
> > -typedef void (*tlbi_op)(u64 arg);
> > +typedef u64 tlbi_args_t;
>
> nit: tlbi_args_t -> tlbi_arg_t ?
Ack.
--
Thanks,
Linu Cherian.
next prev parent reply other threads:[~2026-05-29 4:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 4:45 [RFC V2 00/14] arm64/mm: Enable 128 bit page table entries Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 01/14] mm: Abstract printing of pxd_val() Anshuman Khandual
2026-05-17 18:57 ` Mike Rapoport
2026-05-19 14:28 ` Dave Hansen
2026-05-20 10:41 ` David Hildenbrand (Arm)
2026-05-21 3:43 ` Anshuman Khandual
2026-05-21 9:42 ` David Laight
2026-06-01 6:26 ` Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 02/14] mm: Add read-write accessors for vm_page_prot Anshuman Khandual
2026-05-17 18:59 ` Mike Rapoport
2026-05-13 4:45 ` [RFC V2 03/14] arm64/mm: Convert READ_ONCE() as pmdp_get() while accessing PMD Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 04/14] arm64/mm: Convert READ_ONCE() as pudp_get() while accessing PUD Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 05/14] arm64/mm: Convert READ_ONCE() as p4dp_get() while accessing P4D Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 06/14] arm64/mm: Convert READ_ONCE() as pgdp_get() while accessing PGD Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 07/14] arm64/mm: Route all pgtable reads via pxxval_get() Anshuman Khandual
2026-05-27 14:11 ` Ryan Roberts
2026-06-01 5:01 ` Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 08/14] arm64/mm: Route all pgtable writes via pxxval_set() Anshuman Khandual
2026-05-27 14:12 ` Ryan Roberts
2026-05-13 4:45 ` [RFC V2 09/14] arm64/mm: Route all pgtable atomics to central helpers Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 10/14] arm64/mm: Abstract printing of pxd_val() Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 11/14] arm64/mm: Override read-write accessors for vm_page_prot Anshuman Khandual
2026-05-13 4:45 ` [RFC V2 13/14] arm64/mm: Add an abstraction level for tlbi_op Anshuman Khandual
2026-05-27 14:50 ` Ryan Roberts
2026-05-29 4:02 ` Linu Cherian [this message]
2026-06-01 5:36 ` Anshuman Khandual
2026-06-01 11:06 ` Dev Jain
2026-05-13 4:45 ` [RFC V2 14/14] arm64/mm: Add initial support for FEAT_D128 page tables Anshuman Khandual
2026-05-27 14:54 ` Ryan Roberts
2026-06-01 10:52 ` Linu Cherian
2026-05-13 9:39 ` [RFC V2 00/14] arm64/mm: Enable 128 bit page table entries Lorenzo Stoakes
2026-05-18 4:20 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahkP7IWLX-0QCoul@a079125.arm.com \
--to=linu.cherian@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=david@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=lorenzo.stoakes@oracle$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=ryan.roberts@arm$(echo .)com \
--cc=usama.arif@linux$(echo .)dev \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox