From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 23/29] ARM: orion5x: use DT to describe NOR on edmini_v2
Date: Sun, 13 Apr 2014 17:31:50 +0200 [thread overview]
Message-ID: <20140413153150.GD10033@lunn.ch> (raw)
In-Reply-To: <1397400006-4315-24-git-send-email-thomas.petazzoni@free-electrons.com>
On Sun, Apr 13, 2014 at 04:40:00PM +0200, Thomas Petazzoni wrote:
> This commit converts the already partially DT-converted edmini_v2
> platform to use the Device Tree for NOR flash, using the Device Bus.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
> ---
> .../dts/orion5x-lacie-ethernet-disk-mini-v2.dts | 46 +++++++++++++++-
> arch/arm/mach-orion5x/edmini_v2-setup.c | 62 ----------------------
> 2 files changed, 45 insertions(+), 63 deletions(-)
>
> diff --git a/arch/arm/boot/dts/orion5x-lacie-ethernet-disk-mini-v2.dts b/arch/arm/boot/dts/orion5x-lacie-ethernet-disk-mini-v2.dts
> index ff90b01..44cc36a 100644
> --- a/arch/arm/boot/dts/orion5x-lacie-ethernet-disk-mini-v2.dts
> +++ b/arch/arm/boot/dts/orion5x-lacie-ethernet-disk-mini-v2.dts
> @@ -27,7 +27,51 @@
>
> soc {
> ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000>,
> - <MBUS_ID(0x09, 0x00) 0 0xf2200000 0x800>;
> + <MBUS_ID(0x09, 0x00) 0 0xf2200000 0x800>,
> + <MBUS_ID(0x01, 0x0f) 0 0xfff80000 0x80000>;
> +
> + devbus-bootcs {
> + status = "okay";
> +
> + /* Read parameters */
> + devbus,bus-width = <8>;
> + devbus,turn-off-ps = <90000>;
> + devbus,badr-skew-ps = <0>;
> + devbus,acc-first-ps = <186000>;
> + devbus,acc-next-ps = <186000>;
> +
> + /* Write parameters */
> + devbus,wr-high-ps = <90000>;
> + devbus,wr-low-ps = <90000>;
> + devbus,ale-wr-ps = <90000>;
> +
> + /*
> + * Currently the MTD code does not recognize
> + * the MX29LV400CBCT as a bottom-type
> + * device. This could cause risks of
> + * accidentally erasing critical flash
> + * sectors. We thus define a single,
> + * write-protected partition covering the
> + * whole flash. TODO: once the flash part
> + * TOP/BOTTOM detection issue is sorted out in
> + * the MTD code, break this into at least
> + * three partitions: 'u-boot code', 'u-boot
> + * environment' and 'whatever is left'.
> + */
> + nor at 0 {
> + compatible = "cfi-flash";
> + reg = <0 0x80000>;
> + bank-width = <1>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition at 0 {
> + label = "Full512Kb";
> + reg = <0 0x80000>;
> + read-only;
> + };
> + };
> + };
>
> internal-regs {
> pinctrl at 10000 {
> diff --git a/arch/arm/mach-orion5x/edmini_v2-setup.c b/arch/arm/mach-orion5x/edmini_v2-setup.c
> index 2eebc0c..6bef2d5 100644
> --- a/arch/arm/mach-orion5x/edmini_v2-setup.c
> +++ b/arch/arm/mach-orion5x/edmini_v2-setup.c
> @@ -42,74 +42,12 @@
> * EDMINI_V2 Info
> ****************************************************************************/
>
> -/*
> - * 512KB NOR flash Device bus boot chip select
> - */
> -
> -#define EDMINI_V2_NOR_BOOT_BASE 0xfff80000
> -#define EDMINI_V2_NOR_BOOT_SIZE SZ_512K
> -
> -/*****************************************************************************
> - * 512KB NOR Flash on BOOT Device
> - ****************************************************************************/
> -
> -/*
> - * Currently the MTD code does not recognize the MX29LV400CBCT as a bottom
> - * -type device. This could cause risks of accidentally erasing critical
> - * flash sectors. We thus define a single, write-protected partition covering
> - * the whole flash.
> - * TODO: once the flash part TOP/BOTTOM detection issue is sorted out in the MTD
> - * code, break this into at least three partitions: 'u-boot code', 'u-boot
> - * environment' and 'whatever is left'.
> - */
Hi Thomas
Did you check if this is still true? If it is fixed, maybe now would
be a good time to swap to three partitions?
Andrew
next prev parent reply other threads:[~2014-04-13 15:31 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 14:39 [PATCH 00/29] ARM: orion5x: big step towards DT conversion Thomas Petazzoni
2014-04-13 14:39 ` [PATCH 01/29] ARM: orion5x: fix target ID for crypto SRAM window Thomas Petazzoni
2014-04-14 8:59 ` Sebastian Hesselbarth
2014-04-17 4:55 ` Jason Cooper
2014-04-13 14:39 ` [PATCH 02/29] pinctrl: mvebu: new driver for Orion platforms Thomas Petazzoni
2014-04-14 9:15 ` Sebastian Hesselbarth
2014-04-19 17:28 ` Thomas Petazzoni
2014-04-20 10:04 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 03/29] clk: mvebu: add Orion5x clock driver Thomas Petazzoni
2014-04-14 9:27 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 04/29] memory: mvebu-devbus: fix the conversion of the bus width Thomas Petazzoni
2014-04-14 9:30 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 05/29] memory: mvebu-devbus: use ARMADA_ prefix in defines Thomas Petazzoni
2014-04-14 9:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 06/29] memory: mvebu-devbus: split functions Thomas Petazzoni
2014-04-14 9:36 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 07/29] memory: mvebu-devbus: add Orion5x support Thomas Petazzoni
2014-04-14 9:41 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 08/29] ARM: orion5x: move interrupt controller node into ocp Thomas Petazzoni
2014-04-14 9:42 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 09/29] ARM: orion5x: switch to preprocessor includes in DT Thomas Petazzoni
2014-04-14 9:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 10/29] ARM: orion5x: use existing dt-bindings include for Device Tree files Thomas Petazzoni
2014-04-14 9:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 11/29] ARM: orion5x: convert DT to use the mvebu-mbus driver Thomas Petazzoni
2014-04-14 10:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 12/29] ARM: orion5x: add interrupt for Ethernet in Device Tree Thomas Petazzoni
2014-04-14 10:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 13/29] ARM: orion5x: switch to use the clock driver for DT platforms Thomas Petazzoni
2014-04-14 10:35 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 14/29] ARM: orion: switch to a per-platform handle_irq() function Thomas Petazzoni
2014-04-14 10:40 ` Sebastian Hesselbarth
2014-04-19 7:27 ` Thomas Petazzoni
2014-04-19 9:09 ` Sebastian Hesselbarth
2014-04-19 12:04 ` Thomas Petazzoni
2014-04-19 16:16 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 15/29] ARM: orion5x: switch to DT interrupts and timer Thomas Petazzoni
2014-04-14 10:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 16/29] ARM: orion5x: enable pinctrl driver at SoC level Thomas Petazzoni
2014-04-14 10:44 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 17/29] ARM: orion5x: update I2C description " Thomas Petazzoni
2014-04-14 10:45 ` Sebastian Hesselbarth
2014-04-19 7:38 ` Thomas Petazzoni
2014-04-19 9:10 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 18/29] ARM: orion5x: add Device Bus " Thomas Petazzoni
2014-04-14 10:47 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 19/29] ARM: orion5x: add standard pinctrl configs for sata0 and sata1 Thomas Petazzoni
2014-04-14 10:48 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 20/29] ARM: orion5x: convert edmini_v2 to DT pinctrl Thomas Petazzoni
2014-04-13 15:26 ` Andrew Lunn
2014-04-13 15:41 ` Thomas Petazzoni
2014-04-14 10:51 ` Sebastian Hesselbarth
2014-04-14 11:23 ` Thomas Petazzoni
2014-04-14 11:27 ` Sebastian Hesselbarth
2014-04-14 12:06 ` Andrew Lunn
2014-04-14 12:24 ` Ezequiel Garcia
2014-04-14 12:28 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 21/29] ARM: orion5x: use DT to describe I2C devices on edmini_v2 Thomas Petazzoni
2014-04-13 15:28 ` Andrew Lunn
2014-04-13 15:43 ` Thomas Petazzoni
2014-04-13 15:53 ` Andrew Lunn
2014-04-14 10:53 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 22/29] ARM: orion5x: use DT to describe EHCI " Thomas Petazzoni
2014-04-14 10:57 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 23/29] ARM: orion5x: use DT to describe NOR " Thomas Petazzoni
2014-04-13 15:31 ` Andrew Lunn [this message]
2014-04-13 15:45 ` Thomas Petazzoni
2014-04-14 2:10 ` Chris Moore
2014-04-14 2:19 ` Chris Moore
2014-04-14 18:44 ` Andrew Lunn
2014-04-14 11:14 ` Sebastian Hesselbarth
2014-04-14 11:24 ` Thomas Petazzoni
2014-04-14 11:28 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 24/29] ARM: orion5x: keep TODO list in edmini_v2 DT Thomas Petazzoni
2014-04-14 11:17 ` Sebastian Hesselbarth
2014-04-15 2:59 ` Chris Moore
2014-04-13 14:40 ` [PATCH 25/29] ARM: orion5x: remove unneeded code for edmini_v2 Thomas Petazzoni
2014-04-14 11:18 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 26/29] ARM: orion5x: convert RD-88F5182 to Device Tree Thomas Petazzoni
2014-04-13 15:47 ` Andrew Lunn
2014-04-13 15:56 ` Thomas Petazzoni
2014-04-13 15:59 ` Andrew Lunn
2014-04-13 16:53 ` Thomas Petazzoni
2014-04-13 16:59 ` Sebastian Hesselbarth
2014-04-13 17:50 ` Arnd Bergmann
2014-04-14 8:01 ` Andrew Lunn
2014-04-14 9:08 ` Arnd Bergmann
2014-04-14 11:26 ` Sebastian Hesselbarth
2014-04-19 7:46 ` Thomas Petazzoni
2014-04-19 9:18 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 27/29] ARM: orion5x: convert d2net " Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 28/29] ARM: orion: remove no longer needed DT IRQ code Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 29/29] ARM: orion: remove no longer needed gpio DT code Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140413153150.GD10033@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox