From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 26/29] ARM: orion5x: convert RD-88F5182 to Device Tree
Date: Sun, 13 Apr 2014 17:56:58 +0200 [thread overview]
Message-ID: <20140413175658.64b65a76@skate> (raw)
In-Reply-To: <20140413154715.GE10033@lunn.ch>
Dear Andrew Lunn,
On Sun, 13 Apr 2014 17:47:15 +0200, Andrew Lunn wrote:
> > + rtc at 68 {
> > + pinctrl-0 = <&pmx_rtc>;
> > + pinctrl-names = "default";
> > + compatible = "ds1338";
>
> Hi Thomas
>
> Vendor prefix again.
Will do.
> > + reg = <0x68>;
> > + };
> > + };
> > +
> > + serial at 12000 {
> > + clock-frequency = <166666667>;
>
> I don't think you need this, so long as there is tclk in the node.
Ah, right, the 8250 driver is now capable of getting the clock rate
using a proper clock. Will fix that.
> > + gpio_leds {
> > + compatible = "gpio-leds";
> > + pinctrl-0 = <&pmx_debug_led>;
> > + pinctrl-names = "default";
> > +
> > + led at 0 {
> > + label = "rd88f5182:cpu";
> > + linux,default-trigger = "heartbeat";
>
> Jason probably won't like that.
I'm just doing a 1:1 functional conversion here.
>
> > + gpios = <&gpio0 0 0>;
>
> gpio.h defines?
Indeed. Missed that one it seems, as I used them pretty much everywhere
else.
> > +static int __init rd88f5182_pci_init(void)
> > +{
> > + if (of_machine_is_compatible("marvell,rd-88f5182-nas"))
> > + pci_common_init(&rd88f5182_pci);
> > +
> > + return 0;
> > +}
> > +
> > +subsys_initcall(rd88f5182_pci_init);
>
> Nice to see you are checking for compatibility in the initcall. How
> far do you think this from a multi_v5 kernel?
I haven't thought too much about this yet. I'm hoping to do more
Orion5x DT conversion once this patch series is done, and then think
about multiplatform support.
To be honest, I find it pretty useless to have half of the Kirkwood
and Dove support in mach-mvebu, and half still in
mach-kirkwood/mach-dove, because it doesn't allow to remove any of the
legacy code in mach-kirkwood and mach-dove. But oh, well, I guess it's
only a temporary situation, until more boards are converted, or their
support simply removed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-13 15:56 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 14:39 [PATCH 00/29] ARM: orion5x: big step towards DT conversion Thomas Petazzoni
2014-04-13 14:39 ` [PATCH 01/29] ARM: orion5x: fix target ID for crypto SRAM window Thomas Petazzoni
2014-04-14 8:59 ` Sebastian Hesselbarth
2014-04-17 4:55 ` Jason Cooper
2014-04-13 14:39 ` [PATCH 02/29] pinctrl: mvebu: new driver for Orion platforms Thomas Petazzoni
2014-04-14 9:15 ` Sebastian Hesselbarth
2014-04-19 17:28 ` Thomas Petazzoni
2014-04-20 10:04 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 03/29] clk: mvebu: add Orion5x clock driver Thomas Petazzoni
2014-04-14 9:27 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 04/29] memory: mvebu-devbus: fix the conversion of the bus width Thomas Petazzoni
2014-04-14 9:30 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 05/29] memory: mvebu-devbus: use ARMADA_ prefix in defines Thomas Petazzoni
2014-04-14 9:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 06/29] memory: mvebu-devbus: split functions Thomas Petazzoni
2014-04-14 9:36 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 07/29] memory: mvebu-devbus: add Orion5x support Thomas Petazzoni
2014-04-14 9:41 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 08/29] ARM: orion5x: move interrupt controller node into ocp Thomas Petazzoni
2014-04-14 9:42 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 09/29] ARM: orion5x: switch to preprocessor includes in DT Thomas Petazzoni
2014-04-14 9:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 10/29] ARM: orion5x: use existing dt-bindings include for Device Tree files Thomas Petazzoni
2014-04-14 9:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 11/29] ARM: orion5x: convert DT to use the mvebu-mbus driver Thomas Petazzoni
2014-04-14 10:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 12/29] ARM: orion5x: add interrupt for Ethernet in Device Tree Thomas Petazzoni
2014-04-14 10:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 13/29] ARM: orion5x: switch to use the clock driver for DT platforms Thomas Petazzoni
2014-04-14 10:35 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 14/29] ARM: orion: switch to a per-platform handle_irq() function Thomas Petazzoni
2014-04-14 10:40 ` Sebastian Hesselbarth
2014-04-19 7:27 ` Thomas Petazzoni
2014-04-19 9:09 ` Sebastian Hesselbarth
2014-04-19 12:04 ` Thomas Petazzoni
2014-04-19 16:16 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 15/29] ARM: orion5x: switch to DT interrupts and timer Thomas Petazzoni
2014-04-14 10:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 16/29] ARM: orion5x: enable pinctrl driver at SoC level Thomas Petazzoni
2014-04-14 10:44 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 17/29] ARM: orion5x: update I2C description " Thomas Petazzoni
2014-04-14 10:45 ` Sebastian Hesselbarth
2014-04-19 7:38 ` Thomas Petazzoni
2014-04-19 9:10 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 18/29] ARM: orion5x: add Device Bus " Thomas Petazzoni
2014-04-14 10:47 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 19/29] ARM: orion5x: add standard pinctrl configs for sata0 and sata1 Thomas Petazzoni
2014-04-14 10:48 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 20/29] ARM: orion5x: convert edmini_v2 to DT pinctrl Thomas Petazzoni
2014-04-13 15:26 ` Andrew Lunn
2014-04-13 15:41 ` Thomas Petazzoni
2014-04-14 10:51 ` Sebastian Hesselbarth
2014-04-14 11:23 ` Thomas Petazzoni
2014-04-14 11:27 ` Sebastian Hesselbarth
2014-04-14 12:06 ` Andrew Lunn
2014-04-14 12:24 ` Ezequiel Garcia
2014-04-14 12:28 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 21/29] ARM: orion5x: use DT to describe I2C devices on edmini_v2 Thomas Petazzoni
2014-04-13 15:28 ` Andrew Lunn
2014-04-13 15:43 ` Thomas Petazzoni
2014-04-13 15:53 ` Andrew Lunn
2014-04-14 10:53 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 22/29] ARM: orion5x: use DT to describe EHCI " Thomas Petazzoni
2014-04-14 10:57 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 23/29] ARM: orion5x: use DT to describe NOR " Thomas Petazzoni
2014-04-13 15:31 ` Andrew Lunn
2014-04-13 15:45 ` Thomas Petazzoni
2014-04-14 2:10 ` Chris Moore
2014-04-14 2:19 ` Chris Moore
2014-04-14 18:44 ` Andrew Lunn
2014-04-14 11:14 ` Sebastian Hesselbarth
2014-04-14 11:24 ` Thomas Petazzoni
2014-04-14 11:28 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 24/29] ARM: orion5x: keep TODO list in edmini_v2 DT Thomas Petazzoni
2014-04-14 11:17 ` Sebastian Hesselbarth
2014-04-15 2:59 ` Chris Moore
2014-04-13 14:40 ` [PATCH 25/29] ARM: orion5x: remove unneeded code for edmini_v2 Thomas Petazzoni
2014-04-14 11:18 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 26/29] ARM: orion5x: convert RD-88F5182 to Device Tree Thomas Petazzoni
2014-04-13 15:47 ` Andrew Lunn
2014-04-13 15:56 ` Thomas Petazzoni [this message]
2014-04-13 15:59 ` Andrew Lunn
2014-04-13 16:53 ` Thomas Petazzoni
2014-04-13 16:59 ` Sebastian Hesselbarth
2014-04-13 17:50 ` Arnd Bergmann
2014-04-14 8:01 ` Andrew Lunn
2014-04-14 9:08 ` Arnd Bergmann
2014-04-14 11:26 ` Sebastian Hesselbarth
2014-04-19 7:46 ` Thomas Petazzoni
2014-04-19 9:18 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 27/29] ARM: orion5x: convert d2net " Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 28/29] ARM: orion: remove no longer needed DT IRQ code Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 29/29] ARM: orion: remove no longer needed gpio DT code Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140413175658.64b65a76@skate \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox