From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 02/29] pinctrl: mvebu: new driver for Orion platforms
Date: Sat, 19 Apr 2014 19:28:46 +0200 [thread overview]
Message-ID: <20140419192846.78ff71ab@skate> (raw)
In-Reply-To: <534BA725.9010609@gmail.com>
Sebastian,
Thanks for your review!
On Mon, 14 Apr 2014 11:15:17 +0200, Sebastian Hesselbarth wrote:
> > +* Marvell Orion 88f5182
> > +
> > +name pins functions
> > +================================================================================
> > +mpp0 0 pci(rstout), pci(req2), gpio
>
> Shouldn't the above pcie(rstout)?
>
> The one available datasheet I have for 5182 names the function
> PEX_RST_OUTn, which is PCIexpress then.
Indeed, fixed.
> > +mpp1 1 gpio, pci(gnt2)
> > +mpp2 2 gpio, pci(req3), pci(pme)
>
> pinctrl-mvebu isn't that good with identically named functions.
> You need to rename one of the "pci" functions to e.g. "pci-1".
Done.
> > +mpp3 3 gpio, pci(gnt3)
> > +mpp4 4 gpio, pci(req4), bootnand(re), sata0(prsnt)
> > +mpp5 5 gpio, pci(gnt4), bootnand(we), sata1(prsnt)
> > +mpp6 6 gpio, pci(req5), nand(re0), sata0(act)
> > +mpp7 7 gpio, pci(gnt5), nand(we0), sata1(act)
> > +mpp8 8 gpio, ge(col)
> > +mpp9 9 gpio, ge(rxerr)
> > +mpp10 10 gpio, ge(crs)
> > +mpp11 11 gpio, ge(txerr)
> > +mpp12 12 gpio, ge(txd4), nand(re1), sata0(ledprsnt)
> > +mpp13 13 gpio, ge(txd5), nand(we1), sata1(ledprsnt)
> > +mpp14 14 gpio, ge(txd6), nand(re2), sata0(ledact)
> > +mpp15 15 gpio, ge(txd7), nand(we2), sata1(ledact)
>
> Four "led" prefixes above should be removed.
I don't agree, because there would then be no difference between
sata0(act) and sata0(ledact), even if in the datasheet, their
description is different:
* SATA 0 active indication (for which I've used "sata0(act)")
* SATA 0 presence LED indication (Active Low) (for which I've used
"sata0(ledact)")
Do you have another suggestion?
> > +static struct mvebu_mpp_ctrl orion_mpp_controls[] = {
> > + MPP_FUNC_CTRL(0, 19, NULL, orion_mpp_ctrl),
> > +};
> > +
> > +static struct pinctrl_gpio_range mv88f5181l_gpio_ranges[] = {
> > + MPP_GPIO_RANGE(0, 0, 0, 16),
> > +};
> > +
> > +static struct pinctrl_gpio_range mv88f5182_gpio_ranges[] = {
> > + MPP_GPIO_RANGE(0, 0, 0, 19),
> > +};
> > +
> > +static struct pinctrl_gpio_range mv88f5281_gpio_ranges[] = {
> > + MPP_GPIO_RANGE(0, 0, 0, 16),
> > +};
>
> mv88f5181l_gpio_ranges == mv88f5281_gpio_ranges.
>
> You can possibly join them to mv88f5x81_gpio ranges, but I have
> no strong opinion about it.
I prefer to have them all for each SoC, for consistency.
> > +static int orion_pinctrl_probe(struct platform_device *pdev)
> > +{
> > + const struct of_device_id *match =
> > + of_match_device(orion_pinctrl_of_match, &pdev->dev);
> > + struct resource *res;
> > +
> > + pdev->dev.platform_data = (void*) match->data;
>
> Useless (void *) cast?
No: there is the same cast in pinctrl-dove.c and pinctrl-kirkwood.c.
The reason is a bit ugly: match->data is "const" but
pdev->dev.platform_data is not. Certainly something to fix at some
point, but probably not as part of this patch series, since Dove and
Kirkwood are already doing the bad thing :)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-19 17:28 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 14:39 [PATCH 00/29] ARM: orion5x: big step towards DT conversion Thomas Petazzoni
2014-04-13 14:39 ` [PATCH 01/29] ARM: orion5x: fix target ID for crypto SRAM window Thomas Petazzoni
2014-04-14 8:59 ` Sebastian Hesselbarth
2014-04-17 4:55 ` Jason Cooper
2014-04-13 14:39 ` [PATCH 02/29] pinctrl: mvebu: new driver for Orion platforms Thomas Petazzoni
2014-04-14 9:15 ` Sebastian Hesselbarth
2014-04-19 17:28 ` Thomas Petazzoni [this message]
2014-04-20 10:04 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 03/29] clk: mvebu: add Orion5x clock driver Thomas Petazzoni
2014-04-14 9:27 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 04/29] memory: mvebu-devbus: fix the conversion of the bus width Thomas Petazzoni
2014-04-14 9:30 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 05/29] memory: mvebu-devbus: use ARMADA_ prefix in defines Thomas Petazzoni
2014-04-14 9:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 06/29] memory: mvebu-devbus: split functions Thomas Petazzoni
2014-04-14 9:36 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 07/29] memory: mvebu-devbus: add Orion5x support Thomas Petazzoni
2014-04-14 9:41 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 08/29] ARM: orion5x: move interrupt controller node into ocp Thomas Petazzoni
2014-04-14 9:42 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 09/29] ARM: orion5x: switch to preprocessor includes in DT Thomas Petazzoni
2014-04-14 9:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 10/29] ARM: orion5x: use existing dt-bindings include for Device Tree files Thomas Petazzoni
2014-04-14 9:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 11/29] ARM: orion5x: convert DT to use the mvebu-mbus driver Thomas Petazzoni
2014-04-14 10:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 12/29] ARM: orion5x: add interrupt for Ethernet in Device Tree Thomas Petazzoni
2014-04-14 10:33 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 13/29] ARM: orion5x: switch to use the clock driver for DT platforms Thomas Petazzoni
2014-04-14 10:35 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 14/29] ARM: orion: switch to a per-platform handle_irq() function Thomas Petazzoni
2014-04-14 10:40 ` Sebastian Hesselbarth
2014-04-19 7:27 ` Thomas Petazzoni
2014-04-19 9:09 ` Sebastian Hesselbarth
2014-04-19 12:04 ` Thomas Petazzoni
2014-04-19 16:16 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 15/29] ARM: orion5x: switch to DT interrupts and timer Thomas Petazzoni
2014-04-14 10:43 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 16/29] ARM: orion5x: enable pinctrl driver at SoC level Thomas Petazzoni
2014-04-14 10:44 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 17/29] ARM: orion5x: update I2C description " Thomas Petazzoni
2014-04-14 10:45 ` Sebastian Hesselbarth
2014-04-19 7:38 ` Thomas Petazzoni
2014-04-19 9:10 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 18/29] ARM: orion5x: add Device Bus " Thomas Petazzoni
2014-04-14 10:47 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 19/29] ARM: orion5x: add standard pinctrl configs for sata0 and sata1 Thomas Petazzoni
2014-04-14 10:48 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 20/29] ARM: orion5x: convert edmini_v2 to DT pinctrl Thomas Petazzoni
2014-04-13 15:26 ` Andrew Lunn
2014-04-13 15:41 ` Thomas Petazzoni
2014-04-14 10:51 ` Sebastian Hesselbarth
2014-04-14 11:23 ` Thomas Petazzoni
2014-04-14 11:27 ` Sebastian Hesselbarth
2014-04-14 12:06 ` Andrew Lunn
2014-04-14 12:24 ` Ezequiel Garcia
2014-04-14 12:28 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 21/29] ARM: orion5x: use DT to describe I2C devices on edmini_v2 Thomas Petazzoni
2014-04-13 15:28 ` Andrew Lunn
2014-04-13 15:43 ` Thomas Petazzoni
2014-04-13 15:53 ` Andrew Lunn
2014-04-14 10:53 ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 22/29] ARM: orion5x: use DT to describe EHCI " Thomas Petazzoni
2014-04-14 10:57 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 23/29] ARM: orion5x: use DT to describe NOR " Thomas Petazzoni
2014-04-13 15:31 ` Andrew Lunn
2014-04-13 15:45 ` Thomas Petazzoni
2014-04-14 2:10 ` Chris Moore
2014-04-14 2:19 ` Chris Moore
2014-04-14 18:44 ` Andrew Lunn
2014-04-14 11:14 ` Sebastian Hesselbarth
2014-04-14 11:24 ` Thomas Petazzoni
2014-04-14 11:28 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 24/29] ARM: orion5x: keep TODO list in edmini_v2 DT Thomas Petazzoni
2014-04-14 11:17 ` Sebastian Hesselbarth
2014-04-15 2:59 ` Chris Moore
2014-04-13 14:40 ` [PATCH 25/29] ARM: orion5x: remove unneeded code for edmini_v2 Thomas Petazzoni
2014-04-14 11:18 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 26/29] ARM: orion5x: convert RD-88F5182 to Device Tree Thomas Petazzoni
2014-04-13 15:47 ` Andrew Lunn
2014-04-13 15:56 ` Thomas Petazzoni
2014-04-13 15:59 ` Andrew Lunn
2014-04-13 16:53 ` Thomas Petazzoni
2014-04-13 16:59 ` Sebastian Hesselbarth
2014-04-13 17:50 ` Arnd Bergmann
2014-04-14 8:01 ` Andrew Lunn
2014-04-14 9:08 ` Arnd Bergmann
2014-04-14 11:26 ` Sebastian Hesselbarth
2014-04-19 7:46 ` Thomas Petazzoni
2014-04-19 9:18 ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 27/29] ARM: orion5x: convert d2net " Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 28/29] ARM: orion: remove no longer needed DT IRQ code Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 29/29] ARM: orion: remove no longer needed gpio DT code Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140419192846.78ff71ab@skate \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox