Re: [PATCH v4 05/21] PM / devfreq: rockchip-dfi: dfi store raw values in counter struct

From: Jonathan Cameron <Jonathan.Cameron@Huawei•com>
To: Sascha Hauer <s.hauer@pengutronix•de>
Cc: <linux-rockchip@lists•infradead.org>,
	<linux-arm-kernel@lists•infradead.org>,
	Heiko Stuebner <heiko@sntech•de>,
	Kyungmin Park <kyungmin.park@samsung•com>,
	MyungJoo Ham <myungjoo.ham@samsung•com>,
	Will Deacon <will@kernel•org>,
	Mark Rutland <mark.rutland@arm•com>, <kernel@pengutronix•de>,
	Michael Riesch <michael.riesch@wolfvision•net>
Subject: Re: [PATCH v4 05/21] PM / devfreq: rockchip-dfi: dfi store raw values in counter struct
Date: Tue, 16 May 2023 16:43:12 +0100	[thread overview]
Message-ID: <20230516164312.00002c3c@Huawei.com> (raw)
In-Reply-To: <20230505113856.463650-6-s.hauer@pengutronix.de>

On Fri,  5 May 2023 13:38:40 +0200
Sascha Hauer <s.hauer@pengutronix•de> wrote:

> When adding perf support to the DFI driver the perf part will
> need the raw counter values, so move the fixed * 4 factor to
> rockchip_dfi_get_event().
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix•de>
Given there are no docs for that structure anyway and access is vague
enough that it could be any scale, this looks fine to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei•com>

> ---
>  drivers/devfreq/event/rockchip-dfi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index f317d3d063e9c..383fe8a17a512 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -97,7 +97,7 @@ static int rockchip_dfi_get_busier_ch(struct devfreq_event_dev *edev)
>  	/* Find out which channel is busier */
>  	for (i = 0; i < RK3399_DMC_NUM_CH; i++) {
>  		dfi->ch_usage[i].access = readl_relaxed(dfi_regs +
> -				DDRMON_CH0_DFI_ACCESS_NUM + i * 20) * 4;
> +				DDRMON_CH0_DFI_ACCESS_NUM + i * 20);
>  		dfi->ch_usage[i].total = readl_relaxed(dfi_regs +
>  				DDRMON_CH0_COUNT_NUM + i * 20);
>  		tmp = dfi->ch_usage[i].access;
> @@ -149,7 +149,7 @@ static int rockchip_dfi_get_event(struct devfreq_event_dev *edev,
>  
>  	busier_ch = rockchip_dfi_get_busier_ch(edev);
>  
> -	edata->load_count = dfi->ch_usage[busier_ch].access;
> +	edata->load_count = dfi->ch_usage[busier_ch].access * 4;
>  	edata->total_count = dfi->ch_usage[busier_ch].total;
>  
>  	return 0;


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel