From: rnayak@ti•com (Rajendra Nayak)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset
Date: Tue, 28 Feb 2012 11:04:51 +0530 [thread overview]
Message-ID: <4F4C677B.4020501@ti.com> (raw)
In-Reply-To: <87ehtfssx7.fsf@ti.com>
Hi Kevin,
On Tuesday 28 February 2012 05:58 AM, Kevin Hilman wrote:
> Tero Kristo<t-kristo@ti•com> writes:
>
>> From: Rajendra Nayak<rnayak@ti•com>
>>
>> With no driver handling DSP/TESLA, if brought out of reset, it stays
>> active and does not assert standby.
>>
>> Signed-off-by: Rajendra Nayak<rnayak@ti•com>
>> Signed-off-by: Tero Kristo<t-kristo@ti•com>
>
> Subject says 'OMAP4: suspend'. How does HWMOD_INIT_NO_RESET affect
> suspend?
The v2 of this patch posted by Tero has a better $subject as suggested
by Benoit which says 'ARM: OMAP4: hwmod_data: Do not get DSP out of
reset at boot time'
The intention of this patch is to *not* get DSP out of reset at boot,
because once out of reset DSP needs some code that executes a 'wfi'
equivalent for it to assert a standby and allow suspend to sleep.
regards,
Rajendra
>
> Kevin
>
>> ---
>> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index ef0524c..81d90da 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -1160,6 +1160,7 @@ static struct omap_hwmod omap44xx_dsp_hwmod = {
>> .name = "dsp",
>> .class =&omap44xx_dsp_hwmod_class,
>> .clkdm_name = "tesla_clkdm",
>> + .flags = HWMOD_INIT_NO_RESET,
>> .mpu_irqs = omap44xx_dsp_irqs,
>> .rst_lines = omap44xx_dsp_resets,
>> .rst_lines_cnt = ARRAY_SIZE(omap44xx_dsp_resets),
next prev parent reply other threads:[~2012-02-28 5:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:21 [PATCH 0/6] ARM: OMAP4: core retention support Tero Kristo
2012-02-23 13:21 ` [PATCH 1/6] arm: omap4: suspend: Program all domains to RET Tero Kristo
2012-02-23 13:45 ` Shilimkar, Santosh
2012-02-23 13:21 ` [PATCH 2/6] ARM: OMAP4 PM: Add IO Daisychain support Tero Kristo
2012-02-23 13:48 ` Shilimkar, Santosh
2012-02-24 6:59 ` Rajendra Nayak
2012-02-24 8:53 ` Shilimkar, Santosh
2012-02-23 15:58 ` Elaidi, Djamil
2012-02-24 6:50 ` Rajendra Nayak
2012-02-23 13:21 ` [PATCH 3/6] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Tero Kristo
2012-02-23 13:53 ` Shilimkar, Santosh
2012-02-24 14:35 ` Tero Kristo
2012-02-28 0:24 ` Kevin Hilman
2012-02-23 13:21 ` [PATCH 4/6] arm: omap4: prm: fix interrupt register offsets Tero Kristo
2012-02-28 0:25 ` Kevin Hilman
2012-02-23 13:21 ` [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset Tero Kristo
2012-02-23 13:56 ` Shilimkar, Santosh
2012-02-23 20:44 ` Cousson, Benoit
2012-02-28 0:28 ` Kevin Hilman
2012-02-28 5:34 ` Rajendra Nayak [this message]
2012-02-23 13:22 ` [PATCH 6/6] arm: omap3+: add prcm chain interrupts to the interrupt list Tero Kristo
2012-02-28 1:25 ` [PATCH 0/6] ARM: OMAP4: core retention support Kevin Hilman
2012-02-28 7:24 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4C677B.4020501@ti.com \
--to=rnayak@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox