From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/6] arm: omap4: prm: fix interrupt register offsets
Date: Mon, 27 Feb 2012 16:25:57 -0800 [thread overview]
Message-ID: <87k437st0q.fsf@ti.com> (raw)
In-Reply-To: <1330003320-17400-5-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Thu, 23 Feb 2012 15:21:58 +0200")
Tero Kristo <t-kristo@ti•com> writes:
> Previous code used wrong instance for the interrupt register access.
> Use the right one which is OCP_SOCKET.
>
> Signed-off-by: Tero Kristo <t-kristo@ti•com>
> Cc: Paul Walmsley <paul@pwsan•com>
> ---
> arch/arm/mach-omap2/prm44xx.c | 21 +++++++++++----------
> 1 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 1557647..a6efbdf 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -145,8 +145,9 @@ static inline u32 _read_pending_irq_reg(u16 irqen_offs, u16 irqst_offs)
> u32 mask, st;
>
> /* XXX read mask from RAM? */
> - mask = omap4_prm_read_inst_reg(OMAP4430_PRM_DEVICE_INST, irqen_offs);
> - st = omap4_prm_read_inst_reg(OMAP4430_PRM_DEVICE_INST, irqst_offs);
> + mask = omap4_prm_read_inst_reg(OMAP4430_PRM_OCP_SOCKET_INST,
> + irqen_offs);
nit: indentaion. this line should be indented and star at the same
place as OMAP4430_PRM_OCP....
Kevin
next prev parent reply other threads:[~2012-02-28 0:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:21 [PATCH 0/6] ARM: OMAP4: core retention support Tero Kristo
2012-02-23 13:21 ` [PATCH 1/6] arm: omap4: suspend: Program all domains to RET Tero Kristo
2012-02-23 13:45 ` Shilimkar, Santosh
2012-02-23 13:21 ` [PATCH 2/6] ARM: OMAP4 PM: Add IO Daisychain support Tero Kristo
2012-02-23 13:48 ` Shilimkar, Santosh
2012-02-24 6:59 ` Rajendra Nayak
2012-02-24 8:53 ` Shilimkar, Santosh
2012-02-23 15:58 ` Elaidi, Djamil
2012-02-24 6:50 ` Rajendra Nayak
2012-02-23 13:21 ` [PATCH 3/6] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Tero Kristo
2012-02-23 13:53 ` Shilimkar, Santosh
2012-02-24 14:35 ` Tero Kristo
2012-02-28 0:24 ` Kevin Hilman
2012-02-23 13:21 ` [PATCH 4/6] arm: omap4: prm: fix interrupt register offsets Tero Kristo
2012-02-28 0:25 ` Kevin Hilman [this message]
2012-02-23 13:21 ` [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset Tero Kristo
2012-02-23 13:56 ` Shilimkar, Santosh
2012-02-23 20:44 ` Cousson, Benoit
2012-02-28 0:28 ` Kevin Hilman
2012-02-28 5:34 ` Rajendra Nayak
2012-02-23 13:22 ` [PATCH 6/6] arm: omap3+: add prcm chain interrupts to the interrupt list Tero Kristo
2012-02-28 1:25 ` [PATCH 0/6] ARM: OMAP4: core retention support Kevin Hilman
2012-02-28 7:24 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k437st0q.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox