From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/6] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux
Date: Mon, 27 Feb 2012 16:24:06 -0800 [thread overview]
Message-ID: <87pqczst3t.fsf@ti.com> (raw)
In-Reply-To: <1330003320-17400-4-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Thu, 23 Feb 2012 15:21:57 +0200")
Tero Kristo <t-kristo@ti•com> writes:
> From: Vishwanath BS <vishwanath.bs@ti•com>
>
> IO Daisychain feature has to be triggered whenever there is a change in
> device's mux configuration (See section 3.9.4 in OMAP4 Public TRM vP).
>
> Now devices can idle independent of the powerdomain, there can be a
> window where device is idled and corresponding powerdomain can be
> ON/INACTIVE state. In such situations, since both module wake up is
> enabled at padlevel as well as io daisychain sequence is triggered,
> there will be 2 PRCM interrupts (Module async wake up via swakeup and
> IO Pad interrupt). But as PRCM Interrupt handler clears the Module
> Padlevel WKST bit in the first interrupt, module specific interrupt
> handler will not triggered for the second time
>
> Also look at detailed explanation given by Rajendra at
> http://www.spinics.net/lists/linux-serial/msg04480.html
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti•com>
> Signed-off-by: Tero Kristo <t-kristo@ti•com>
My review comments from the last version of this patch were not
answered/addressed:
http://marc.info/?l=linux-omap&m=132621832120535&w=2
[...]
> @@ -64,6 +65,12 @@ static void omap2_init_processor_devices(void)
> }
> }
>
> +void omap_trigger_wuclk_ctrl(void)
> +{
> + if (cpu_is_omap44xx())
> + omap4_trigger_wuclk_ctrl();
> +}
Subject says OMAP3+, but clearly this only works on OMAP4.
Also, no cpu_is* checks at runtime please. Instead, at init time, use
cpu_is_* to initialize a function pointer.
Kevin
next prev parent reply other threads:[~2012-02-28 0:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:21 [PATCH 0/6] ARM: OMAP4: core retention support Tero Kristo
2012-02-23 13:21 ` [PATCH 1/6] arm: omap4: suspend: Program all domains to RET Tero Kristo
2012-02-23 13:45 ` Shilimkar, Santosh
2012-02-23 13:21 ` [PATCH 2/6] ARM: OMAP4 PM: Add IO Daisychain support Tero Kristo
2012-02-23 13:48 ` Shilimkar, Santosh
2012-02-24 6:59 ` Rajendra Nayak
2012-02-24 8:53 ` Shilimkar, Santosh
2012-02-23 15:58 ` Elaidi, Djamil
2012-02-24 6:50 ` Rajendra Nayak
2012-02-23 13:21 ` [PATCH 3/6] ARM: OMAP3PLUS PM: Add IO Daisychain support via hwmod mux Tero Kristo
2012-02-23 13:53 ` Shilimkar, Santosh
2012-02-24 14:35 ` Tero Kristo
2012-02-28 0:24 ` Kevin Hilman [this message]
2012-02-23 13:21 ` [PATCH 4/6] arm: omap4: prm: fix interrupt register offsets Tero Kristo
2012-02-28 0:25 ` Kevin Hilman
2012-02-23 13:21 ` [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset Tero Kristo
2012-02-23 13:56 ` Shilimkar, Santosh
2012-02-23 20:44 ` Cousson, Benoit
2012-02-28 0:28 ` Kevin Hilman
2012-02-28 5:34 ` Rajendra Nayak
2012-02-23 13:22 ` [PATCH 6/6] arm: omap3+: add prcm chain interrupts to the interrupt list Tero Kristo
2012-02-28 1:25 ` [PATCH 0/6] ARM: OMAP4: core retention support Kevin Hilman
2012-02-28 7:24 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqczst3t.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox