From: gerg@snapgear•com (Greg Ungerer)
To: linux-arm-kernel@lists•infradead.org
Subject: Freescale fec.c driver breakage
Date: Mon, 4 Jun 2012 14:42:28 +1000 [thread overview]
Message-ID: <4FCC3CB4.5030107@snapgear.com> (raw)
Hi Sascha,
Commit f4d40de39a23f0c39cca55ac63e1175c69c3d2f7 ("net fec: do not
depend on grouped clocks") breaks compilation of the FEC driver for
non iMX platforms in linux-3.5-rc1. For example when compiling for
ColdFire I get:
LD vmlinux
drivers/built-in.o: In function `fec_probe':
fec.c:(.devinit.text+0x1e0): undefined reference to `devm_clk_get'
Trivially we could conditionalize the code block that calls
devm_clk_get() in the probe routine, but that is kind of ugly.
Can you come up with a better fix?
Regards
Greg
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg at snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next reply other threads:[~2012-06-04 4:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 4:42 Greg Ungerer [this message]
2012-06-04 8:19 ` Freescale fec.c driver breakage Sascha Hauer
2012-06-04 9:16 ` Mark Brown
2012-06-05 6:55 ` Greg Ungerer
2012-06-05 9:41 ` Mark Brown
2012-06-05 12:17 ` Greg Ungerer
2012-06-05 12:24 ` Mark Brown
2012-06-05 12:36 ` Greg Ungerer
2012-06-05 12:40 ` Mark Brown
2012-06-05 12:48 ` Sascha Hauer
2012-06-05 13:24 ` Greg Ungerer
2012-06-05 13:41 ` Mark Brown
2012-06-05 14:35 ` Steven King
2012-06-06 7:41 ` Greg Ungerer
2012-06-07 23:36 ` Mark Brown
2012-06-05 13:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCC3CB4.5030107@snapgear.com \
--to=gerg@snapgear$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox