public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: gerg@snapgear•com (Greg Ungerer)
To: linux-arm-kernel@lists•infradead.org
Subject: Freescale fec.c driver breakage
Date: Wed, 6 Jun 2012 17:41:08 +1000	[thread overview]
Message-ID: <4FCF0994.4040902@snapgear.com> (raw)
In-Reply-To: <201206050735.00458.sfking@fdwdc.com>

On 06/06/12 00:35, Steven King wrote:
> On Tuesday 05 June 2012 6:41:16 am Mark Brown wrote:
>> On Tue, Jun 05, 2012 at 11:24:29PM +1000, Greg Ungerer wrote:
>>> Well, yeah, of course there are clocks involved. But you pretty much
>>> hit the point here. 'ipg' and 'ahb' here are platform specific.
>>
>> What should be happening for that is that the driver requests with some
>> generic name which is referenced to the IP (unfortunately these are
>> usually not documented for the public...) and then clkdev or some
>> platform specific code is used to map the names onto the underlying
>> clocks.
>>
>> If 'ahb' isn't suitable how about 'bus', and for 'ipg' how about 'mclk'
>> or something?
>
> Some of the newer Coldfire parts such as the m54455/m5441x do have software
> controllable clocks; but they keep it simple with one clock per fec, and
> names in the documentation like 'fec0, fec1' for the m54455
> and 'macnet0,macnet1' for the m5441x.

Most of the older ones don't. Most of the older parts that have a FEC
core have a single clock-in for the chip, possibly a PLL and often a
fixed divisor for distribuion to all on-chip peripherals. I have seen it
named various names, 'bclko', 'mclk', "fsys/2", nothing seems consistent.

I think very generic namse might be the best solution here.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  reply	other threads:[~2012-06-06  7:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04  4:42 Freescale fec.c driver breakage Greg Ungerer
2012-06-04  8:19 ` Sascha Hauer
2012-06-04  9:16   ` Mark Brown
2012-06-05  6:55     ` Greg Ungerer
2012-06-05  9:41       ` Mark Brown
2012-06-05 12:17         ` Greg Ungerer
2012-06-05 12:24           ` Mark Brown
2012-06-05 12:36             ` Greg Ungerer
2012-06-05 12:40               ` Mark Brown
2012-06-05 12:48           ` Sascha Hauer
2012-06-05 13:24             ` Greg Ungerer
2012-06-05 13:41               ` Mark Brown
2012-06-05 14:35                 ` Steven King
2012-06-06  7:41                   ` Greg Ungerer [this message]
2012-06-07 23:36                     ` Mark Brown
2012-06-05 13:42               ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCF0994.4040902@snapgear.com \
    --to=gerg@snapgear$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox