From: gerg@snapgear•com (Greg Ungerer)
To: linux-arm-kernel@lists•infradead.org
Subject: Freescale fec.c driver breakage
Date: Tue, 5 Jun 2012 16:55:23 +1000 [thread overview]
Message-ID: <4FCDAD5B.8010106@snapgear.com> (raw)
In-Reply-To: <20120604091616.GA3943@opensource.wolfsonmicro.com>
On 04/06/12 19:16, Mark Brown wrote:
> On Mon, Jun 04, 2012 at 10:19:37AM +0200, Sascha Hauer wrote:
>> On Mon, Jun 04, 2012 at 02:42:28PM +1000, Greg Ungerer wrote:
>
>>> Trivially we could conditionalize the code block that calls
>>> devm_clk_get() in the probe routine, but that is kind of ugly.
>
>> It's ugly, but the only other solution I see is that you could provide a
>> dummy devm_clk_get() for coldfire. Added Mark to Cc, maybe he has
>> another idea?
>
> Not really, I think if the clock API is going to be usable we really
> need the platforms to all be implementing it. Part of this is getting
> the stubs for !HAVE_CLK cases implemented (which doesn't seem to have
> happened :/) ). We do need to address this at the framework level,
> having to put ifdefs in all the drivers is obviously awful.
Is this something you intend "fixing" then?
I don't mind putting a simplistic (but do nothing) place holder for
this function along with the other stubbed clk functions in the m68k/
coldfire code.
But more generally I am wondering does it make sense to be working
on specific platform clocks in a multi-platform/arch driver?
Regards
Greg
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg at snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-06-05 6:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 4:42 Freescale fec.c driver breakage Greg Ungerer
2012-06-04 8:19 ` Sascha Hauer
2012-06-04 9:16 ` Mark Brown
2012-06-05 6:55 ` Greg Ungerer [this message]
2012-06-05 9:41 ` Mark Brown
2012-06-05 12:17 ` Greg Ungerer
2012-06-05 12:24 ` Mark Brown
2012-06-05 12:36 ` Greg Ungerer
2012-06-05 12:40 ` Mark Brown
2012-06-05 12:48 ` Sascha Hauer
2012-06-05 13:24 ` Greg Ungerer
2012-06-05 13:41 ` Mark Brown
2012-06-05 14:35 ` Steven King
2012-06-06 7:41 ` Greg Ungerer
2012-06-07 23:36 ` Mark Brown
2012-06-05 13:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCDAD5B.8010106@snapgear.com \
--to=gerg@snapgear$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox