From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support
Date: Thu, 14 Mar 2013 00:45:03 +0300 [thread overview]
Message-ID: <5140F35F.3090702@cogentembedded.com> (raw)
In-Reply-To: <1352446306-19945-3-git-send-email-horms@verge.net.au>
Hello.
On 11/09/2012 10:31 AM, Simon Horman wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
>
> This patch supports CN21/CN22 USB 2.0 (port 0/1/2),
> and enable USB momery on defconfig
Sorry for late comment but I'm studying this code just now (in order
to add R-Car M1A USB support).
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
> Signed-off-by: Simon Horman <horms@verge•net.au>
> ---
> arch/arm/configs/marzen_defconfig | 6 ++
> arch/arm/mach-shmobile/Kconfig | 1 +
> arch/arm/mach-shmobile/board-marzen.c | 108 ++++++++++++++++++++++++++++++++-
> 3 files changed, 114 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-marzen.c b/arch/arm/mach-shmobile/board-marzen.c
> index 74c7f0b..707b3bd 100644
> --- a/arch/arm/mach-shmobile/board-marzen.c
> +++ b/arch/arm/mach-shmobile/board-marzen.c
> @@ -34,6 +34,9 @@
[...]
> @@ -172,6 +175,101 @@ static struct platform_device *marzen_devices[] __initdata = {
> &usb_phy_device,
> };
>
> +/* USB */
> +static struct usb_phy *phy;
> +static int usb_power_on(struct platform_device *pdev)
> +{
> + if (!phy)
> + return -EIO;
> +
> + pm_runtime_enable(&pdev->dev);
> + pm_runtime_get_sync(&pdev->dev);
> +
> + usb_phy_init(phy);
> +
> + return 0;
> +}
> +
> +static void usb_power_off(struct platform_device *pdev)
> +{
> + if (!phy)
> + return;
> +
> + usb_phy_shutdown(phy);
> +
> + pm_runtime_put_sync(&pdev->dev);
> + pm_runtime_disable(&pdev->dev);
> +}
> +
> +static struct usb_ehci_pdata ehcix_pdata = {
> + .power_on = usb_power_on,
> + .power_off = usb_power_off,
> + .power_suspend = usb_power_off,
> +};
> +
> +static struct resource ehci0_resources[] = {
> + [0] = {
> + .start = 0xffe70000,
> + .end = 0xffe70400 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = gic_spi(44),
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static struct platform_device ehci0_device = {
> + .name = "ehci-platform",
> + .id = 0,
> + .dev = {
> + .dma_mask = &ehci0_device.dev.coherent_dma_mask,
> + .coherent_dma_mask = 0xffffffff,
> + .platform_data = &ehcix_pdata,
> + },
> + .num_resources = ARRAY_SIZE(ehci0_resources),
> + .resource = ehci0_resources,
> +};
> +
> +static struct resource ehci1_resources[] = {
> + [0] = {
> + .start = 0xfff70000,
> + .end = 0xfff70400 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = gic_spi(45),
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static struct platform_device ehci1_device = {
> + .name = "ehci-platform",
> + .id = 1,
> + .dev = {
> + .dma_mask = &ehci1_device.dev.coherent_dma_mask,
> + .coherent_dma_mask = 0xffffffff,
> + .platform_data = &ehcix_pdata,
> + },
> + .num_resources = ARRAY_SIZE(ehci1_resources),
> + .resource = ehci1_resources,
> +};
> +
> +static struct platform_device *marzen_late_devices[] __initdata = {
> + &ehci0_device,
> + &ehci1_device,
> +};
> +
> +void __init marzen_init_late(void)
> +{
> + /* get usb phy */
> + phy = usb_get_phy(USB_PHY_TYPE_USB2);
> +
> + shmobile_init_late();
> + platform_add_devices(marzen_late_devices,
> + ARRAY_SIZE(marzen_late_devices));
> +}
> +
>
Morimoto-san, I don't understand why this SoC specific platform device
ended up in the board file? Could you explain your reasons please?
I think this is generally a bad practice as this approach scales badly.
WVR, Sergei
next prev parent reply other threads:[~2013-03-13 21:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 7:31 [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Simon Horman
2012-11-09 7:31 ` [PATCH 1/7] ARM: shmobile: marzen: add USB phy support Simon Horman
2013-03-13 22:20 ` Sergei Shtylyov
2013-03-14 0:44 ` Kuninori Morimoto
2013-03-14 13:20 ` Sergei Shtylyov
2012-11-09 7:31 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2013-03-13 21:45 ` Sergei Shtylyov [this message]
2013-03-14 0:29 ` Kuninori Morimoto
2013-03-14 1:09 ` Kuninori Morimoto
2013-03-14 13:42 ` Sergei Shtylyov
2013-03-15 0:52 ` Kuninori Morimoto
2013-03-15 12:51 ` Sergei Shtylyov
2012-11-09 7:31 ` [PATCH 3/7] ARM: shmobile: marzen: add USB OHCI " Simon Horman
2012-11-09 7:31 ` [PATCH 4/7] ARM: shmobile: mackerel: enable DMAEngine on USB Host Simon Horman
2012-11-09 7:31 ` [PATCH 5/7] ARM: shmobile: use FSI driver's audio clock on armadillo800eva Simon Horman
2012-11-09 7:31 ` [PATCH 6/7] ARM: shmobile: use FSI driver's audio clock on mackerel Simon Horman
2012-11-09 7:31 ` [PATCH 7/7] ARM: shmobile: use FSI driver's audio clock on ap4evb Simon Horman
2012-11-12 21:11 ` [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Arnd Bergmann
2012-11-13 2:58 ` Simon Horman
2012-11-13 5:36 ` Mark Brown
2012-11-13 8:48 ` Arnd Bergmann
2012-11-13 10:01 ` Mark Brown
2012-11-13 10:27 ` Arnd Bergmann
2012-11-14 2:15 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-11-08 1:27 [GIT PULL v2] " Simon Horman
2012-11-08 1:27 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140F35F.3090702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox