From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support
Date: Thu, 14 Mar 2013 17:42:30 +0400 [thread overview]
Message-ID: <5141D3C6.4090806@cogentembedded.com> (raw)
In-Reply-To: <87li9q4ydj.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 14-03-2013 4:29, Kuninori Morimoto wrote:
>>> +/* USB */
>>> +static struct usb_phy *phy;
>>> +static int usb_power_on(struct platform_device *pdev)
>>> +{
>>> + if (!phy)
>>> + return -EIO;
>>> +
>>> + pm_runtime_enable(&pdev->dev);
>>> + pm_runtime_get_sync(&pdev->dev);
>>> +
>>> + usb_phy_init(phy);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static void usb_power_off(struct platform_device *pdev)
>>> +{
>>> + if (!phy)
>>> + return;
>>> +
>>> + usb_phy_shutdown(phy);
>>> +
>>> + pm_runtime_put_sync(&pdev->dev);
>>> + pm_runtime_disable(&pdev->dev);
>>> +}
>>> +
>>> +static struct usb_ehci_pdata ehcix_pdata = {
>>> + .power_on = usb_power_on,
>>> + .power_off = usb_power_off,
>>> + .power_suspend = usb_power_off,
>>> +};
> (snip)
>> Morimoto-san, I don't understand why this SoC specific platform device
>> ended up in the board file? Could you explain your reasons please?
>> I think this is generally a bad practice as this approach scales badly.
> Do you mean it should exist in setup-r8a7779.c ?
Yes.
> I forgot detail of it, but these usb is using callback function,
> and it is using *phy*.
But this PHY also belongs to SoC.
> This phy came from marzen_init_late() with usb_get_phy(USB_PHY_TYPE_USB2);
> This usb_get_phy() is not needed if board doesn't have USB.
Anyway, there should be ways to separate the board specific platform code
and the SoC specific one. That's what other subarches do.
> You can modify it if you want
Yes, I definitely would like to try.
WBR, Sergei
next prev parent reply other threads:[~2013-03-14 13:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 7:31 [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Simon Horman
2012-11-09 7:31 ` [PATCH 1/7] ARM: shmobile: marzen: add USB phy support Simon Horman
2013-03-13 22:20 ` Sergei Shtylyov
2013-03-14 0:44 ` Kuninori Morimoto
2013-03-14 13:20 ` Sergei Shtylyov
2012-11-09 7:31 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2013-03-13 21:45 ` Sergei Shtylyov
2013-03-14 0:29 ` Kuninori Morimoto
2013-03-14 1:09 ` Kuninori Morimoto
2013-03-14 13:42 ` Sergei Shtylyov [this message]
2013-03-15 0:52 ` Kuninori Morimoto
2013-03-15 12:51 ` Sergei Shtylyov
2012-11-09 7:31 ` [PATCH 3/7] ARM: shmobile: marzen: add USB OHCI " Simon Horman
2012-11-09 7:31 ` [PATCH 4/7] ARM: shmobile: mackerel: enable DMAEngine on USB Host Simon Horman
2012-11-09 7:31 ` [PATCH 5/7] ARM: shmobile: use FSI driver's audio clock on armadillo800eva Simon Horman
2012-11-09 7:31 ` [PATCH 6/7] ARM: shmobile: use FSI driver's audio clock on mackerel Simon Horman
2012-11-09 7:31 ` [PATCH 7/7] ARM: shmobile: use FSI driver's audio clock on ap4evb Simon Horman
2012-11-12 21:11 ` [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Arnd Bergmann
2012-11-13 2:58 ` Simon Horman
2012-11-13 5:36 ` Mark Brown
2012-11-13 8:48 ` Arnd Bergmann
2012-11-13 10:01 ` Mark Brown
2012-11-13 10:27 ` Arnd Bergmann
2012-11-14 2:15 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-11-08 1:27 [GIT PULL v2] " Simon Horman
2012-11-08 1:27 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5141D3C6.4090806@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox