public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/7] ARM: shmobile: marzen: add USB phy support
Date: Thu, 14 Mar 2013 01:20:33 +0300	[thread overview]
Message-ID: <5140FBB1.50401@mvista.com> (raw)
In-Reply-To: <1352446306-19945-2-git-send-email-horms@verge.net.au>

Hello.

On 11/09/2012 10:31 AM, Simon Horman wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
> Signed-off-by: Simon Horman <horms@verge•net.au>
> ---
>   arch/arm/configs/marzen_defconfig     |    3 ++-
>   arch/arm/mach-shmobile/board-marzen.c |   21 +++++++++++++++++++++
>   2 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-marzen.c b/arch/arm/mach-shmobile/board-marzen.c
> index 69f7f46..74c7f0b 100644
> --- a/arch/arm/mach-shmobile/board-marzen.c
> +++ b/arch/arm/mach-shmobile/board-marzen.c
> @@ -144,11 +144,32 @@ static struct platform_device hspi_device = {
>   	.num_resources	= ARRAY_SIZE(hspi_resources),
>   };
>   
> +/* USB PHY */
> +static struct resource usb_phy_resources[] = {
> +	[0] = {
> +		.start		= 0xffe70000,

    Why not 0xffe70800? 0xffe70000 is where the EHCI registers start.
I don't see why they should be overlapped like this.

> +		.end		= 0xffe70900 - 1,
> +		.flags		= IORESOURCE_MEM,
> +	},
> +	[1] = {
> +		.start		= 0xfff70000,
> +		.end		= 0xfff70900 - 1,

    Hm, this PHY register range doesn't seem to be documented?

> +		.flags		= IORESOURCE_MEM,
> +	},
> +};
> +
> +static struct platform_device usb_phy_device = {
> +	.name		= "rcar_usb_phy",
> +	.resource	= usb_phy_resources,
> +	.num_resources	= ARRAY_SIZE(usb_phy_resources),
> +};
> +
>   static struct platform_device *marzen_devices[] __initdata = {
>   	&eth_device,
>   	&sdhi0_device,
>   	&thermal_device,
>   	&hspi_device,
> +	&usb_phy_device,
>   };
>   
>   static void __init marzen_init(void)

    Finally, the same question as for EHCI: why this ended up in the 
board file instead of setup-r8a7779.c?

WBR, Sergei

next prev parent reply	other threads:[~2013-03-13 22:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  7:31 [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Simon Horman
2012-11-09  7:31 ` [PATCH 1/7] ARM: shmobile: marzen: add USB phy support Simon Horman
2013-03-13 22:20   ` Sergei Shtylyov [this message]
2013-03-14  0:44     ` Kuninori Morimoto
2013-03-14 13:20       ` Sergei Shtylyov
2012-11-09  7:31 ` [PATCH 2/7] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2013-03-13 21:45   ` Sergei Shtylyov
2013-03-14  0:29     ` Kuninori Morimoto
2013-03-14  1:09       ` Kuninori Morimoto
2013-03-14 13:42       ` Sergei Shtylyov
2013-03-15  0:52         ` Kuninori Morimoto
2013-03-15 12:51           ` Sergei Shtylyov
2012-11-09  7:31 ` [PATCH 3/7] ARM: shmobile: marzen: add USB OHCI " Simon Horman
2012-11-09  7:31 ` [PATCH 4/7] ARM: shmobile: mackerel: enable DMAEngine on USB Host Simon Horman
2012-11-09  7:31 ` [PATCH 5/7] ARM: shmobile: use FSI driver's audio clock on armadillo800eva Simon Horman
2012-11-09  7:31 ` [PATCH 6/7] ARM: shmobile: use FSI driver's audio clock on mackerel Simon Horman
2012-11-09  7:31 ` [PATCH 7/7] ARM: shmobile: use FSI driver's audio clock on ap4evb Simon Horman
2012-11-12 21:11 ` [GIT PULL v3] Renesas ARM-based SoC boards for v3.8 #2 Arnd Bergmann
2012-11-13  2:58   ` Simon Horman
2012-11-13  5:36   ` Mark Brown
2012-11-13  8:48     ` Arnd Bergmann
2012-11-13 10:01       ` Mark Brown
2012-11-13 10:27         ` Arnd Bergmann
2012-11-14  2:15           ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2012-11-08  1:27 [GIT PULL v2] " Simon Horman
2012-11-08  1:27 ` [PATCH 1/7] ARM: shmobile: marzen: add USB phy support Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5140FBB1.50401@mvista.com \
    --to=sshtylyov@mvista$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox