From: javier.martinez@collabora•co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow
Date: Sat, 02 Aug 2014 04:17:51 +0200 [thread overview]
Message-ID: <53DC4A4F.8060009@collabora.co.uk> (raw)
In-Reply-To: <1406940750-15880-6-git-send-email-afaerber@suse.de>
Hello Andreas,
Sorry for missing your v5.
On 08/02/2014 02:52 AM, Andreas F?rber wrote:
>
> chosen {
> + bootargs = "console=tty1";
> };
While I agree with you that having a chosen node with a default bootargs is
better than having an empty one, I second Doug that this bootargs is not very
useful.
If you want to add a bootargs in the DTS I think that it should be a complete
kernel command line that allows to boot a system. I would at least add a root
parameter and possibly another console for the serial port. So if
CMDLINE_FROM_BOOTLOADER is not set then the DT can be used to specify the
bootargs instead of using whatever was set in CONFIG_CMDLINE which probably
won't be relevant for every system on a multi-platform kernel.
But I think that is safe to rely on the bootloader to set the bootargs and after
all having a hardcoded bootargs in the DTS is not much better than having a
hardcoded CONFIG_CMDLINE since as Doug said it is hard to make assumptions about
what would be the most common options.
Personally I would just drop this change and as I said before remove the empty
chosen node on a follow up patch but I don't have a strong opinion either.
Best regards,
Javier
next prev parent reply other threads:[~2014-08-02 2:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 0:52 [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-02 0:52 ` [PATCH v6 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250 Andreas Färber
2014-08-02 4:48 ` Doug Anderson
2014-08-02 12:19 ` Tomasz Figa
2014-08-02 13:00 ` Andreas Färber
2014-08-20 13:06 ` Andreas Färber
2014-08-20 13:02 ` [PATCH v7] " Andreas Färber
2014-08-22 10:49 ` Kukjin Kim
2014-08-22 11:37 ` Andreas Färber
2014-08-22 16:14 ` Doug Anderson
2014-08-02 0:52 ` [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-08-02 4:54 ` Doug Anderson
2014-08-02 12:21 ` Tomasz Figa
2014-08-02 12:56 ` Tomasz Figa
2014-08-02 13:08 ` Andreas Färber
2014-08-02 13:09 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber
2014-08-02 2:17 ` Javier Martinez Canillas [this message]
2014-08-02 0:52 ` [PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber
2014-08-02 12:57 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber
2014-08-02 13:02 ` Tomasz Figa
2014-08-02 13:10 ` Andreas Färber
2014-08-02 0:52 ` [PATCH v6 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-08-02 13:18 ` Tomasz Figa
2014-08-04 15:22 ` Doug Anderson
2014-08-04 17:31 ` Javier Martinez Canillas
2014-08-20 12:50 ` Andreas Färber
2014-08-02 2:34 ` [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Javier Martinez Canillas
2014-08-02 4:57 ` Doug Anderson
2014-08-02 10:25 ` Andreas Färber
2014-08-02 13:13 ` Tomasz Figa
2014-08-02 16:05 ` Andreas Färber
2014-08-04 15:42 ` Doug Anderson
2014-08-04 17:43 ` Javier Martinez Canillas
2014-08-07 8:40 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DC4A4F.8060009@collabora.co.uk \
--to=javier.martinez@collabora$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox