From: javier.martinez@collabora•co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring
Date: Thu, 07 Aug 2014 10:40:36 +0200 [thread overview]
Message-ID: <53E33B84.2010108@collabora.co.uk> (raw)
In-Reply-To: <CAD=FV=WFNW_5KZvLMk0kK1JQsdWLeo2kCjpQsFuxKNSnOKzfgw@mail.gmail.com>
Hello,
On 08/04/2014 05:42 PM, Doug Anderson wrote:
>
>
>> For the touchpad it seems DT support has landed in the input tree as
>> "atmel,maxtouch". Backporting just that patch does not make it work
>> though. (Tried the rejected pinctrl approach to be on the safe side.)
>> https://code.google.com/p/chromium/issues/detail?id=371114
>> https://patchwork.kernel.org/patch/3976801/
>
> This is the same work as needed for pit and pi, I believe. Perhaps
> Javier or Dmitry has this on their todo list?
>
>
I posted a couple of patches that allowed me to have the atmel touchpad working
on Peach Pit. I found two issues while testing the driver:
a) The device keycode event capabilities are hardcoded in the downstream Chrome
OS driver while the mainline driver expect these to be defined in the DT. The
property is called "linux,gpio-keymap" since it seems that the actual
implementation is using a set of GPIOs. But this is handled by the firmware
since the kernel just read a status register from the atmel T9 object.
I found the property confusing at first since it didn't have anything to do with
Linux GPIO so posted a patch to add an example to the DT binding doc in order to
make it easier to understand [0].
b) The driver overwrites the edge/level flags parsed by OF core and expects that
the IRQ type will be passed using platform data. The downstream Chrome OS driver
defaults the type to IRQF_TRIGGER_FALLING if this is not provided while the
mainline does not have a default so it's just 0 (IRQ_TYPE_NONE).
This is fixed by reading back the IRQ type from the struct irq_data when parsing
the DT data [1].
The DTS changes to make the atmel touchpad work on Peach Pit were posted in [2].
Changes for Pi were included as well since it should be the same but it was not
tested since I don't have access to that machine, testing will be highly
appreciated.
>
> -Doug
>
Thanks a lot and best regards,
Javier
[0]: https://lkml.org/lkml/2014/8/6/584
[1]: https://lkml.org/lkml/2014/8/7/82
[2]: https://lkml.org/lkml/2014/8/6/589
prev parent reply other threads:[~2014-08-07 8:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 0:52 [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-02 0:52 ` [PATCH v6 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250 Andreas Färber
2014-08-02 4:48 ` Doug Anderson
2014-08-02 12:19 ` Tomasz Figa
2014-08-02 13:00 ` Andreas Färber
2014-08-20 13:06 ` Andreas Färber
2014-08-20 13:02 ` [PATCH v7] " Andreas Färber
2014-08-22 10:49 ` Kukjin Kim
2014-08-22 11:37 ` Andreas Färber
2014-08-22 16:14 ` Doug Anderson
2014-08-02 0:52 ` [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-08-02 4:54 ` Doug Anderson
2014-08-02 12:21 ` Tomasz Figa
2014-08-02 12:56 ` Tomasz Figa
2014-08-02 13:08 ` Andreas Färber
2014-08-02 13:09 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber
2014-08-02 2:17 ` Javier Martinez Canillas
2014-08-02 0:52 ` [PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber
2014-08-02 12:57 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber
2014-08-02 13:02 ` Tomasz Figa
2014-08-02 13:10 ` Andreas Färber
2014-08-02 0:52 ` [PATCH v6 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-08-02 13:18 ` Tomasz Figa
2014-08-04 15:22 ` Doug Anderson
2014-08-04 17:31 ` Javier Martinez Canillas
2014-08-20 12:50 ` Andreas Färber
2014-08-02 2:34 ` [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Javier Martinez Canillas
2014-08-02 4:57 ` Doug Anderson
2014-08-02 10:25 ` Andreas Färber
2014-08-02 13:13 ` Tomasz Figa
2014-08-02 16:05 ` Andreas Färber
2014-08-04 15:42 ` Doug Anderson
2014-08-04 17:43 ` Javier Martinez Canillas
2014-08-07 8:40 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E33B84.2010108@collabora.co.uk \
--to=javier.martinez@collabora$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox