From: tomasz.figa@gmail•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
Date: Sat, 02 Aug 2014 14:56:19 +0200 [thread overview]
Message-ID: <53DCDFF3.7030909@gmail.com> (raw)
In-Reply-To: <53DCD7D7.2070208@gmail.com>
On 02.08.2014 14:21, Tomasz Figa wrote:
> On 02.08.2014 02:52, Andreas F?rber wrote:
>> Use the new style of referencing inherited nodes and use symbolic names.
>> Reorder one pinctrl node in GPIO order.
>>
>> Goal is the alignment of all exynos5250 based device trees for comparison.
>>
>> Suggested-by: Doug Anderson <dianders@chromium•org>
>> Reviewed-by: Doug Anderson <dianders@chromium•org>
>> Signed-off-by: Andreas F?rber <afaerber@suse•de>
>> ---
>> v5 -> v6:
>> * Split off label additions (Doug Anderson)
>> * Fixed alphabetical order of sd3_* nodes (Doug Anderson)
>>
>> v4 -> v5:
>> * Introduced labels to consistently use new referencing style (Tomasz Figa)
>> * Use IRQ_TYPE_* constants
>> * Use some more GPIO_ACTIVE_*
>>
>> v3 -> v4: Unchanged
>>
>> v3: New (Doug Anderson)
>>
>> arch/arm/boot/dts/exynos5250-snow.dts | 291 +++++++++++++++++-----------------
>> 1 file changed, 145 insertions(+), 146 deletions(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung•com>
Just for convenience of other reviewers, here are actual changes done do
the device tree after compiling into dtb and then back into dts:
> --- exynos5250-snow.dtb.dts 2014-08-02 14:54:15.145905921 +0200
> +++ ../dtbs.post/exynos5250-snow.dtb.dts 2014-08-02 14:54:15.146905921 +0200
> @@ -8,6 +8,7 @@
> model = "Google Snow";
>
> chosen {
> + bootargs = "console=tty1";
> };
>
> aliases {
> @@ -829,15 +830,6 @@
> phandle = <0x44>;
> };
>
> - hdmi-hpd-irq {
> - samsung,pins = "gpx3-7";
> - samsung,pin-function = <0x0>;
> - samsung,pin-pud = <0x1>;
> - samsung,pin-drv = <0x0>;
> - linux,phandle = <0x33>;
> - phandle = <0x33>;
> - };
> -
> max77686-irq {
> samsung,pins = "gpx3-2";
> samsung,pin-function = <0x0>;
> @@ -846,6 +838,15 @@
> linux,phandle = <0xe>;
> phandle = <0xe>;
> };
> +
> + hdmi-hpd-irq {
> + samsung,pins = "gpx3-7";
> + samsung,pin-function = <0x0>;
> + samsung,pin-pud = <0x1>;
> + samsung,pin-drv = <0x0>;
> + linux,phandle = <0x33>;
> + phandle = <0x33>;
> + };
> };
>
> pinctrl at 13400000 {
> @@ -1703,12 +1704,12 @@
> samsung,dw-mshc-ciu-div = <0x3>;
> samsung,dw-mshc-sdr-timing = <0x2 0x3>;
> samsung,dw-mshc-ddr-timing = <0x1 0x2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <0x27 0x28 0x29>;
>
> slot at 0 {
> reg = <0x0>;
> bus-width = <0x4>;
> - pinctrl-names = "default";
> - pinctrl-0 = <0x27 0x28 0x29>;
> };
> };
>
Best regards,
Tomasz
next prev parent reply other threads:[~2014-08-02 12:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 0:52 [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-02 0:52 ` [PATCH v6 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250 Andreas Färber
2014-08-02 4:48 ` Doug Anderson
2014-08-02 12:19 ` Tomasz Figa
2014-08-02 13:00 ` Andreas Färber
2014-08-20 13:06 ` Andreas Färber
2014-08-20 13:02 ` [PATCH v7] " Andreas Färber
2014-08-22 10:49 ` Kukjin Kim
2014-08-22 11:37 ` Andreas Färber
2014-08-22 16:14 ` Doug Anderson
2014-08-02 0:52 ` [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-08-02 4:54 ` Doug Anderson
2014-08-02 12:21 ` Tomasz Figa
2014-08-02 12:56 ` Tomasz Figa [this message]
2014-08-02 13:08 ` Andreas Färber
2014-08-02 13:09 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber
2014-08-02 2:17 ` Javier Martinez Canillas
2014-08-02 0:52 ` [PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber
2014-08-02 12:57 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber
2014-08-02 13:02 ` Tomasz Figa
2014-08-02 13:10 ` Andreas Färber
2014-08-02 0:52 ` [PATCH v6 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-08-02 13:18 ` Tomasz Figa
2014-08-04 15:22 ` Doug Anderson
2014-08-04 17:31 ` Javier Martinez Canillas
2014-08-20 12:50 ` Andreas Färber
2014-08-02 2:34 ` [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Javier Martinez Canillas
2014-08-02 4:57 ` Doug Anderson
2014-08-02 10:25 ` Andreas Färber
2014-08-02 13:13 ` Tomasz Figa
2014-08-02 16:05 ` Andreas Färber
2014-08-04 15:42 ` Doug Anderson
2014-08-04 17:43 ` Javier Martinez Canillas
2014-08-07 8:40 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DCDFF3.7030909@gmail.com \
--to=tomasz.figa@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox