* [PATCH] clk: samsung: exynos5410: fix refcount leak
@ 2026-05-26 6:13 Alexander A. Klimov
2026-05-26 17:29 ` Brian Masney
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Alexander A. Klimov @ 2026-05-26 6:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Brian Masney,
open list:SAMSUNG SOC CLOCK DRIVERS,
open list:COMMON CLK FRAMEWORK,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
Cc: Alexander A. Klimov
Every value returned from of_clk_get() is supposed to be cleaned up
via clk_put() once not needed anymore.
Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
---
drivers/clk/samsung/clk-exynos5410.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
index baa9988c7bb7..0cd9b0392cf5 100644
--- a/drivers/clk/samsung/clk-exynos5410.c
+++ b/drivers/clk/samsung/clk-exynos5410.c
@@ -269,8 +269,12 @@ static void __init exynos5410_clk_init(struct device_node *np)
{
struct clk *xxti = of_clk_get(np, 0);
- if (!IS_ERR(xxti) && clk_get_rate(xxti) == 24 * MHZ)
- exynos5410_plls[epll].rate_table = exynos5410_pll2550x_24mhz_tbl;
+ if (!IS_ERR(xxti)) {
+ if (clk_get_rate(xxti) == 24 * MHZ)
+ exynos5410_plls[epll].rate_table =
+ exynos5410_pll2550x_24mhz_tbl;
+ clk_put(xxti);
+ }
samsung_cmu_register_one(np, &cmu);
--
2.54.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5410: fix refcount leak
2026-05-26 6:13 [PATCH] clk: samsung: exynos5410: fix refcount leak Alexander A. Klimov
@ 2026-05-26 17:29 ` Brian Masney
2026-05-28 1:15 ` Alexey Klimov
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Brian Masney @ 2026-05-26 17:29 UTC (permalink / raw)
To: Alexander A. Klimov
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd,
open list:SAMSUNG SOC CLOCK DRIVERS,
open list:COMMON CLK FRAMEWORK,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
On Tue, May 26, 2026 at 08:13:12AM +0200, Alexander A. Klimov wrote:
> Every value returned from of_clk_get() is supposed to be cleaned up
> via clk_put() once not needed anymore.
>
> Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
Reviewed-by: Brian Masney <bmasney@redhat•com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5410: fix refcount leak
2026-05-26 6:13 [PATCH] clk: samsung: exynos5410: fix refcount leak Alexander A. Klimov
2026-05-26 17:29 ` Brian Masney
@ 2026-05-28 1:15 ` Alexey Klimov
2026-05-28 8:02 ` Peter Griffin
2026-05-30 16:26 ` Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Alexey Klimov @ 2026-05-28 1:15 UTC (permalink / raw)
To: Alexander A. Klimov, Krzysztof Kozlowski, Sylwester Nawrocki,
Chanwoo Choi, Alim Akhtar, Michael Turquette, Stephen Boyd,
Brian Masney, open list:SAMSUNG SOC CLOCK DRIVERS,
open list:COMMON CLK FRAMEWORK,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
On Tue May 26, 2026 at 7:13 AM BST, Alexander A. Klimov wrote:
> Every value returned from of_clk_get() is supposed to be cleaned up
> via clk_put() once not needed anymore.
>
> Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
Reviewed-by: Alexey Klimov <alexey.klimov@linaro•org>
> ---
> drivers/clk/samsung/clk-exynos5410.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
> index baa9988c7bb7..0cd9b0392cf5 100644
> --- a/drivers/clk/samsung/clk-exynos5410.c
> +++ b/drivers/clk/samsung/clk-exynos5410.c
> @@ -269,8 +269,12 @@ static void __init exynos5410_clk_init(struct device_node *np)
> {
> struct clk *xxti = of_clk_get(np, 0);
>
> - if (!IS_ERR(xxti) && clk_get_rate(xxti) == 24 * MHZ)
> - exynos5410_plls[epll].rate_table = exynos5410_pll2550x_24mhz_tbl;
> + if (!IS_ERR(xxti)) {
> + if (clk_get_rate(xxti) == 24 * MHZ)
> + exynos5410_plls[epll].rate_table =
> + exynos5410_pll2550x_24mhz_tbl;
> + clk_put(xxti);
> + }
>
> samsung_cmu_register_one(np, &cmu);
Best regards,
Alexey Klimov
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5410: fix refcount leak
2026-05-26 6:13 [PATCH] clk: samsung: exynos5410: fix refcount leak Alexander A. Klimov
2026-05-26 17:29 ` Brian Masney
2026-05-28 1:15 ` Alexey Klimov
@ 2026-05-28 8:02 ` Peter Griffin
2026-05-30 16:26 ` Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Peter Griffin @ 2026-05-28 8:02 UTC (permalink / raw)
To: Alexander A. Klimov
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Brian Masney,
open list:SAMSUNG SOC CLOCK DRIVERS,
open list:COMMON CLK FRAMEWORK,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
On Tue, 26 May 2026 at 07:13, Alexander A. Klimov
<grandmaster@al2klimov•de> wrote:
>
> Every value returned from of_clk_get() is supposed to be cleaned up
> via clk_put() once not needed anymore.
>
> Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
> ---
Reviewed-by: Peter Griffin <peter.griffin@linaro•org>
> drivers/clk/samsung/clk-exynos5410.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
> index baa9988c7bb7..0cd9b0392cf5 100644
> --- a/drivers/clk/samsung/clk-exynos5410.c
> +++ b/drivers/clk/samsung/clk-exynos5410.c
> @@ -269,8 +269,12 @@ static void __init exynos5410_clk_init(struct device_node *np)
> {
> struct clk *xxti = of_clk_get(np, 0);
>
> - if (!IS_ERR(xxti) && clk_get_rate(xxti) == 24 * MHZ)
> - exynos5410_plls[epll].rate_table = exynos5410_pll2550x_24mhz_tbl;
> + if (!IS_ERR(xxti)) {
> + if (clk_get_rate(xxti) == 24 * MHZ)
> + exynos5410_plls[epll].rate_table =
> + exynos5410_pll2550x_24mhz_tbl;
> + clk_put(xxti);
> + }
>
> samsung_cmu_register_one(np, &cmu);
>
> --
> 2.54.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5410: fix refcount leak
2026-05-26 6:13 [PATCH] clk: samsung: exynos5410: fix refcount leak Alexander A. Klimov
` (2 preceding siblings ...)
2026-05-28 8:02 ` Peter Griffin
@ 2026-05-30 16:26 ` Krzysztof Kozlowski
2026-05-31 9:27 ` Alexander A. Klimov
3 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-30 16:26 UTC (permalink / raw)
To: Alexander A. Klimov, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Brian Masney,
open list:SAMSUNG SOC CLOCK DRIVERS,
open list:COMMON CLK FRAMEWORK,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
On 26/05/2026 08:13, Alexander A. Klimov wrote:
> Every value returned from of_clk_get() is supposed to be cleaned up
> via clk_put() once not needed anymore.
>
> Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
Does not apply - you messed somehow sending these.
Grabbing thread from
lore.kernel.org/all/20260526061321.6123-1-grandmaster@al2klimov•de/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 13 messages in the thread
WARNING: duplicate messages found at index 1
Subject 1: dmaengine: ioatdma: use !kstrtoint(), not sscanf()!=-1
Subject 2: tlclk: if sscanf() fails, fall back to 0, not random value
2 is not a reply... assume additional patch
WARNING: duplicate messages found at index 1
Subject 1: clk: samsung: exynos5410: fix refcount leak
Subject 2: dmaengine: ioatdma: use !kstrtoint(), not sscanf()!=-1
2 is not a reply... assume additional patch
Assuming new revision: v2 ([PATCH] clk: tegra: tegra124-emc: fix
krealloc() memory leak)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5410: fix refcount leak
2026-05-30 16:26 ` Krzysztof Kozlowski
@ 2026-05-31 9:27 ` Alexander A. Klimov
0 siblings, 0 replies; 6+ messages in thread
From: Alexander A. Klimov @ 2026-05-31 9:27 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, Brian Masney,
open list:SAMSUNG SOC CLOCK DRIVERS,
open list:COMMON CLK FRAMEWORK,
moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES,
open list
On 5/30/26 18:26, Krzysztof Kozlowski wrote:
> On 26/05/2026 08:13, Alexander A. Klimov wrote:
>> Every value returned from of_clk_get() is supposed to be cleaned up
>> via clk_put() once not needed anymore.
>>
>> Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410")
>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov•de>
>
>
> Does not apply - you messed somehow sending these.
Strange... copy&paste from
https://lore.kernel.org/all/20260526061321.6123-1-grandmaster@al2klimov.de/
(From: ... 2.54.0) applies to Linus' master.
Wait... ! Don't say because I fired all my compiled patches
at once via git-send-email(1), they assembled to one thread?
🙈
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-05-31 9:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 6:13 [PATCH] clk: samsung: exynos5410: fix refcount leak Alexander A. Klimov
2026-05-26 17:29 ` Brian Masney
2026-05-28 1:15 ` Alexey Klimov
2026-05-28 8:02 ` Peter Griffin
2026-05-30 16:26 ` Krzysztof Kozlowski
2026-05-31 9:27 ` Alexander A. Klimov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox