From: zhaoshenglong@huawei•com (Shannon Zhao)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 09/13] ARM: Xen: Initialize Xen specific UEFI runtime services
Date: Tue, 17 Nov 2015 20:17:35 +0800 [thread overview]
Message-ID: <564B1ADF.70105@huawei.com> (raw)
In-Reply-To: <CAKv+Gu9-g6fttchWkg_ptCGwUD-hbyM2F0x1Wrv=dAa6bsMVBQ@mail.gmail.com>
On 2015/11/17 19:28, Ard Biesheuvel wrote:
>> @@ -308,13 +311,18 @@ static int __init arm64_enable_runtime_services(void)
>> > }
>> > set_bit(EFI_SYSTEM_TABLES, &efi.flags);
>> >
>> > - if (!efi_virtmap_init()) {
>> > - pr_err("No UEFI virtual mapping was installed -- runtime services will not be available\n");
>> > - return -1;
>> > - }
>> > + if (!xen_initial_domain()) {
>> > + if (!efi_virtmap_init()) {
>> > + pr_err("No UEFI virtual mapping was installed -- runtime services will not be available\n");
>> > + return -1;
>> > + }
>> >
> I'd prefer it if we could separate the code logically, rather than
> putting xen_initial_domain() tests in all the code paths.
>
> For instance, we could re-use the EFI_PARAVIRT flag, and set if from
> the Xen init code. Then, we could simply test it here, and bail early.
> That way, you can have a Xen specific alternative (which does not use
> the virtmap etc anyway) in a xen source file.
>
Ok, will do. Thanks.
--
Shannon
next prev parent reply other threads:[~2015-11-17 12:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 9:56 [PATCH 00/13] Add ACPI support for Xen Dom0 on ARM64 shannon.zhao at linaro.org
2015-11-17 9:56 ` [PATCH 01/13] Xen : Hide UART used by Xen shannon.zhao at linaro.org
2015-11-20 16:07 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 02/13] xen/grant-table: Move xlated_setup_gnttab_pages to common place shannon.zhao at linaro.org
2015-11-17 16:02 ` [Xen-devel] " David Vrabel
2015-11-18 4:32 ` Shannon Zhao
2015-11-18 10:38 ` David Vrabel
2015-11-18 12:25 ` Julien Grall
2015-11-18 13:34 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 03/13] arm/xen: Use xlated_setup_gnttab_pages to setup grant table shannon.zhao at linaro.org
2015-11-20 16:19 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 04/13] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio shannon.zhao at linaro.org
2015-11-17 11:16 ` Ard Biesheuvel
2015-11-17 9:57 ` [PATCH 05/13] Xen: ARM: Add support for mapping platform device mmio shannon.zhao at linaro.org
2015-11-17 16:32 ` [Xen-devel] " David Vrabel
2015-11-18 6:11 ` Shannon Zhao
[not found] ` <20151117143822.GH3003@char.us.oracle.com>
2015-11-18 5:48 ` Shannon Zhao
2015-11-20 16:30 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 06/13] Xen: ARM: Add support for mapping amba " shannon.zhao at linaro.org
2015-11-17 16:36 ` [Xen-devel] " David Vrabel
[not found] ` <20151117144040.GI3003@char.us.oracle.com>
2015-11-18 6:03 ` Shannon Zhao
2015-11-18 12:27 ` Julien Grall
2015-11-18 13:15 ` Shannon Zhao
2015-11-20 16:39 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms shannon.zhao at linaro.org
2015-11-17 16:46 ` [Xen-devel] " David Vrabel
2015-11-18 6:33 ` Shannon Zhao
2015-11-20 16:42 ` Stefano Stabellini
2015-11-17 20:44 ` Rob Herring
2015-11-18 6:24 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 08/13] Xen: EFI: Parse DT parameters for Xen specific UEFI shannon.zhao at linaro.org
2015-11-17 11:25 ` Ard Biesheuvel
2015-11-17 11:37 ` Mark Rutland
2015-11-17 12:17 ` Ard Biesheuvel
2015-11-18 6:26 ` Shannon Zhao
2015-11-20 17:04 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 09/13] ARM: Xen: Initialize Xen specific UEFI runtime services shannon.zhao at linaro.org
2015-11-17 11:28 ` Ard Biesheuvel
2015-11-17 12:17 ` Shannon Zhao [this message]
2015-11-20 16:57 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 10/13] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI shannon.zhao at linaro.org
2015-11-20 17:20 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 11/13] xen/hvm/params: Add a new dilivery type for event-channel in HVM_PARAM_CALLBACK_IRQ shannon.zhao at linaro.org
2015-11-20 17:07 ` Stefano Stabellini
2015-11-20 17:22 ` [Xen-devel] " Andrew Cooper
2015-11-20 17:32 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 12/13] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI shannon.zhao at linaro.org
2015-11-20 17:11 ` Stefano Stabellini
2015-11-24 3:49 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 13/13] ARM: XEN: Move xen_early_init() before efi_init() shannon.zhao at linaro.org
2015-11-20 17:30 ` Stefano Stabellini
2015-11-24 3:50 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B1ADF.70105@huawei.com \
--to=zhaoshenglong@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox