From: zhaoshenglong@huawei•com (Shannon Zhao)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 12/13] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI
Date: Tue, 24 Nov 2015 11:49:37 +0800 [thread overview]
Message-ID: <5653DE51.9030104@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1511201708120.1107@kaball.uk.xensource.com>
On 2015/11/21 1:11, Stefano Stabellini wrote:
> On Tue, 17 Nov 2015, shannon.zhao at linaro.org wrote:
>> From: Shannon Zhao <shannon.zhao@linaro•org>
>>
>> When booting with ACPI, it could get the event-channel irq through
>> HVM_PARAM_CALLBACK_IRQ.
>>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro•org>
>> ---
>> arch/arm/xen/enlighten.c | 23 +++++++++++++++++++----
>> 1 file changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
>> index 1373d6d..b8e9db8 100644
>> --- a/arch/arm/xen/enlighten.c
>> +++ b/arch/arm/xen/enlighten.c
>> @@ -25,6 +25,7 @@
>> #include <linux/cpufreq.h>
>> #include <linux/cpu.h>
>> #include <linux/console.h>
>> +#include <linux/acpi.h>
>>
>> #include <linux/mm.h>
>>
>> @@ -190,10 +191,24 @@ static int __init xen_guest_init(void)
>> if (!xen_domain())
>> return 0;
>>
>> - xen_events_irq = irq_of_parse_and_map(xen_node, 0);
>> - if (!xen_events_irq) {
>> - pr_err("Xen event channel interrupt not found\n");
>> - return -ENODEV;
>> + if (!acpi_disabled) {
>> + struct xen_hvm_param a;
>> +
>> + a.domid = DOMID_SELF;
>> + a.index = HVM_PARAM_CALLBACK_IRQ;
>> + if (HYPERVISOR_hvm_op(HVMOP_get_param, &a)) {
>
> If HYPERVISOR_hvm_op returns an error (ret != 0), I wouldn't bother
> checking for the returned value and simply return error.
>
> On the other hand, if HYPERVISOR_hvm_op is successful (ret == 0), then
> it might make sense to check for (a.value >> 56) == 3.
>
Ok.
>
>> + if ((a.value >> 56) != 3) {
>> + pr_err("Can't get Xen event-channel irq\n");
>> + return -ENODEV;
>> + }
>> + }
>> + xen_events_irq = a.value & 0xff;
>> + } else {
>> + xen_events_irq = irq_of_parse_and_map(xen_node, 0);
>> + if (!xen_events_irq) {
>> + pr_err("Xen event channel interrupt not found\n");
>> + return -ENODEV;
>
> Please make the error message common and move it out of the if/else.
>
Sure. Thanks.
>
>> + }
>> }
>>
>> shared_info_page = (struct shared_info *)get_zeroed_page(GFP_KERNEL);
>> --
>> 2.1.0
>>
>
> .
>
--
Shannon
next prev parent reply other threads:[~2015-11-24 3:49 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 9:56 [PATCH 00/13] Add ACPI support for Xen Dom0 on ARM64 shannon.zhao at linaro.org
2015-11-17 9:56 ` [PATCH 01/13] Xen : Hide UART used by Xen shannon.zhao at linaro.org
2015-11-20 16:07 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 02/13] xen/grant-table: Move xlated_setup_gnttab_pages to common place shannon.zhao at linaro.org
2015-11-17 16:02 ` [Xen-devel] " David Vrabel
2015-11-18 4:32 ` Shannon Zhao
2015-11-18 10:38 ` David Vrabel
2015-11-18 12:25 ` Julien Grall
2015-11-18 13:34 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 03/13] arm/xen: Use xlated_setup_gnttab_pages to setup grant table shannon.zhao at linaro.org
2015-11-20 16:19 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 04/13] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio shannon.zhao at linaro.org
2015-11-17 11:16 ` Ard Biesheuvel
2015-11-17 9:57 ` [PATCH 05/13] Xen: ARM: Add support for mapping platform device mmio shannon.zhao at linaro.org
2015-11-17 16:32 ` [Xen-devel] " David Vrabel
2015-11-18 6:11 ` Shannon Zhao
[not found] ` <20151117143822.GH3003@char.us.oracle.com>
2015-11-18 5:48 ` Shannon Zhao
2015-11-20 16:30 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 06/13] Xen: ARM: Add support for mapping amba " shannon.zhao at linaro.org
2015-11-17 16:36 ` [Xen-devel] " David Vrabel
[not found] ` <20151117144040.GI3003@char.us.oracle.com>
2015-11-18 6:03 ` Shannon Zhao
2015-11-18 12:27 ` Julien Grall
2015-11-18 13:15 ` Shannon Zhao
2015-11-20 16:39 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms shannon.zhao at linaro.org
2015-11-17 16:46 ` [Xen-devel] " David Vrabel
2015-11-18 6:33 ` Shannon Zhao
2015-11-20 16:42 ` Stefano Stabellini
2015-11-17 20:44 ` Rob Herring
2015-11-18 6:24 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 08/13] Xen: EFI: Parse DT parameters for Xen specific UEFI shannon.zhao at linaro.org
2015-11-17 11:25 ` Ard Biesheuvel
2015-11-17 11:37 ` Mark Rutland
2015-11-17 12:17 ` Ard Biesheuvel
2015-11-18 6:26 ` Shannon Zhao
2015-11-20 17:04 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 09/13] ARM: Xen: Initialize Xen specific UEFI runtime services shannon.zhao at linaro.org
2015-11-17 11:28 ` Ard Biesheuvel
2015-11-17 12:17 ` Shannon Zhao
2015-11-20 16:57 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 10/13] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI shannon.zhao at linaro.org
2015-11-20 17:20 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 11/13] xen/hvm/params: Add a new dilivery type for event-channel in HVM_PARAM_CALLBACK_IRQ shannon.zhao at linaro.org
2015-11-20 17:07 ` Stefano Stabellini
2015-11-20 17:22 ` [Xen-devel] " Andrew Cooper
2015-11-20 17:32 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 12/13] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI shannon.zhao at linaro.org
2015-11-20 17:11 ` Stefano Stabellini
2015-11-24 3:49 ` Shannon Zhao [this message]
2015-11-17 9:57 ` [PATCH 13/13] ARM: XEN: Move xen_early_init() before efi_init() shannon.zhao at linaro.org
2015-11-20 17:30 ` Stefano Stabellini
2015-11-24 3:50 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5653DE51.9030104@huawei.com \
--to=zhaoshenglong@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox