From: david.vrabel@citrix•com (David Vrabel)
To: linux-arm-kernel@lists•infradead.org
Subject: [Xen-devel] [PATCH 02/13] xen/grant-table: Move xlated_setup_gnttab_pages to common place
Date: Wed, 18 Nov 2015 10:38:24 +0000 [thread overview]
Message-ID: <564C5520.5030103@citrix.com> (raw)
In-Reply-To: <564BFF6C.3070208@huawei.com>
On 18/11/15 04:32, Shannon Zhao wrote:
> On 2015/11/18 0:02, David Vrabel wrote:
>> On 17/11/15 09:57, shannon.zhao at linaro.org wrote:
>>> From: Shannon Zhao <shannon.zhao@linaro•org>
>>>
>>> Move xlated_setup_gnttab_pages to common place, so it can be reused by
>>> ARM to setup grant table when booting with ACPI.
>> [...]
>>> --- a/drivers/xen/grant-table.c
>>> +++ b/drivers/xen/grant-table.c
>>> @@ -664,6 +664,55 @@ int gnttab_setup_auto_xlat_frames(phys_addr_t addr)
>>> }
>>> EXPORT_SYMBOL_GPL(gnttab_setup_auto_xlat_frames);
>>>
>>> +int __init xlated_setup_gnttab_pages(void)
>>> +{
>>> + struct page **pages;
>>> + xen_pfn_t *pfns;
>>> + void *vaddr;
>>> + int rc;
>>> + unsigned int i;
>>> + unsigned long nr_grant_frames = gnttab_max_grant_frames();
>>> +
>>> + BUG_ON(nr_grant_frames == 0);
>>> + pages = kcalloc(nr_grant_frames, sizeof(pages[0]), GFP_KERNEL);
>>> + if (!pages)
>>> + return -ENOMEM;
>>> +
>>> + pfns = kcalloc(nr_grant_frames, sizeof(pfns[0]), GFP_KERNEL);
>>> + if (!pfns) {
>>> + kfree(pages);
>>> + return -ENOMEM;
>>> + }
>>> + rc = alloc_xenballooned_pages(nr_grant_frames, pages, 0 /* lowmem */);
>>> + if (rc) {
>>> + pr_warn("%s Couldn't balloon alloc %ld pfns rc:%d\n", __func__,
>>> + nr_grant_frames, rc);
>>> + kfree(pages);
>>> + kfree(pfns);
>>> + return rc;
>>> + }
>>> + for (i = 0; i < nr_grant_frames; i++)
>>> + pfns[i] = page_to_pfn(pages[i]);
>>> +
>>> + vaddr = vmap(pages, nr_grant_frames, 0, PAGE_KERNEL);
>>> + if (!vaddr) {
>>> + pr_warn("%s Couldn't map %ld pfns rc:%d\n", __func__,
>>> + nr_grant_frames, rc);
>>> + free_xenballooned_pages(nr_grant_frames, pages);
>>> + kfree(pages);
>>> + kfree(pfns);
>>> + return -ENOMEM;
>>> + }
>>> + kfree(pages);
>>
>> Can you move most of this function into drivers/xen/xlate_mmu.c in a
>> function like:
>>
>> /**
>> * xen_xlate_map_ballooned_pages - map a new set of ballooned pages
>> * count: number of GFNs.
>> * pages: returns the array of (now) ballooned pages.
>> * gfns: returns the array of corresponding GFNs.
>> * virt: returns the virtual address of the mapped region.
>> *
>> * This allocate a set of ballooned pages and maps them into the
>> * kernel's address space.
>> */
>> void *xen_xlate_map_ballooned_pages(
>> unsigned int count,
>> struct page **pages,
>> xen_pfn_t **gfns);
>>
> Sure, but the parameter "pages" is not necessary I think, since the
> pages has been freed in the function and it doesn't need in
> xen_auto_xlat_grant_frames either. Right?
Yes.
David
next prev parent reply other threads:[~2015-11-18 10:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 9:56 [PATCH 00/13] Add ACPI support for Xen Dom0 on ARM64 shannon.zhao at linaro.org
2015-11-17 9:56 ` [PATCH 01/13] Xen : Hide UART used by Xen shannon.zhao at linaro.org
2015-11-20 16:07 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 02/13] xen/grant-table: Move xlated_setup_gnttab_pages to common place shannon.zhao at linaro.org
2015-11-17 16:02 ` [Xen-devel] " David Vrabel
2015-11-18 4:32 ` Shannon Zhao
2015-11-18 10:38 ` David Vrabel [this message]
2015-11-18 12:25 ` Julien Grall
2015-11-18 13:34 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 03/13] arm/xen: Use xlated_setup_gnttab_pages to setup grant table shannon.zhao at linaro.org
2015-11-20 16:19 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 04/13] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio shannon.zhao at linaro.org
2015-11-17 11:16 ` Ard Biesheuvel
2015-11-17 9:57 ` [PATCH 05/13] Xen: ARM: Add support for mapping platform device mmio shannon.zhao at linaro.org
2015-11-17 16:32 ` [Xen-devel] " David Vrabel
2015-11-18 6:11 ` Shannon Zhao
[not found] ` <20151117143822.GH3003@char.us.oracle.com>
2015-11-18 5:48 ` Shannon Zhao
2015-11-20 16:30 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 06/13] Xen: ARM: Add support for mapping amba " shannon.zhao at linaro.org
2015-11-17 16:36 ` [Xen-devel] " David Vrabel
[not found] ` <20151117144040.GI3003@char.us.oracle.com>
2015-11-18 6:03 ` Shannon Zhao
2015-11-18 12:27 ` Julien Grall
2015-11-18 13:15 ` Shannon Zhao
2015-11-20 16:39 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms shannon.zhao at linaro.org
2015-11-17 16:46 ` [Xen-devel] " David Vrabel
2015-11-18 6:33 ` Shannon Zhao
2015-11-20 16:42 ` Stefano Stabellini
2015-11-17 20:44 ` Rob Herring
2015-11-18 6:24 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 08/13] Xen: EFI: Parse DT parameters for Xen specific UEFI shannon.zhao at linaro.org
2015-11-17 11:25 ` Ard Biesheuvel
2015-11-17 11:37 ` Mark Rutland
2015-11-17 12:17 ` Ard Biesheuvel
2015-11-18 6:26 ` Shannon Zhao
2015-11-20 17:04 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 09/13] ARM: Xen: Initialize Xen specific UEFI runtime services shannon.zhao at linaro.org
2015-11-17 11:28 ` Ard Biesheuvel
2015-11-17 12:17 ` Shannon Zhao
2015-11-20 16:57 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 10/13] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI shannon.zhao at linaro.org
2015-11-20 17:20 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 11/13] xen/hvm/params: Add a new dilivery type for event-channel in HVM_PARAM_CALLBACK_IRQ shannon.zhao at linaro.org
2015-11-20 17:07 ` Stefano Stabellini
2015-11-20 17:22 ` [Xen-devel] " Andrew Cooper
2015-11-20 17:32 ` Stefano Stabellini
2015-11-17 9:57 ` [PATCH 12/13] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI shannon.zhao at linaro.org
2015-11-20 17:11 ` Stefano Stabellini
2015-11-24 3:49 ` Shannon Zhao
2015-11-17 9:57 ` [PATCH 13/13] ARM: XEN: Move xen_early_init() before efi_init() shannon.zhao at linaro.org
2015-11-20 17:30 ` Stefano Stabellini
2015-11-24 3:50 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C5520.5030103@citrix.com \
--to=david.vrabel@citrix$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox