From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready
Date: Mon, 20 Jun 2016 18:41:26 +0530 [thread overview]
Message-ID: <5767EB7E.3040606@ti.com> (raw)
In-Reply-To: <1463092986-61777-1-git-send-email-briannorris@chromium.org>
On Friday 13 May 2016 04:13 AM, Brian Norris wrote:
> From: Shawn Lin <shawn.lin@rock-chips•com>
>
> According to the databook, 10.2us is the max time for dll to be ready to
> work. However in testing, some chips need 20us for dll to be ready. This
> patch adds some extra margin for dllrdy to be ready, fixing our
> -ETIMEDOUT issues.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips•com>
> Signed-off-by: Brian Norris <briannorris@chromium•org>
Acked-by: Kishon Vijay Abraham I <kishon@ti•com>
> ---
> drivers/phy/phy-rockchip-emmc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c
> index 6ebcf3e41c46..48cbe691a889 100644
> --- a/drivers/phy/phy-rockchip-emmc.c
> +++ b/drivers/phy/phy-rockchip-emmc.c
> @@ -119,10 +119,11 @@ static int rockchip_emmc_phy_power(struct rockchip_emmc_phy *rk_phy,
> PHYCTRL_ENDLL_MASK,
> PHYCTRL_ENDLL_SHIFT));
> /*
> - * After enable analog DLL circuits, we need extra 10.2us
> - * for dll to be ready for work.
> + * After enable analog DLL circuits, we need an extra 10.2us
> + * for dll to be ready for work. But according to testing, we
> + * find some chips need more than 25us.
> */
> - udelay(11);
> + udelay(30);
> regmap_read(rk_phy->reg_base,
> rk_phy->reg_offset + GRF_EMMCPHY_STATUS,
> &dllrdy);
>
next prev parent reply other threads:[~2016-06-20 13:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 22:43 [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Brian Norris
2016-05-12 22:43 ` [PATCH 2/4] phy: rockchip-emmc: configure frequency range and drive impedance Brian Norris
2016-05-13 1:02 ` Shawn Lin
2016-05-13 18:46 ` Doug Anderson
2016-05-13 21:04 ` Brian Norris
2016-05-24 4:51 ` Doug Anderson
2016-05-13 21:09 ` [PATCH v2 " Brian Norris
2016-05-13 22:04 ` Doug Anderson
2016-06-16 23:36 ` Heiko Stuebner
2016-06-20 13:11 ` [PATCH " Kishon Vijay Abraham I
2016-05-12 22:43 ` [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay Brian Norris
2016-05-13 22:25 ` Doug Anderson
2016-05-16 4:15 ` Shawn Lin
2016-05-16 15:12 ` Doug Anderson
2016-06-16 23:36 ` Heiko Stuebner
2016-06-20 13:11 ` Kishon Vijay Abraham I
2016-05-12 22:43 ` [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions Brian Norris
2016-05-13 22:26 ` Doug Anderson
2016-06-16 23:37 ` Heiko Stuebner
2016-06-20 13:12 ` Kishon Vijay Abraham I
2016-05-13 22:01 ` [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Doug Anderson
2016-06-16 23:35 ` Heiko Stuebner
2016-06-20 13:11 ` Kishon Vijay Abraham I [this message]
2016-06-20 16:19 ` Brian Norris
2016-06-20 16:25 ` Doug Anderson
2016-06-20 16:50 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767EB7E.3040606@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox