From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay
Date: Mon, 20 Jun 2016 18:41:52 +0530 [thread overview]
Message-ID: <5767EB98.2030908@ti.com> (raw)
In-Reply-To: <1463092986-61777-3-git-send-email-briannorris@chromium.org>
On Friday 13 May 2016 04:13 AM, Brian Norris wrote:
> The output tap delay controls helps maintain the hold requirements for
> eMMC. The exact value is dependent on the SoC and other factors, though
> it isn't really an exact science. But the default of 0 is not very good,
> as it doesn't give the eMMC much hold time, so let's bump up to 4
> (approx 90 degree phase?). If we need to configure this any further
> (e.g., based on board or speed factors), we may need to consider a
> device tree representation.
>
> Suggested-by: Shawn Lin <shawn.lin@rock-chips•com>
> Signed-off-by: Brian Norris <briannorris@chromium•org>
Acked-by: Kishon Vijay Abraham I <kishon@ti•com>
> ---
> drivers/phy/phy-rockchip-emmc.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c
> index 5641dede32f6..f94d3a6587ed 100644
> --- a/drivers/phy/phy-rockchip-emmc.c
> +++ b/drivers/phy/phy-rockchip-emmc.c
> @@ -69,6 +69,11 @@
> #define PHYCTRL_DR_66OHM 0x2
> #define PHYCTRL_DR_100OHM 0x3
> #define PHYCTRL_DR_40OHM 0x4
> +#define PHYCTRL_OTAPDLYENA 0x1
> +#define PHYCTRL_OTAPDLYENA_MASK 0x1
> +#define PHYCTRL_OTAPDLYENA_SHIFT 0xb
> +#define PHYCTRL_OTAPDLYSEL_MASK 0xf
> +#define PHYCTRL_OTAPDLYSEL_SHIFT 0x7
>
> struct rockchip_emmc_phy {
> unsigned int reg_offset;
> @@ -181,6 +186,20 @@ static int rockchip_emmc_phy_power_on(struct phy *phy)
> PHYCTRL_DR_MASK,
> PHYCTRL_DR_SHIFT));
>
> + /* Output tap delay: enable */
> + regmap_write(rk_phy->reg_base,
> + rk_phy->reg_offset + GRF_EMMCPHY_CON0,
> + HIWORD_UPDATE(PHYCTRL_OTAPDLYENA,
> + PHYCTRL_OTAPDLYENA_MASK,
> + PHYCTRL_OTAPDLYENA_SHIFT));
> +
> + /* Output tap delay */
> + regmap_write(rk_phy->reg_base,
> + rk_phy->reg_offset + GRF_EMMCPHY_CON0,
> + HIWORD_UPDATE(4,
> + PHYCTRL_OTAPDLYSEL_MASK,
> + PHYCTRL_OTAPDLYSEL_SHIFT));
> +
> /* Power up emmc phy analog blocks */
> ret = rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_ON);
> if (ret)
>
next prev parent reply other threads:[~2016-06-20 13:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 22:43 [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Brian Norris
2016-05-12 22:43 ` [PATCH 2/4] phy: rockchip-emmc: configure frequency range and drive impedance Brian Norris
2016-05-13 1:02 ` Shawn Lin
2016-05-13 18:46 ` Doug Anderson
2016-05-13 21:04 ` Brian Norris
2016-05-24 4:51 ` Doug Anderson
2016-05-13 21:09 ` [PATCH v2 " Brian Norris
2016-05-13 22:04 ` Doug Anderson
2016-06-16 23:36 ` Heiko Stuebner
2016-06-20 13:11 ` [PATCH " Kishon Vijay Abraham I
2016-05-12 22:43 ` [PATCH 3/4] phy: rockchip-emmc: configure default output tap delay Brian Norris
2016-05-13 22:25 ` Doug Anderson
2016-05-16 4:15 ` Shawn Lin
2016-05-16 15:12 ` Doug Anderson
2016-06-16 23:36 ` Heiko Stuebner
2016-06-20 13:11 ` Kishon Vijay Abraham I [this message]
2016-05-12 22:43 ` [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions Brian Norris
2016-05-13 22:26 ` Doug Anderson
2016-06-16 23:37 ` Heiko Stuebner
2016-06-20 13:12 ` Kishon Vijay Abraham I
2016-05-13 22:01 ` [PATCH 1/4] phy: rockchip-emmc: give DLL some extra time to be ready Doug Anderson
2016-06-16 23:35 ` Heiko Stuebner
2016-06-20 13:11 ` Kishon Vijay Abraham I
2016-06-20 16:19 ` Brian Norris
2016-06-20 16:25 ` Doug Anderson
2016-06-20 16:50 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767EB98.2030908@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox