* [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM
@ 2026-06-02 14:19 Ronald Claveau via B4 Relay
2026-06-02 16:01 ` Daniel Lezcano
2026-06-02 21:08 ` Daniel Lezcano
0 siblings, 2 replies; 5+ messages in thread
From: Ronald Claveau via B4 Relay @ 2026-06-02 14:19 UTC (permalink / raw)
To: Neil Armstrong, Daniel Lezcano, Zhang Rui, Rafael J. Wysocki,
Lukasz Luba
Cc: Guillaume La Roque, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-arm-kernel, linux-amlogic,
linux-kernel, linux-pm, Mark Brown, kernel test robot,
Ronald Claveau
From: Ronald Claveau <linux-kernel-dev@aliel•fr>
The amlogic thermal driver calls meson_sm_get() and
meson_sm_get_thermal_calib() which are exported by the meson_sm
driver. Without CONFIG_MESON_SM enabled, the build fails with
undefined references to these symbols.
Add a proper Kconfig dependency on MESON_SM instead of relying on
stub functions, which makes the dependency explicit and prevents
invalid configurations.
Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-lkp@intel.com/
Reported-by: Mark Brown <broonie@kernel•org>
Reported-by: kernel test robot <lkp@intel•com>
Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel•fr>
---
Changes in v3:
- Add a dependency on MESON_SM instead of stub functions.
- Link to v2: https://lore.kernel.org/r/20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr
Changes in v2:
- Replace #ifdef CONFIG_MESON_SM by #if IS_ENABLED(CONFIG_MESON_SM)
to cover builtin and module in config.
- Add missing trailers for kernel test robot.
- Link to v1: https://lore.kernel.org/r/20260530-fix-missing-meson_sm-symbol-v1-1-3fb672b989d4@aliel.fr
---
drivers/thermal/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 1c4a5cd5a23ee..810eeccedfbab 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -436,6 +436,7 @@ config AMLOGIC_THERMAL
tristate "Amlogic Thermal Support"
default ARCH_MESON
depends on OF && ARCH_MESON
+ depends on MESON_SM
help
If you say yes here you get support for Amlogic Thermal
for G12 SoC Family.
---
base-commit: 3929405c64376a8a54c794e8a4485023b108a97e
change-id: 20260529-fix-missing-meson_sm-symbol-7776d0d9d760
Best regards,
--
Ronald Claveau <linux-kernel-dev@aliel•fr>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM
2026-06-02 14:19 [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM Ronald Claveau via B4 Relay
@ 2026-06-02 16:01 ` Daniel Lezcano
2026-06-02 16:26 ` linux-kernel-dev
2026-06-02 21:08 ` Daniel Lezcano
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2026-06-02 16:01 UTC (permalink / raw)
To: linux-kernel-dev, Neil Armstrong, Daniel Lezcano, Zhang Rui,
Rafael J. Wysocki, Lukasz Luba
Cc: Guillaume La Roque, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-arm-kernel, linux-amlogic,
linux-kernel, linux-pm, Mark Brown, kernel test robot
On 6/2/26 16:19, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <linux-kernel-dev@aliel•fr>
>
> The amlogic thermal driver calls meson_sm_get() and
> meson_sm_get_thermal_calib() which are exported by the meson_sm
> driver. Without CONFIG_MESON_SM enabled, the build fails with
> undefined references to these symbols.
>
> Add a proper Kconfig dependency on MESON_SM instead of relying on
> stub functions, which makes the dependency explicit and prevents
> invalid configurations.
>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-lkp@intel.com/
> Reported-by: Mark Brown <broonie@kernel•org>
> Reported-by: kernel test robot <lkp@intel•com>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel•fr>
> ---
> Changes in v3:
> - Add a dependency on MESON_SM instead of stub functions.
> - Link to v2: https://lore.kernel.org/r/20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr
>
> Changes in v2:
> - Replace #ifdef CONFIG_MESON_SM by #if IS_ENABLED(CONFIG_MESON_SM)
> to cover builtin and module in config.
> - Add missing trailers for kernel test robot.
> - Link to v1: https://lore.kernel.org/r/20260530-fix-missing-meson_sm-symbol-v1-1-3fb672b989d4@aliel.fr
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 1c4a5cd5a23ee..810eeccedfbab 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -436,6 +436,7 @@ config AMLOGIC_THERMAL
> tristate "Amlogic Thermal Support"
> default ARCH_MESON
> depends on OF && ARCH_MESON
> + depends on MESON_SM
> help
> If you say yes here you get support for Amlogic Thermal
> for G12 SoC Family.
Did you forget to remove the stubs ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM
2026-06-02 16:01 ` Daniel Lezcano
@ 2026-06-02 16:26 ` linux-kernel-dev
0 siblings, 0 replies; 5+ messages in thread
From: linux-kernel-dev @ 2026-06-02 16:26 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Guillaume La Roque, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-arm-kernel, linux-amlogic,
linux-kernel, linux-pm, Mark Brown, kernel test robot,
Neil Armstrong, Daniel Lezcano, Zhang Rui, Rafael J. Wysocki,
Lukasz Luba
On 6/2/26 6:01 PM, Daniel Lezcano wrote:
>> ---
>> drivers/thermal/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 1c4a5cd5a23ee..810eeccedfbab 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -436,6 +436,7 @@ config AMLOGIC_THERMAL
>> tristate "Amlogic Thermal Support"
>> default ARCH_MESON
>> depends on OF && ARCH_MESON
>> + depends on MESON_SM
>> help
>> If you say yes here you get support for Amlogic Thermal
>> for G12 SoC Family.
>
> Did you forget to remove the stubs ?
The commit for the stub as already been removed from the
thermal/bleeding-edge branch, so I think there is nothing to remove
anymore, and I dropped it on my side too.
--
Best regards,
Ronald
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM
2026-06-02 14:19 [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM Ronald Claveau via B4 Relay
2026-06-02 16:01 ` Daniel Lezcano
@ 2026-06-02 21:08 ` Daniel Lezcano
2026-06-03 5:36 ` linux-kernel-dev
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2026-06-02 21:08 UTC (permalink / raw)
To: linux-kernel-dev, Neil Armstrong, Daniel Lezcano, Zhang Rui,
Rafael J. Wysocki, Lukasz Luba
Cc: Guillaume La Roque, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-arm-kernel, linux-amlogic,
linux-kernel, linux-pm, Mark Brown, kernel test robot
On 6/2/26 16:19, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <linux-kernel-dev@aliel•fr>
>
> The amlogic thermal driver calls meson_sm_get() and
> meson_sm_get_thermal_calib() which are exported by the meson_sm
> driver. Without CONFIG_MESON_SM enabled, the build fails with
> undefined references to these symbols.
>
> Add a proper Kconfig dependency on MESON_SM instead of relying on
> stub functions, which makes the dependency explicit and prevents
> invalid configurations.
>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-lkp@intel.com/
> Reported-by: Mark Brown <broonie@kernel•org>
> Reported-by: kernel test robot <lkp@intel•com>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel•fr>
> ---
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM
2026-06-02 21:08 ` Daniel Lezcano
@ 2026-06-03 5:36 ` linux-kernel-dev
0 siblings, 0 replies; 5+ messages in thread
From: linux-kernel-dev @ 2026-06-03 5:36 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Guillaume La Roque, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-arm-kernel, linux-amlogic,
linux-kernel, linux-pm, Mark Brown, kernel test robot,
Neil Armstrong, Daniel Lezcano, Zhang Rui, Rafael J. Wysocki,
Lukasz Luba
On 6/2/26 11:08 PM, Daniel Lezcano wrote:
> On 6/2/26 16:19, Ronald Claveau via B4 Relay wrote:
>> From: Ronald Claveau <linux-kernel-dev@aliel•fr>
>>
>> The amlogic thermal driver calls meson_sm_get() and
>> meson_sm_get_thermal_calib() which are exported by the meson_sm
>> driver. Without CONFIG_MESON_SM enabled, the build fails with
>> undefined references to these symbols.
>>
>> Add a proper Kconfig dependency on MESON_SM instead of relying on
>> stub functions, which makes the dependency explicit and prevents
>> invalid configurations.
>>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-
>> lkp@intel•com/
>> Reported-by: Mark Brown <broonie@kernel•org>
>> Reported-by: kernel test robot <lkp@intel•com>
>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel•fr>
>> ---
>
> Applied, thanks
Thank you.
I think it will need a reorder for bisect to be ok btw.
It needs to come before b21d88de6918 ("thermal/drivers/amlogic: Add
support for secure monitor calibration readout")
--
Best regards,
Ronald
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-03 5:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 14:19 [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM Ronald Claveau via B4 Relay
2026-06-02 16:01 ` Daniel Lezcano
2026-06-02 16:26 ` linux-kernel-dev
2026-06-02 21:08 ` Daniel Lezcano
2026-06-03 5:36 ` linux-kernel-dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox