* [PATCH] x86: Fix ACPI wakeup build failure
@ 2011-03-08 21:39 Sedat Dilek
2011-03-08 22:32 ` Alexander van Heukelum
0 siblings, 1 reply; 2+ messages in thread
From: Sedat Dilek @ 2011-03-08 21:39 UTC (permalink / raw)
Cc: Sedat Dilek, Alexander van Heukelum, H.J. Lu, Len Brown,
Pavel Machek, Rafael J. Wysocki, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, linux-pm, linux-kernel, linux-next
This fixes the following breakage in linux-next (next-20110308):
AS arch/x86/kernel/acpi/wakeup_rm.o
arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with symbol `wakeup_code_start' does not evaluate to a constant
The issue was introduced by commit d1ee433539ea5963a8f946f3428b335d1c5fdb20:
"x86, trampoline: Use the unified trampoline setup for ACPI wakeup"
The problem was discovered while using Debian's binutils (2.21.0.20110302-1)
and experimenting with binutils from upstream.
Thanks Alexander and H.J. for the vital help.
CC: Alexander van Heukelum <heukelum@fastmail•fm>
CC: "H.J. Lu" <hjl.tools@gmail•com>
CC: Len Brown <len.brown@intel•com>
CC: Pavel Machek <pavel@ucw•cz>
CC: "Rafael J. Wysocki" <rjw@sisk•pl>
CC: Thomas Gleixner <tglx@linutronix•de>
CC: Ingo Molnar <mingo@redhat•com>
CC: "H. Peter Anvin" <hpa@zytor•com>
CC: x86@kernel•org
CC: linux-pm@lists•linux-foundation.org
CC: linux-kernel@vger•kernel.org
CC: linux-next@vger•kernel.org
Signed-off-by: Sedat Dilek <sedat.dilek@gmail•com>
---
arch/x86/kernel/acpi/wakeup_rm.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/acpi/wakeup_rm.S b/arch/x86/kernel/acpi/wakeup_rm.S
index 6ce81ee..63b8ab5 100644
--- a/arch/x86/kernel/acpi/wakeup_rm.S
+++ b/arch/x86/kernel/acpi/wakeup_rm.S
@@ -9,4 +9,4 @@
.globl acpi_wakeup_code
acpi_wakeup_code:
.incbin "arch/x86/kernel/acpi/realmode/wakeup.bin"
- .size wakeup_code_start, .-wakeup_code_start
+ .size acpi_wakeup_code, .-acpi_wakeup_code
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: Fix ACPI wakeup build failure
2011-03-08 21:39 [PATCH] x86: Fix ACPI wakeup build failure Sedat Dilek
@ 2011-03-08 22:32 ` Alexander van Heukelum
0 siblings, 0 replies; 2+ messages in thread
From: Alexander van Heukelum @ 2011-03-08 22:32 UTC (permalink / raw)
To: Sedat Dilek
Cc: Sedat Dilek, H.J. Lu, Len Brown, Pavel Machek, Rafael J. Wysocki,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-pm,
linux-kernel, linux-next
On Tue, 08 Mar 2011 22:39 +0100, "Sedat Dilek" <sedat.dilek@googlemail•com> wrote:
> This fixes the following breakage in linux-next (next-20110308):
> AS arch/x86/kernel/acpi/wakeup_rm.o
> arch/x86/kernel/acpi/wakeup_rm.S: Assembler messages:
> arch/x86/kernel/acpi/wakeup_rm.S:12: Error: .size expression with
> symbol `wakeup_code_start' does not evaluate to a constant
>
> The issue was introduced by commit
> d1ee433539ea5963a8f946f3428b335d1c5fdb20:
> "x86, trampoline: Use the unified trampoline setup for ACPI wakeup"
>
> The problem was discovered while using Debian's binutils
> (2.21.0.20110302-1)
> and experimenting with binutils from upstream.
>
> Thanks Alexander and H.J. for the vital help.
>
> CC: Alexander van Heukelum <heukelum@fastmail•fm>
> CC: "H.J. Lu" <hjl.tools@gmail•com>
> CC: Len Brown <len.brown@intel•com>
> CC: Pavel Machek <pavel@ucw•cz>
> CC: "Rafael J. Wysocki" <rjw@sisk•pl>
> CC: Thomas Gleixner <tglx@linutronix•de>
> CC: Ingo Molnar <mingo@redhat•com>
> CC: "H. Peter Anvin" <hpa@zytor•com>
> CC: x86@kernel•org
> CC: linux-pm@lists•linux-foundation.org
> CC: linux-kernel@vger•kernel.org
> CC: linux-next@vger•kernel.org
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail•com>
Acked-by: Alexander van Heukelum <heukelum@fastmail•fm>
(This problem exists in the x86-tree. Mainline is fine.)
> ---
> arch/x86/kernel/acpi/wakeup_rm.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/wakeup_rm.S
> b/arch/x86/kernel/acpi/wakeup_rm.S
> index 6ce81ee..63b8ab5 100644
> --- a/arch/x86/kernel/acpi/wakeup_rm.S
> +++ b/arch/x86/kernel/acpi/wakeup_rm.S
> @@ -9,4 +9,4 @@
> .globl acpi_wakeup_code
> acpi_wakeup_code:
> .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin"
> - .size wakeup_code_start, .-wakeup_code_start
> + .size acpi_wakeup_code, .-acpi_wakeup_code
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-08 22:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 21:39 [PATCH] x86: Fix ACPI wakeup build failure Sedat Dilek
2011-03-08 22:32 ` Alexander van Heukelum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox