From: James Bottomley <jbottomley@parallels•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: "kyle@mcmartin•ca" <kyle@mcmartin•ca>,
"deller@gmx•de" <deller@gmx•de>,
"vapier@gentoo•org" <vapier@gentoo•org>,
"dave.anglin@bell•net" <dave.anglin@bell•net>,
"linux-parisc@vger•kernel.org" <linux-parisc@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>
Subject: Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
Date: Mon, 27 Feb 2012 22:03:10 +0000 [thread overview]
Message-ID: <1330380189.2822.95.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1330378864.2822.92.camel@dabdike.int.hansenpartnership.com>
On Mon, 2012-02-27 at 21:41 +0000, James Bottomley wrote:
> On Mon, 2012-02-27 at 15:59 -0500, Paul Gortmaker wrote:
> > Using the 64 bit toolchains from kernel.org[1], one finds that
> > you can't build the a500_defconfig, because the Makefile will
> > stomp whatever value you have in your env. for CROSS_COMPILE.
> >
> > This shows up since the kernel.org toolchains for parisc-64
> > do not have the "-gnu" prefix, and so you run into it always
> > saying hppa64-linux-gnu-gcc not found, regardless of the fact
> > you've not got "-gnu" put anywhere into CROSS_COMPILE.
> >
> > Since you can set CROSS_COMPILE from the environment and/or set
> > it in your .config file, there really is no need for it to be
> > poked at by the Makefile at all. So just delete it.
> >
> > [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
> >
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
> > ---
> >
> > [v2: no ifdef/endif -- just delete the offending line.]
> >
> > diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> > index 55cca1d..a533367 100644
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> > @@ -31,7 +31,6 @@ ifdef CONFIG_64BIT
> > UTS_MACHINE := parisc64
> > CHECKFLAGS += -D__LP64__=1 -m64
> > WIDTH := 64
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > else # 32-bit
> > WIDTH :=
> > endif
>
> We can't do that ... it crashes a standard build almost immediately
> because it doesn't pick the 64 bit compiler (and we have no biarch
> solution).
>
> We need make on a 64 bit config to work out of the box. It breaks
> with ?= as JDA pointed out because CROSS_COMPILE is always defined.
> Does this satisfy everyone?
>
> James
>
> ---
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 55cca1d..19ab7b2 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,7 +31,11 @@ ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> +
> +# FIXME: if no default set, should really try to locate dynamically
> +ifeq ($(CROSS_COMPILE),)
> CROSS_COMPILE := hppa64-linux-gnu-
> +endif
> else # 32-bit
> WIDTH :=
> endif
There's an awful lot more than just this wrong with that Makefile. For
instance, NATIVE can never be set because ifeq() isn't globbing in make
scripts ... So I think a final (and dynamically choosing if unset)
solution is this one.
I'll stop now before I find something else wrong ...
James
---
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..c823f4a 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -23,24 +23,20 @@ NM = sh $(srctree)/arch/parisc/nm
CHECKFLAGS += -D__hppa__=1
MACHINE := $(shell uname -m)
-ifeq ($(MACHINE),parisc*)
-NATIVE := 1
-endif
ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
-CROSS_COMPILE := hppa64-linux-gnu-
+
+# if no default set, try to find the corresponding 64 bit compiler
+ifeq ($(CROSS_COMPILE),)
+CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
+endif
else # 32-bit
WIDTH :=
endif
-# attempt to help out folks who are cross-compiling
-ifeq ($(NATIVE),1)
-CROSS_COMPILE := hppa$(WIDTH)-linux-
-endif
-
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
cflags-y := -pipe
next prev parent reply other threads:[~2012-02-27 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
2012-02-27 0:30 ` Paul Gortmaker
2012-02-27 15:14 ` John David Anglin
2012-02-27 16:28 ` Paul Gortmaker
2012-02-27 16:45 ` John David Anglin
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2012-02-27 21:41 ` James Bottomley
2012-02-27 22:03 ` James Bottomley [this message]
2012-02-28 1:04 ` Mike Frysinger
2012-02-28 3:17 ` James Bottomley
2012-02-28 6:06 ` Mike Frysinger
2012-02-28 14:10 ` James Bottomley
2012-02-28 15:21 ` Mike Frysinger
2012-02-28 15:33 ` John David Anglin
[not found] ` <CANEJEGv2Zgtd8TGOzSNO8opMLQT8RsGRP=m2rBPUBBOJ9f+fKQ@mail.gmail.com>
2012-02-28 18:37 ` Mike Frysinger
2012-02-28 19:54 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330380189.2822.95.camel@dabdike.int.hansenpartnership.com \
--to=jbottomley@parallels$(echo .)com \
--cc=dave.anglin@bell$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=kyle@mcmartin$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=vapier@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox