From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: John David Anglin <dave.anglin@bell•net>
Cc: JBottomley@parallels•com, jejb@parisc-linux•org,
kyle@mcmartin•ca, deller@gmx•de, linux-parisc@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
Date: Mon, 27 Feb 2012 11:28:06 -0500 [thread overview]
Message-ID: <4F4BAF16.9060507@windriver.com> (raw)
In-Reply-To: <4F4B9DD2.6000600@bell.net>
On 12-02-27 10:14 AM, John David Anglin wrote:
> On 2/26/2012 6:26 PM, Paul Gortmaker wrote:
>> Using the 64 bit toolchains from kernel.org[1], one finds that
>> you can't build the a500_defconfig, because the Makefile will
>> stomp whatever value you have in your env. for CROSS_COMPILE.
>>
>> This shows up since the kernel.org toolchains for parisc-64
>> do not have the "-gnu" prefix, and so you run into it always
>> saying hppa64-linux-gnu-gcc not found, regardless of the fact
>> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>>
>> [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver•com>
>>
>> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>> index 55cca1d..cefff6d 100644
>> --- a/arch/parisc/Makefile
>> +++ b/arch/parisc/Makefile
>> @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
>> UTS_MACHINE := parisc64
>> CHECKFLAGS += -D__LP64__=1 -m64
>> WIDTH := 64
>> -CROSS_COMPILE := hppa64-linux-gnu-
>> +ifndef CROSS_COMPILE
>> + CROSS_COMPILE := hppa64-linux-gnu-
>> +endif
>> else # 32-bit
>> WIDTH :=
>> endif
> This change breaks native builds. So, I assume CROSS_COMPILE must be
> previously defined.
You lost me here. As in a native 32bit env. doing a build for the
64 bit case is setting CROSS_COMPILE?
>
> I couldn't figure out where it is defined. CONFIG_CROSS_COMPILE in my
> .config was an empty string and CROSS_COMPILE was not defined in my
> build environment.
>
> The default toolchain prefix on Debian systems contains "gnu-".
>
> Given that users can use CONFIG_CROSS_COMPILE or set CROSS_COMPILE
> in their build env, maybe setting CROSS_COMPILE in the Makefile is a
> mistake.
Yeah, I'd support a complete nuke-and-pave of the whole Makefile
chunk as well. It does seem redundant and causes more issues than
it solves.
Paul.
>
> Dave
>
next prev parent reply other threads:[~2012-02-27 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
2012-02-27 0:30 ` Paul Gortmaker
2012-02-27 15:14 ` John David Anglin
2012-02-27 16:28 ` Paul Gortmaker [this message]
2012-02-27 16:45 ` John David Anglin
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2012-02-27 21:41 ` James Bottomley
2012-02-27 22:03 ` James Bottomley
2012-02-28 1:04 ` Mike Frysinger
2012-02-28 3:17 ` James Bottomley
2012-02-28 6:06 ` Mike Frysinger
2012-02-28 14:10 ` James Bottomley
2012-02-28 15:21 ` Mike Frysinger
2012-02-28 15:33 ` John David Anglin
[not found] ` <CANEJEGv2Zgtd8TGOzSNO8opMLQT8RsGRP=m2rBPUBBOJ9f+fKQ@mail.gmail.com>
2012-02-28 18:37 ` Mike Frysinger
2012-02-28 19:54 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BAF16.9060507@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=JBottomley@parallels$(echo .)com \
--cc=dave.anglin@bell$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=jejb@parisc-linux$(echo .)org \
--cc=kyle@mcmartin$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox