From: James Bottomley <James.Bottomley@HansenPartnership•com>
To: Mike Frysinger <vapier@gentoo•org>
Cc: Paul Gortmaker <paul.gortmaker@windriver•com>,
"kyle@mcmartin•ca" <kyle@mcmartin•ca>,
"deller@gmx•de" <deller@gmx•de>,
"dave.anglin@bell•net" <dave.anglin@bell•net>,
"linux-parisc@vger•kernel.org" <linux-parisc@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>
Subject: Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
Date: Tue, 28 Feb 2012 08:10:45 -0600 [thread overview]
Message-ID: <1330438245.2822.114.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <201202280106.23643.vapier@gentoo.org>
On Tue, 2012-02-28 at 01:06 -0500, Mike Frysinger wrote:
> On Monday 27 February 2012 22:17:01 James Bottomley wrote:
> > On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> > > On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > > > --- a/arch/parisc/Makefile
> > > > +++ b/arch/parisc/Makefile
> > > >
> > > > -CROSS_COMPILE := hppa64-linux-gnu-
> > > > +
> > > > +# if no default set, try to find the corresponding 64 bit compiler
> > > > +ifeq ($(CROSS_COMPILE),)
> > > > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed
> > > > s/hppa-\\\(.*\\\)/hppa64-\\1-/) +endif
> > >
> > > fails when using "hppa2.0-xxx". perhaps:
Is that a valid prefix? I was thinking hppa32 might be, but hppa2.0 is
supposed to be hppa-xxx with -mpa-risc-2-0.
But anyway, I think being clever and removing unused stuff is likely
orthogonal to the first patch which is just making it all work.
> > > CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed
> > > 's/^hppa[^-]*-/hppa64-/')
> > >
> > > don't even need the ifeq check then
> >
> > How is that different from Carlos' suggestion?
>
> sorry, but i'm not seeing any e-mails from Carlos in this thread. what is his
> suggestion ?
Actually, I misspoke, it was your suggestion in the first thread.
> > The reason it doesn't work is the same ... CROSS_COMPILE is defined to be
> > empty.
>
> my suggestion was purely an incremental improvement on the patch you posted.
> it improves two things:
> - detection when the default tuple is hppa2.0-xxx rather than hppa-xxx
> - one line for set-variable-only-when-its-unset rather than three lines
> -mike
It can't be done ... defined but empty is different from not defined in
makefiles (ifdef or ?= only checks for not defined). CROSS_COMPILE gets
automatically defined by the top level Makefile ... that's why we need a
check for empty not a check for not defined.
James
next prev parent reply other threads:[~2012-02-28 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
2012-02-27 0:30 ` Paul Gortmaker
2012-02-27 15:14 ` John David Anglin
2012-02-27 16:28 ` Paul Gortmaker
2012-02-27 16:45 ` John David Anglin
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2012-02-27 21:41 ` James Bottomley
2012-02-27 22:03 ` James Bottomley
2012-02-28 1:04 ` Mike Frysinger
2012-02-28 3:17 ` James Bottomley
2012-02-28 6:06 ` Mike Frysinger
2012-02-28 14:10 ` James Bottomley [this message]
2012-02-28 15:21 ` Mike Frysinger
2012-02-28 15:33 ` John David Anglin
[not found] ` <CANEJEGv2Zgtd8TGOzSNO8opMLQT8RsGRP=m2rBPUBBOJ9f+fKQ@mail.gmail.com>
2012-02-28 18:37 ` Mike Frysinger
2012-02-28 19:54 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330438245.2822.114.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership$(echo .)com \
--cc=dave.anglin@bell$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=kyle@mcmartin$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=vapier@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox