From: Randy Dunlap <randy.dunlap@oracle•com>
To: Jens Axboe <jens.axboe@oracle•com>
Cc: Jeremy Fitzhardinge <jeremy@goop•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
chrisw@sous-sol•org, virtualization@lists•osdl.org,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for June 13 (XEN)
Date: Sat, 14 Jun 2008 16:13:01 -0700 [thread overview]
Message-ID: <20080614161301.83c276e6.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080614203109.GH20851@kernel.dk>
On Sat, 14 Jun 2008 22:31:10 +0200 Jens Axboe wrote:
> On Fri, Jun 13 2008, Jeremy Fitzhardinge wrote:
> > Randy Dunlap wrote:
> > >next-20080613 on x86_32 has lots of xen build errors like this:
> > >
> > >linux-next-20080613/arch/x86/xen/mmu.c: In function 'drop_mm_ref':
> > >linux-next-20080613/arch/x86/xen/mmu.c:759: error: implicit declaration of
> > >function 'xen_smp_call_function_mask'
> > >make[2]: *** [arch/x86/xen/mmu.o] Error 1
> > >
> > >
> >
> > Ooh, first time I've seen that. Sounds like Jens' patches are missing
> > the appropriate update there (though it's certainly had it in the past).
>
> Hmm, will this work or do we need to force xen smp_ops for this one? I
> wonder if this is new code and was missed, or what happened in this
> case.
Builds cleanly. Thanks.
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 3525ef5..8baef77 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -569,7 +569,7 @@ static void drop_mm_ref(struct mm_struct *mm)
> }
>
> if (!cpus_empty(mask))
> - xen_smp_call_function_mask(mask, drop_other_mm_ref, mm, 1);
> + smp_call_function_mask(mask, drop_other_mm_ref, mm, 1);
> }
> #else
> static void drop_mm_ref(struct mm_struct *mm)
---
~Randy
'"Daemon' is an old piece of jargon from the UNIX operating system,
where it referred to a piece of low-level utility software, a
fundamental part of the operating system."
next prev parent reply other threads:[~2008-06-14 23:17 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 13:22 linux-next: Tree for June 13 Stephen Rothwell
2008-06-13 17:13 ` linux-next: Tree for June 13 (XEN) Randy Dunlap
2008-06-13 22:16 ` Jeremy Fitzhardinge
2008-06-14 20:31 ` Jens Axboe
2008-06-14 23:13 ` Randy Dunlap [this message]
2008-06-15 6:11 ` Jeremy Fitzhardinge
2008-06-16 19:30 ` Jens Axboe
2008-06-16 20:40 ` Jeremy Fitzhardinge
2008-06-13 22:58 ` linux-next: Tree for June 13 (x86_64: panic) Randy Dunlap
2008-06-14 8:16 ` Stephen Rothwell
2008-06-14 23:15 ` Randy Dunlap
2008-06-15 16:33 ` linux-next: Tree for June 13 (soft lockup) Randy Dunlap
2008-06-15 18:31 ` linux-next: Tree for June 13 Rafael J. Wysocki
[not found] ` <200806160314.49489.rjw@sisk.pl>
2008-06-16 2:45 ` linux-next: Tree for June 13: IO APIC breakage on HP nx6325 Maciej W. Rozycki
2008-06-16 13:39 ` Rafael J. Wysocki
2008-06-16 15:39 ` Maciej W. Rozycki
2008-06-16 22:38 ` Rafael J. Wysocki
2008-06-16 23:05 ` Rafael J. Wysocki
2008-06-17 7:12 ` Thomas Gleixner
2008-06-17 20:44 ` Rafael J. Wysocki
2008-06-17 22:19 ` Rafael J. Wysocki
2008-06-17 22:25 ` Rafael J. Wysocki
2008-06-18 8:02 ` Thomas Gleixner
2008-06-18 12:41 ` Thomas Gleixner
2008-06-18 14:37 ` Rafael J. Wysocki
2008-06-18 14:40 ` Rafael J. Wysocki
2008-06-18 15:29 ` Thomas Gleixner
2008-06-21 22:47 ` Rafael J. Wysocki
2008-06-18 13:15 ` Ingo Molnar
2008-06-18 13:14 ` Ingo Molnar
2008-06-17 20:59 ` Rafael J. Wysocki
2008-06-17 21:19 ` Maciej W. Rozycki
2008-06-17 21:38 ` Rafael J. Wysocki
2008-06-17 22:53 ` Rafael J. Wysocki
2008-06-18 4:02 ` Maciej W. Rozycki
2008-06-18 19:06 ` Cyrill Gorcunov
2008-06-18 22:36 ` Maciej W. Rozycki
2008-06-20 18:59 ` Cyrill Gorcunov
2008-06-20 20:44 ` Maciej W. Rozycki
2008-06-18 22:11 ` Rafael J. Wysocki
2008-06-18 23:39 ` Maciej W. Rozycki
2008-06-19 0:25 ` Rafael J. Wysocki
2008-06-20 0:35 ` Maciej W. Rozycki
2008-06-20 11:53 ` Rafael J. Wysocki
2008-06-20 11:57 ` Matthew Garrett
2008-06-20 12:22 ` Rafael J. Wysocki
2008-06-20 12:27 ` Matthew Garrett
2008-06-21 1:09 ` Maciej W. Rozycki
2008-06-21 1:40 ` Matthew Garrett
2008-06-21 2:41 ` Maciej W. Rozycki
2008-06-21 12:38 ` Matthew Garrett
2008-06-26 19:52 ` Rafael J. Wysocki
2008-06-27 0:06 ` Maciej W. Rozycki
2008-06-29 14:00 ` Rafael J. Wysocki
2008-06-29 19:05 ` Maciej W. Rozycki
2008-06-29 19:23 ` Rafael J. Wysocki
2008-06-29 19:56 ` Maciej W. Rozycki
2008-06-29 20:02 ` Ingo Molnar
2008-06-29 20:14 ` Maciej W. Rozycki
2008-06-29 23:06 ` Rafael J. Wysocki
2008-06-30 0:45 ` Andi Kleen
2008-06-30 0:47 ` Matthew Garrett
2008-06-30 1:39 ` Maciej W. Rozycki
2008-06-30 9:24 ` Andi Kleen
2008-07-02 1:19 ` Maciej W. Rozycki
2008-06-30 10:41 ` Rafael J. Wysocki
2008-07-02 1:48 ` Maciej W. Rozycki
2008-07-02 9:35 ` Andi Kleen
2008-06-29 22:59 ` Rafael J. Wysocki
2008-06-29 22:56 ` Rafael J. Wysocki
2008-06-30 1:00 ` Maciej W. Rozycki
2008-06-30 9:06 ` Matthew Garrett
2008-06-30 15:29 ` Maciej W. Rozycki
2008-06-30 15:35 ` Matthew Garrett
2008-06-29 19:23 ` Matthew Garrett
2008-06-29 19:31 ` Rafael J. Wysocki
2008-06-29 20:03 ` Maciej W. Rozycki
2008-06-29 20:07 ` Matthew Garrett
2008-06-29 20:16 ` Maciej W. Rozycki
2008-06-24 9:15 ` Pavel Machek
2008-06-26 8:37 ` Rafael J. Wysocki
2008-06-27 1:53 ` Maciej W. Rozycki
2008-07-08 12:48 ` Pavel Machek
2008-06-21 1:49 ` Maciej W. Rozycki
2008-06-19 9:35 ` Ingo Molnar
2008-06-19 18:17 ` Maciej W. Rozycki
2008-06-20 10:44 ` Ingo Molnar
2008-06-20 13:11 ` Thomas Gleixner
2008-06-20 20:56 ` Maciej W. Rozycki
2008-06-17 0:08 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080614161301.83c276e6.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=chrisw@sous-sol$(echo .)org \
--cc=jens.axboe@oracle$(echo .)com \
--cc=jeremy@goop$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=virtualization@lists$(echo .)osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox