From: Thomas Gleixner <tglx@linutronix•de>
To: "Maciej W. Rozycki" <macro@linux-mips•org>
Cc: Ingo Molnar <mingo@elte•hu>, "Rafael J. Wysocki" <rjw@sisk•pl>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
ACPI Devel Maling List <linux-acpi@vger•kernel.org>,
Len Brown <lenb@kernel•org>
Subject: Re: linux-next: Tree for June 13: IO APIC breakage on HP nx6325
Date: Fri, 20 Jun 2008 15:11:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.1.10.0806201507190.3395@apollo.tec.linutronix.de> (raw)
In-Reply-To: <Pine.LNX.4.55.0806191619560.12929@cliff.in.clinika.pl>
On Thu, 19 Jun 2008, Maciej W. Rozycki wrote:
> On Thu, 19 Jun 2008, Ingo Molnar wrote:
> > * Maciej W. Rozycki <macro@linux-mips•org> wrote:
> > does PIT programming matter? One detail which might matter and which
> > touches IRQ0 generation is the clockevent driver on nohz/highres. See
> > arch/x86/kernel/i8253.c:init_pit_timer():
> >
> > case CLOCK_EVT_MODE_SHUTDOWN:
> > case CLOCK_EVT_MODE_UNUSED:
> > if (evt->mode == CLOCK_EVT_MODE_PERIODIC ||
> > evt->mode == CLOCK_EVT_MODE_ONESHOT) {
> > outb_pit(0x30, PIT_MODE);
> > outb_pit(0, PIT_CH0);
> > outb_pit(0, PIT_CH0);
> > }
> > pit_disable_clocksource();
> > break;
> >
> > case CLOCK_EVT_MODE_ONESHOT:
> > /* One shot setup */
> > pit_disable_clocksource();
> > outb_pit(0x38, PIT_MODE);
> > break;
>
> It does, though not necessarily in this case. In principle all this
> 8254-through-APIC timer validation code assumes the source retriggers
> automatically and if an edge is lost because the APIC input targeted is
> masked or not configured yet, another one will follow shortly by itself.
> It used to be the case when this code was implemented as we never used any
> of the single-shot modes of the 8254 back then.
>
> Is it now possible at the time check_timer() is called the 8254 has been
> put in one of the single-shot modes? If so, then additional code has to
> be put in place either to switch the timer into the periodic mode for the
> duration of check_timer() or to rearm the timer if in a single-shot mode
> each time timer_irq_works() is called.
At this point the PIT is in periodic mode.
Let me explain how the timer startup works:
PIT is started in periodic mode
... basic CPU bring up
APIC timer initialization (switches PIT off)
...
Highres/Dyntick mode switches local apic timers to one shot mode
When the system has C2/C3 or C1E states, then we restart the PIT in
one shot mode and reprogram it every time when the system goes into
idle to replace the local apic timer, which stops in those states.
Thanks,
tglx
next prev parent reply other threads:[~2008-06-20 13:12 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 13:22 linux-next: Tree for June 13 Stephen Rothwell
2008-06-13 17:13 ` linux-next: Tree for June 13 (XEN) Randy Dunlap
2008-06-13 22:16 ` Jeremy Fitzhardinge
2008-06-14 20:31 ` Jens Axboe
2008-06-14 23:13 ` Randy Dunlap
2008-06-15 6:11 ` Jeremy Fitzhardinge
2008-06-16 19:30 ` Jens Axboe
2008-06-16 20:40 ` Jeremy Fitzhardinge
2008-06-13 22:58 ` linux-next: Tree for June 13 (x86_64: panic) Randy Dunlap
2008-06-14 8:16 ` Stephen Rothwell
2008-06-14 23:15 ` Randy Dunlap
2008-06-15 16:33 ` linux-next: Tree for June 13 (soft lockup) Randy Dunlap
2008-06-15 18:31 ` linux-next: Tree for June 13 Rafael J. Wysocki
[not found] ` <200806160314.49489.rjw@sisk.pl>
2008-06-16 2:45 ` linux-next: Tree for June 13: IO APIC breakage on HP nx6325 Maciej W. Rozycki
2008-06-16 13:39 ` Rafael J. Wysocki
2008-06-16 15:39 ` Maciej W. Rozycki
2008-06-16 22:38 ` Rafael J. Wysocki
2008-06-16 23:05 ` Rafael J. Wysocki
2008-06-17 7:12 ` Thomas Gleixner
2008-06-17 20:44 ` Rafael J. Wysocki
2008-06-17 22:19 ` Rafael J. Wysocki
2008-06-17 22:25 ` Rafael J. Wysocki
2008-06-18 8:02 ` Thomas Gleixner
2008-06-18 12:41 ` Thomas Gleixner
2008-06-18 14:37 ` Rafael J. Wysocki
2008-06-18 14:40 ` Rafael J. Wysocki
2008-06-18 15:29 ` Thomas Gleixner
2008-06-21 22:47 ` Rafael J. Wysocki
2008-06-18 13:15 ` Ingo Molnar
2008-06-18 13:14 ` Ingo Molnar
2008-06-17 20:59 ` Rafael J. Wysocki
2008-06-17 21:19 ` Maciej W. Rozycki
2008-06-17 21:38 ` Rafael J. Wysocki
2008-06-17 22:53 ` Rafael J. Wysocki
2008-06-18 4:02 ` Maciej W. Rozycki
2008-06-18 19:06 ` Cyrill Gorcunov
2008-06-18 22:36 ` Maciej W. Rozycki
2008-06-20 18:59 ` Cyrill Gorcunov
2008-06-20 20:44 ` Maciej W. Rozycki
2008-06-18 22:11 ` Rafael J. Wysocki
2008-06-18 23:39 ` Maciej W. Rozycki
2008-06-19 0:25 ` Rafael J. Wysocki
2008-06-20 0:35 ` Maciej W. Rozycki
2008-06-20 11:53 ` Rafael J. Wysocki
2008-06-20 11:57 ` Matthew Garrett
2008-06-20 12:22 ` Rafael J. Wysocki
2008-06-20 12:27 ` Matthew Garrett
2008-06-21 1:09 ` Maciej W. Rozycki
2008-06-21 1:40 ` Matthew Garrett
2008-06-21 2:41 ` Maciej W. Rozycki
2008-06-21 12:38 ` Matthew Garrett
2008-06-26 19:52 ` Rafael J. Wysocki
2008-06-27 0:06 ` Maciej W. Rozycki
2008-06-29 14:00 ` Rafael J. Wysocki
2008-06-29 19:05 ` Maciej W. Rozycki
2008-06-29 19:23 ` Rafael J. Wysocki
2008-06-29 19:56 ` Maciej W. Rozycki
2008-06-29 20:02 ` Ingo Molnar
2008-06-29 20:14 ` Maciej W. Rozycki
2008-06-29 23:06 ` Rafael J. Wysocki
2008-06-30 0:45 ` Andi Kleen
2008-06-30 0:47 ` Matthew Garrett
2008-06-30 1:39 ` Maciej W. Rozycki
2008-06-30 9:24 ` Andi Kleen
2008-07-02 1:19 ` Maciej W. Rozycki
2008-06-30 10:41 ` Rafael J. Wysocki
2008-07-02 1:48 ` Maciej W. Rozycki
2008-07-02 9:35 ` Andi Kleen
2008-06-29 22:59 ` Rafael J. Wysocki
2008-06-29 22:56 ` Rafael J. Wysocki
2008-06-30 1:00 ` Maciej W. Rozycki
2008-06-30 9:06 ` Matthew Garrett
2008-06-30 15:29 ` Maciej W. Rozycki
2008-06-30 15:35 ` Matthew Garrett
2008-06-29 19:23 ` Matthew Garrett
2008-06-29 19:31 ` Rafael J. Wysocki
2008-06-29 20:03 ` Maciej W. Rozycki
2008-06-29 20:07 ` Matthew Garrett
2008-06-29 20:16 ` Maciej W. Rozycki
2008-06-24 9:15 ` Pavel Machek
2008-06-26 8:37 ` Rafael J. Wysocki
2008-06-27 1:53 ` Maciej W. Rozycki
2008-07-08 12:48 ` Pavel Machek
2008-06-21 1:49 ` Maciej W. Rozycki
2008-06-19 9:35 ` Ingo Molnar
2008-06-19 18:17 ` Maciej W. Rozycki
2008-06-20 10:44 ` Ingo Molnar
2008-06-20 13:11 ` Thomas Gleixner [this message]
2008-06-20 20:56 ` Maciej W. Rozycki
2008-06-17 0:08 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0806201507190.3395@apollo.tec.linutronix.de \
--to=tglx@linutronix$(echo .)de \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=macro@linux-mips$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=rjw@sisk$(echo .)pl \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox