From: "Rafael J. Wysocki" <rjw@sisk•pl>
To: "Maciej W. Rozycki" <macro@linux-mips•org>
Cc: Ingo Molnar <mingo@elte•hu>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Thomas Gleixner <tglx@linutronix•de>,
ACPI Devel Maling List <linux-acpi@vger•kernel.org>,
Len Brown <lenb@kernel•org>
Subject: Re: linux-next: Tree for June 13: IO APIC breakage on HP nx6325
Date: Wed, 18 Jun 2008 00:53:39 +0200 [thread overview]
Message-ID: <200806180053.40044.rjw@sisk.pl> (raw)
In-Reply-To: <200806172338.38318.rjw@sisk.pl>
On Tuesday, 17 of June 2008, Rafael J. Wysocki wrote:
> On Tuesday, 17 of June 2008, Maciej W. Rozycki wrote:
> > On Tue, 17 Jun 2008, Rafael J. Wysocki wrote:
> >
> > > May I gently ask that the patch ("x86: I/O APIC: timer through 8259A second-chance")
> > > be reverted?
> >
> > We're trying to find a solution for a long-standing problem and this
> > patch is a step in that direction. We need to find out exactly what is
> > going wrong with the HP nx6325 system and removing the patch would make us
> > lose the opportunity to get things right in this area. At the time I
> > submitted that patch I warned a lot of testing would be required before it
> > goes upstream and hopefully my request will get honored. If you do not
> > want to participate in testing for whatever reason, you have the right to
> > do so, but I insist on the patch to stay at least until we know the source
> > of the problem and conclude there is no other way to get it fixed. Len
> > reported he's got the same system and it behaves the same, so I hope he'll
> > be able to do the testing if you decide to opt out.
>
> I can do the testing actually, but IMO putting that patch into linux-next was a
> mistake.
>
> > Unfortunately the 64-bit variation has a lot of necessary logging
> > disabled by default (as you have now discovered with the need to rename
> > apic_printk() to printk()), so my plan is to cook up a patch to enable all
> > the available logging facilities around that code first.
>
> Well, that's easy. I can send you a dmesg output with all of the printk()s in
> there functional if that helps, but frankly I don't see how this is going to
> get you more information than I've already posted.
Here you go. Below is the relevant snippet from the yesterday's linux-next
dmesg with the patches:
"x86: I/O APIC: timer through 8259A second-chance"
"x86: add C1E aware idle function"
reverted and the appended debug patch applied.
[ 0.108006] TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
[ 0.108006] ..MP-BIOS bug: 8254 timer not connected to IO-APIC
[ 0.108006] ...trying to set up timer (IRQ0) through the 8259A ... <2> failed
[ 0.108006] ...trying to set up timer as Virtual Wire IRQ...<2> works.
The entire dmesg is at: http://www.sisk.pl/kernel/debug/20080616/dmesg-4.log
Thanks,
Rafael
---
arch/x86/kernel/io_apic_64.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
Index: linux-next/arch/x86/kernel/io_apic_64.c
===================================================================
--- linux-next.orig/arch/x86/kernel/io_apic_64.c
+++ linux-next/arch/x86/kernel/io_apic_64.c
@@ -1667,7 +1667,7 @@ static inline void __init check_timer(vo
pin2 = ioapic_i8259.pin;
apic2 = ioapic_i8259.apic;
- apic_printk(APIC_VERBOSE,KERN_INFO "..TIMER: vector=0x%02X apic1=%d pin1=%d apic2=%d pin2=%d\n",
+ printk(KERN_CRIT "TIMER: vector=0x%02X apic1=%d pin1=%d apic2=%d pin2=%d\n",
cfg->vector, apic1, pin1, apic2, pin2);
if (pin1 != -1) {
@@ -1686,14 +1686,14 @@ static inline void __init check_timer(vo
goto out;
}
clear_IO_APIC_pin(apic1, pin1);
- apic_printk(APIC_QUIET,KERN_ERR "..MP-BIOS bug: 8254 timer not "
+ printk(KERN_CRIT "..MP-BIOS bug: 8254 timer not "
"connected to IO-APIC\n");
}
- apic_printk(APIC_VERBOSE,KERN_INFO "...trying to set up timer (IRQ0) "
+ printk(KERN_CRIT "...trying to set up timer (IRQ0) "
"through the 8259A ... ");
if (pin2 != -1) {
- apic_printk(APIC_VERBOSE,"\n..... (found apic %d pin %d) ...",
+ printk(KERN_CRIT "\n..... (found apic %d pin %d) ...",
apic2, pin2);
/*
* legacy devices should be connected to IO APIC #0
@@ -1702,7 +1702,7 @@ static inline void __init check_timer(vo
unmask_IO_APIC_irq(0);
enable_8259A_irq(0);
if (timer_irq_works()) {
- apic_printk(APIC_VERBOSE," works.\n");
+ printk(KERN_CRIT " works.\n");
timer_through_8259 = 1;
nmi_watchdog_default();
if (nmi_watchdog == NMI_IO_APIC) {
@@ -1718,28 +1718,28 @@ static inline void __init check_timer(vo
disable_8259A_irq(0);
clear_IO_APIC_pin(apic2, pin2);
}
- apic_printk(APIC_VERBOSE," failed.\n");
+ printk(KERN_CRIT " failed.\n");
if (nmi_watchdog == NMI_IO_APIC) {
- printk(KERN_WARNING "timer doesn't work through the IO-APIC - disabling NMI Watchdog!\n");
+ printk(KERN_CRIT "timer doesn't work through the IO-APIC - disabling NMI Watchdog!\n");
nmi_watchdog = NMI_NONE;
}
- apic_printk(APIC_VERBOSE, KERN_INFO "...trying to set up timer as Virtual Wire IRQ...");
+ printk(KERN_CRIT "...trying to set up timer as Virtual Wire IRQ...");
irq_desc[0].chip = &lapic_irq_type;
apic_write(APIC_LVT0, APIC_DM_FIXED | cfg->vector); /* Fixed mode */
enable_8259A_irq(0);
if (timer_irq_works()) {
- apic_printk(APIC_VERBOSE," works.\n");
+ printk(KERN_CRIT " works.\n");
goto out;
}
disable_8259A_irq(0);
apic_write(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_FIXED | cfg->vector);
- apic_printk(APIC_VERBOSE," failed.\n");
+ printk(KERN_CRIT " failed.\n");
- apic_printk(APIC_VERBOSE, KERN_INFO "...trying to set up timer as ExtINT IRQ...");
+ printk(KERN_CRIT "...trying to set up timer as ExtINT IRQ...");
init_8259A(0);
make_8259A_irq(0);
@@ -1748,10 +1748,10 @@ static inline void __init check_timer(vo
unlock_ExtINT_logic();
if (timer_irq_works()) {
- apic_printk(APIC_VERBOSE," works.\n");
+ printk(KERN_CRIT " works.\n");
goto out;
}
- apic_printk(APIC_VERBOSE," failed :(.\n");
+ printk(KERN_CRIT " failed :(.\n");
panic("IO-APIC + timer doesn't work! Try using the 'noapic' kernel parameter\n");
out:
local_irq_restore(flags);
next prev parent reply other threads:[~2008-06-17 22:52 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 13:22 linux-next: Tree for June 13 Stephen Rothwell
2008-06-13 17:13 ` linux-next: Tree for June 13 (XEN) Randy Dunlap
2008-06-13 22:16 ` Jeremy Fitzhardinge
2008-06-14 20:31 ` Jens Axboe
2008-06-14 23:13 ` Randy Dunlap
2008-06-15 6:11 ` Jeremy Fitzhardinge
2008-06-16 19:30 ` Jens Axboe
2008-06-16 20:40 ` Jeremy Fitzhardinge
2008-06-13 22:58 ` linux-next: Tree for June 13 (x86_64: panic) Randy Dunlap
2008-06-14 8:16 ` Stephen Rothwell
2008-06-14 23:15 ` Randy Dunlap
2008-06-15 16:33 ` linux-next: Tree for June 13 (soft lockup) Randy Dunlap
2008-06-15 18:31 ` linux-next: Tree for June 13 Rafael J. Wysocki
[not found] ` <200806160314.49489.rjw@sisk.pl>
2008-06-16 2:45 ` linux-next: Tree for June 13: IO APIC breakage on HP nx6325 Maciej W. Rozycki
2008-06-16 13:39 ` Rafael J. Wysocki
2008-06-16 15:39 ` Maciej W. Rozycki
2008-06-16 22:38 ` Rafael J. Wysocki
2008-06-16 23:05 ` Rafael J. Wysocki
2008-06-17 7:12 ` Thomas Gleixner
2008-06-17 20:44 ` Rafael J. Wysocki
2008-06-17 22:19 ` Rafael J. Wysocki
2008-06-17 22:25 ` Rafael J. Wysocki
2008-06-18 8:02 ` Thomas Gleixner
2008-06-18 12:41 ` Thomas Gleixner
2008-06-18 14:37 ` Rafael J. Wysocki
2008-06-18 14:40 ` Rafael J. Wysocki
2008-06-18 15:29 ` Thomas Gleixner
2008-06-21 22:47 ` Rafael J. Wysocki
2008-06-18 13:15 ` Ingo Molnar
2008-06-18 13:14 ` Ingo Molnar
2008-06-17 20:59 ` Rafael J. Wysocki
2008-06-17 21:19 ` Maciej W. Rozycki
2008-06-17 21:38 ` Rafael J. Wysocki
2008-06-17 22:53 ` Rafael J. Wysocki [this message]
2008-06-18 4:02 ` Maciej W. Rozycki
2008-06-18 19:06 ` Cyrill Gorcunov
2008-06-18 22:36 ` Maciej W. Rozycki
2008-06-20 18:59 ` Cyrill Gorcunov
2008-06-20 20:44 ` Maciej W. Rozycki
2008-06-18 22:11 ` Rafael J. Wysocki
2008-06-18 23:39 ` Maciej W. Rozycki
2008-06-19 0:25 ` Rafael J. Wysocki
2008-06-20 0:35 ` Maciej W. Rozycki
2008-06-20 11:53 ` Rafael J. Wysocki
2008-06-20 11:57 ` Matthew Garrett
2008-06-20 12:22 ` Rafael J. Wysocki
2008-06-20 12:27 ` Matthew Garrett
2008-06-21 1:09 ` Maciej W. Rozycki
2008-06-21 1:40 ` Matthew Garrett
2008-06-21 2:41 ` Maciej W. Rozycki
2008-06-21 12:38 ` Matthew Garrett
2008-06-26 19:52 ` Rafael J. Wysocki
2008-06-27 0:06 ` Maciej W. Rozycki
2008-06-29 14:00 ` Rafael J. Wysocki
2008-06-29 19:05 ` Maciej W. Rozycki
2008-06-29 19:23 ` Rafael J. Wysocki
2008-06-29 19:56 ` Maciej W. Rozycki
2008-06-29 20:02 ` Ingo Molnar
2008-06-29 20:14 ` Maciej W. Rozycki
2008-06-29 23:06 ` Rafael J. Wysocki
2008-06-30 0:45 ` Andi Kleen
2008-06-30 0:47 ` Matthew Garrett
2008-06-30 1:39 ` Maciej W. Rozycki
2008-06-30 9:24 ` Andi Kleen
2008-07-02 1:19 ` Maciej W. Rozycki
2008-06-30 10:41 ` Rafael J. Wysocki
2008-07-02 1:48 ` Maciej W. Rozycki
2008-07-02 9:35 ` Andi Kleen
2008-06-29 22:59 ` Rafael J. Wysocki
2008-06-29 22:56 ` Rafael J. Wysocki
2008-06-30 1:00 ` Maciej W. Rozycki
2008-06-30 9:06 ` Matthew Garrett
2008-06-30 15:29 ` Maciej W. Rozycki
2008-06-30 15:35 ` Matthew Garrett
2008-06-29 19:23 ` Matthew Garrett
2008-06-29 19:31 ` Rafael J. Wysocki
2008-06-29 20:03 ` Maciej W. Rozycki
2008-06-29 20:07 ` Matthew Garrett
2008-06-29 20:16 ` Maciej W. Rozycki
2008-06-24 9:15 ` Pavel Machek
2008-06-26 8:37 ` Rafael J. Wysocki
2008-06-27 1:53 ` Maciej W. Rozycki
2008-07-08 12:48 ` Pavel Machek
2008-06-21 1:49 ` Maciej W. Rozycki
2008-06-19 9:35 ` Ingo Molnar
2008-06-19 18:17 ` Maciej W. Rozycki
2008-06-20 10:44 ` Ingo Molnar
2008-06-20 13:11 ` Thomas Gleixner
2008-06-20 20:56 ` Maciej W. Rozycki
2008-06-17 0:08 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806180053.40044.rjw@sisk.pl \
--to=rjw@sisk$(echo .)pl \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=macro@linux-mips$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox