public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
* [PATCH -next] fujitsu-laptop: depends on INPUT
@ 2008-06-23 16:34 Randy Dunlap
  2008-06-26  4:35 ` Jonathan Woithe
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-06-23 16:34 UTC (permalink / raw)
  To: jwoithe; +Cc: linux-acpi, linux-next, akpm

From: Randy Dunlap <randy.dunlap@oracle•com>

fujitsu-laptop uses input_* functions, so it should depend
on INPUT.

drivers/built-in.o: In function `acpi_fujitsu_add':
fujitsu-laptop.c:(.text+0xaaec7): undefined reference to `input_allocate_device'
fujitsu-laptop.c:(.text+0xaaf39): undefined reference to `input_register_device'
fujitsu-laptop.c:(.text+0xab025): undefined reference to `input_free_device'
drivers/built-in.o: In function `acpi_fujitsu_notify':
fujitsu-laptop.c:(.text+0xab0d8): undefined reference to `input_event'
fujitsu-laptop.c:(.text+0xab0e5): undefined reference to `input_event'
fujitsu-laptop.c:(.text+0xab0f5): undefined reference to `input_event'
fujitsu-laptop.c:(.text+0xab102): undefined reference to `input_event'
drivers/built-in.o: In function `acpi_fujitsu_hotkey_notify':
fujitsu-laptop.c:(.text+0xab261): undefined reference to `input_event'
drivers/built-in.o:fujitsu-laptop.c:(.text+0xab26e): more undefined references to `input_event' follow
drivers/built-in.o: In function `acpi_fujitsu_hotkey_add':
fujitsu-laptop.c:(.text+0xab49c): undefined reference to `input_allocate_device'
fujitsu-laptop.c:(.text+0xab51a): undefined reference to `input_register_device'
fujitsu-laptop.c:(.text+0xab5e4): undefined reference to `input_free_device'
make[1]: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
 drivers/misc/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20080623.orig/drivers/misc/Kconfig
+++ linux-next-20080623/drivers/misc/Kconfig
@@ -179,6 +179,7 @@ config FUJITSU_LAPTOP
         tristate "Fujitsu Laptop Extras"
         depends on X86
         depends on ACPI
+        depends on INPUT
         depends on BACKLIGHT_CLASS_DEVICE
         ---help---
 	  This is a driver for laptops built by Fujitsu:


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] fujitsu-laptop: depends on INPUT
  2008-06-23 16:34 [PATCH -next] fujitsu-laptop: depends on INPUT Randy Dunlap
@ 2008-06-26  4:35 ` Jonathan Woithe
  2008-06-26 14:22   ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Woithe @ 2008-06-26  4:35 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: jwoithe, linux-acpi, linux-next, akpm

> From: Randy Dunlap <randy.dunlap@oracle•com>
> 
> fujitsu-laptop uses input_* functions, so it should depend
> on INPUT.
:
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> ---
>  drivers/misc/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20080623.orig/drivers/misc/Kconfig
> +++ linux-next-20080623/drivers/misc/Kconfig
> @@ -179,6 +179,7 @@ config FUJITSU_LAPTOP
>          tristate "Fujitsu Laptop Extras"
>          depends on X86
>          depends on ACPI
> +        depends on INPUT
>          depends on BACKLIGHT_CLASS_DEVICE
>          ---help---
>  	  This is a driver for laptops built by Fujitsu:

Ack.

jonathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] fujitsu-laptop: depends on INPUT
  2008-06-26  4:35 ` Jonathan Woithe
@ 2008-06-26 14:22   ` Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-06-26 14:22 UTC (permalink / raw)
  To: Jonathan Woithe; +Cc: Randy Dunlap, linux-acpi, linux-next, akpm

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

On Thu, 26 Jun 2008 14:05:36 +0930 (CST) Jonathan Woithe <jwoithe@physics•adelaide.edu.au> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> > 
> > fujitsu-laptop uses input_* functions, so it should depend
> > on INPUT.
> :
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> > ---
> >  drivers/misc/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- linux-next-20080623.orig/drivers/misc/Kconfig
> > +++ linux-next-20080623/drivers/misc/Kconfig
> > @@ -179,6 +179,7 @@ config FUJITSU_LAPTOP
> >          tristate "Fujitsu Laptop Extras"
> >          depends on X86
> >          depends on ACPI
> > +        depends on INPUT
> >          depends on BACKLIGHT_CLASS_DEVICE
> >          ---help---
> >  	  This is a driver for laptops built by Fujitsu:
> 
> Ack.

I have added this to today's linux-next tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-06-26 14:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 16:34 [PATCH -next] fujitsu-laptop: depends on INPUT Randy Dunlap
2008-06-26  4:35 ` Jonathan Woithe
2008-06-26 14:22   ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox