public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Rusty Russell <rusty@rustcorp•com.au>
Cc: linux-next@vger•kernel.org, Denys Vlasenko <vda.linux@googlemail•com>
Subject: linux-next: rr tree build failure
Date: Wed, 25 Jun 2008 16:44:48 +1000	[thread overview]
Message-ID: <20080625164448.fdb43e57.sfr@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi Rusty,

Today's linux-next build (powerpc ppc64_defconfig (CONFIG_UNUSED_SYMBOLS
is not set, but CONFIG_MODVERSIONS is set)) failed like this:

kernel/module.c: In function 'load_module':
kernel/module.c:2084: error: expected expression before ')' token

Caused by commit 29ec97e82935397e13e7e7f3db75111e9937931c
("module:shrink-struct-module") from the rr tree.

I applied the patch below which should be merged in with the above commit
if possible (or something like it).

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

>From b790b16878f90c9ee23f8569bf6246c0ec258562 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Wed, 25 Jun 2008 16:40:44 +1000
Subject: [PATCH] rr fix patch 1

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>

---
 kernel/module.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index a4bdd77..ceae92b 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2076,9 +2076,9 @@ static struct module *load_module(void __user *umod,
 #ifdef CONFIG_MODVERSIONS
 	if ((mod->num_syms && !crcindex) ||
 	    (mod->num_gpl_syms && !gplcrcindex) ||
-	    (mod->num_gpl_future_syms && !gplfuturecrcindex) ||
+	    (mod->num_gpl_future_syms && !gplfuturecrcindex)
 #ifdef CONFIG_UNUSED_SYMBOLS
-	    (mod->num_unused_syms && !unusedcrcindex) ||
+	    || (mod->num_unused_syms && !unusedcrcindex) ||
 	    (mod->num_unused_gpl_syms && !unusedgplcrcindex)
 #endif
 		) {
-- 
1.5.5.4


[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2008-06-25  6:44 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25  6:44 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-25  6:58 linux-next: rr tree build failure Stephen Rothwell
2008-06-25  7:35 ` Christian Borntraeger
2008-06-25  8:30   ` Rusty Russell
2008-06-25  9:08     ` Christian Borntraeger
2008-06-26  6:50 Stephen Rothwell
2008-06-26  7:49 ` Christian Borntraeger
2008-06-27  3:15   ` Rusty Russell
2008-10-23  4:51 Stephen Rothwell
2008-10-23 13:02 ` Rusty Russell
2008-10-23  4:52 Stephen Rothwell
2008-10-23 13:31 ` Rusty Russell
2008-11-20  3:50 Stephen Rothwell
2008-11-21  3:19 Stephen Rothwell
2008-11-21 10:58 ` Rusty Russell
2008-11-21 18:34   ` Greg KH
2008-11-24  3:31 Stephen Rothwell
2008-11-24 17:07 ` Rusty Russell
2008-11-25  6:45 Stephen Rothwell
2008-11-25 11:47 ` Rusty Russell
2008-11-25 12:36   ` Christian Borntraeger
2008-11-27  8:11     ` Rusty Russell
2008-12-29  8:12 Stephen Rothwell
2008-12-29 15:23 ` Mike Travis
2008-12-29 21:01 ` Rusty Russell
2009-01-06  3:41 Stephen Rothwell
2009-01-07  3:04 Stephen Rothwell
2009-03-05  8:33 Stephen Rothwell
2009-03-06  5:23 ` Rusty Russell
2009-03-17  2:45 Stephen Rothwell
2009-06-09 10:12 Stephen Rothwell
2009-06-10  7:26 ` Rusty Russell
2009-06-10  8:11   ` Stephen Rothwell
2009-06-11  9:07 Stephen Rothwell
2009-06-11 13:08 ` Rusty Russell
2009-06-15  6:40 Stephen Rothwell
2009-06-15  7:26 ` Stephen Rothwell
2009-06-15  8:52   ` David Miller
2009-06-15 10:39 ` Rusty Russell
2009-06-23  6:14 Stephen Rothwell
2009-06-24  3:24 ` Rusty Russell
2009-06-24  6:31   ` Stephen Rothwell
2009-08-03  3:32 Stephen Rothwell
2009-08-03 17:55 ` Bjorn Helgaas
2009-08-03 20:22 ` Bjorn Helgaas
2009-08-03 23:18   ` Rusty Russell
2009-08-10  3:55     ` Stephen Rothwell
2009-08-10  3:56       ` Stephen Rothwell
2009-09-09  3:47 Stephen Rothwell
2009-09-09 14:32 ` Siarhei Liakh
2009-09-11  3:00 ` Siarhei Liakh
2009-09-15  3:27 ` Stephen Rothwell
2009-09-22  5:15   ` Rusty Russell
2009-11-11  3:01 Stephen Rothwell
2009-11-11  8:33 ` Rusty Russell
2009-11-12  7:48 Stephen Rothwell
2009-11-12  8:03 Stephen Rothwell
2009-11-12  9:02 ` Benjamin Herrenschmidt
2009-11-12 10:50   ` Stephen Rothwell
2009-12-11  1:26 Stephen Rothwell
2009-12-14  4:35 ` Stephen Rothwell
2009-12-15  3:52   ` Rusty Russell
2009-12-15  4:36     ` Stephen Rothwell
2009-12-17 22:05     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625164448.fdb43e57.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=rusty@rustcorp$(echo .)com.au \
    --cc=vda.linux@googlemail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox