From: Siarhei Liakh <sliakh.lkml@gmail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Rusty Russell <rusty@rustcorp•com.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Xuxian Jiang <jiang@cs•ncsu.edu>,
Arjan van de Ven <arjan@linux•intel.com>
Subject: Re: linux-next: rr tree build failure
Date: Thu, 10 Sep 2009 23:00:38 -0400 [thread overview]
Message-ID: <817ecb6f0909102000n4b3308cayd242cb329fcedde3@mail.gmail.com> (raw)
In-Reply-To: <20090909134752.f5b8c2e7.sfr@canb.auug.org.au>
On Tue, Sep 8, 2009 at 11:47 PM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi Rusty,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> kernel/module.c: In function 'set_section_ro_nx':
> kernel/module.c:1549: error: implicit declaration of function 'set_memory_ro'
> kernel/module.c:1560: error: implicit declaration of function 'set_memory_nx'
> kernel/module.c: In function 'unset_section_ro_nx':
> kernel/module.c:1575: error: implicit declaration of function 'set_memory_rw'
>
> Caused by commit 25306e21864c2a220d6fa2e0632425028aa9626c
> ("module:ro-nx-protection") which uses these interfaces that are only
> defined on x86 ...
>
> I have used the version of the rr tree from next-20090908 for today.
I have posted a replacement patch for that commit: "[PATCH v6] RO/NX
protection for loadable kernel modules"
Please let me know if you would rather see a short "patch patch"
rather than complete patch replacement. The fix, essentially, is to
encapsulate entire bodies of unset_section_ro_nx() and
set_section_ro_nx() inside #ifdef CONFIG_X86 ... #endif. This way
set_memory_* will be called only on x86.
Thanks.
next prev parent reply other threads:[~2009-09-11 3:00 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 3:47 linux-next: rr tree build failure Stephen Rothwell
2009-09-09 14:32 ` Siarhei Liakh
2009-09-11 3:00 ` Siarhei Liakh [this message]
2009-09-15 3:27 ` Stephen Rothwell
2009-09-22 5:15 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2009-12-11 1:26 Stephen Rothwell
2009-12-14 4:35 ` Stephen Rothwell
2009-12-15 3:52 ` Rusty Russell
2009-12-15 4:36 ` Stephen Rothwell
2009-12-17 22:05 ` Stephen Rothwell
2009-11-12 8:03 Stephen Rothwell
2009-11-12 9:02 ` Benjamin Herrenschmidt
2009-11-12 10:50 ` Stephen Rothwell
2009-11-12 7:48 Stephen Rothwell
2009-11-11 3:01 Stephen Rothwell
2009-11-11 8:33 ` Rusty Russell
2009-08-03 3:32 Stephen Rothwell
2009-08-03 17:55 ` Bjorn Helgaas
2009-08-03 20:22 ` Bjorn Helgaas
2009-08-03 23:18 ` Rusty Russell
2009-08-10 3:55 ` Stephen Rothwell
2009-08-10 3:56 ` Stephen Rothwell
2009-06-23 6:14 Stephen Rothwell
2009-06-24 3:24 ` Rusty Russell
2009-06-24 6:31 ` Stephen Rothwell
2009-06-15 6:40 Stephen Rothwell
2009-06-15 7:26 ` Stephen Rothwell
2009-06-15 8:52 ` David Miller
2009-06-15 10:39 ` Rusty Russell
2009-06-11 9:07 Stephen Rothwell
2009-06-11 13:08 ` Rusty Russell
2009-06-09 10:12 Stephen Rothwell
2009-06-10 7:26 ` Rusty Russell
2009-06-10 8:11 ` Stephen Rothwell
2009-03-17 2:45 Stephen Rothwell
2009-03-05 8:33 Stephen Rothwell
2009-03-06 5:23 ` Rusty Russell
2009-01-07 3:04 Stephen Rothwell
2009-01-06 3:41 Stephen Rothwell
2008-12-29 8:12 Stephen Rothwell
2008-12-29 15:23 ` Mike Travis
2008-12-29 21:01 ` Rusty Russell
2008-11-25 6:45 Stephen Rothwell
2008-11-25 11:47 ` Rusty Russell
2008-11-25 12:36 ` Christian Borntraeger
2008-11-27 8:11 ` Rusty Russell
2008-11-24 3:31 Stephen Rothwell
2008-11-24 17:07 ` Rusty Russell
2008-11-21 3:19 Stephen Rothwell
2008-11-21 10:58 ` Rusty Russell
2008-11-21 18:34 ` Greg KH
2008-11-20 3:50 Stephen Rothwell
2008-10-23 4:52 Stephen Rothwell
2008-10-23 13:31 ` Rusty Russell
2008-10-23 4:51 Stephen Rothwell
2008-10-23 13:02 ` Rusty Russell
2008-06-26 6:50 Stephen Rothwell
2008-06-26 7:49 ` Christian Borntraeger
2008-06-27 3:15 ` Rusty Russell
2008-06-25 6:58 Stephen Rothwell
2008-06-25 7:35 ` Christian Borntraeger
2008-06-25 8:30 ` Rusty Russell
2008-06-25 9:08 ` Christian Borntraeger
2008-06-25 6:44 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817ecb6f0909102000n4b3308cayd242cb329fcedde3@mail.gmail.com \
--to=sliakh.lkml@gmail$(echo .)com \
--cc=arjan@linux$(echo .)intel.com \
--cc=jiang@cs$(echo .)ncsu.edu \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox