public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
	Rusty Russell <rusty@rustcorp•com.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Len Brown <len.brown@intel•com>
Subject: Re: linux-next: rr tree build failure
Date: Mon, 3 Aug 2009 14:22:27 -0600	[thread overview]
Message-ID: <200908031422.28171.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20090803133203.81174a8e.sfr@canb.auug.org.au>

On Sunday 02 August 2009 09:32:03 pm Stephen Rothwell wrote:
> Hi Rusty,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/acpi/osl.c: In function 'bind_to_cpu0':
> drivers/acpi/osl.c:194: error: implicit declaration of function 'set_cpus_allowed'
> 
> Caused by commit 74b5820808215f65b70b05a099d6d3c969b82689 ("ACPI: bind
> workqueues to CPU 0 to avoid SMI corruption") (from the acpi tree but now
> in Linus' tree) interacting with commit
> 17e249fb40c814a72f08c1356cb47ec9f87f81a8
> ("cpumask:remove-set_cpus_allowed") from the rr tree.
> 
> I have reverted that rr tree commit for today.

Here's a patch to fix this.  Since Linus' tree still contains instances
of set_cpus_allowed(), I'm guessing this patch should be added to the rr
tree?

Bjorn



ACPI: remove cpumask_t usage

set_cpus_allowed() is on the way out; replace it with
set_cpus_allowed_ptr().

Reference: http://lkml.org/lkml/2008/11/6/448

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp•com>
CC: Rusty Russell <rusty@rustcorp•com.au>

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 5691f16..e196a75 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -191,7 +191,7 @@ acpi_status __init acpi_os_initialize(void)
 
 static void bind_to_cpu0(struct work_struct *work)
 {
-	set_cpus_allowed(current, cpumask_of_cpu(0));
+	set_cpus_allowed_ptr(current, cpumask_of(0));
 	kfree(work);
 }
 

  parent reply	other threads:[~2009-08-03 20:22 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03  3:32 linux-next: rr tree build failure Stephen Rothwell
2009-08-03 17:55 ` Bjorn Helgaas
2009-08-03 20:22 ` Bjorn Helgaas [this message]
2009-08-03 23:18   ` Rusty Russell
2009-08-10  3:55     ` Stephen Rothwell
2009-08-10  3:56       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2009-12-11  1:26 Stephen Rothwell
2009-12-14  4:35 ` Stephen Rothwell
2009-12-15  3:52   ` Rusty Russell
2009-12-15  4:36     ` Stephen Rothwell
2009-12-17 22:05     ` Stephen Rothwell
2009-11-12  8:03 Stephen Rothwell
2009-11-12  9:02 ` Benjamin Herrenschmidt
2009-11-12 10:50   ` Stephen Rothwell
2009-11-12  7:48 Stephen Rothwell
2009-11-11  3:01 Stephen Rothwell
2009-11-11  8:33 ` Rusty Russell
2009-09-09  3:47 Stephen Rothwell
2009-09-09 14:32 ` Siarhei Liakh
2009-09-11  3:00 ` Siarhei Liakh
2009-09-15  3:27 ` Stephen Rothwell
2009-09-22  5:15   ` Rusty Russell
2009-06-23  6:14 Stephen Rothwell
2009-06-24  3:24 ` Rusty Russell
2009-06-24  6:31   ` Stephen Rothwell
2009-06-15  6:40 Stephen Rothwell
2009-06-15  7:26 ` Stephen Rothwell
2009-06-15  8:52   ` David Miller
2009-06-15 10:39 ` Rusty Russell
2009-06-11  9:07 Stephen Rothwell
2009-06-11 13:08 ` Rusty Russell
2009-06-09 10:12 Stephen Rothwell
2009-06-10  7:26 ` Rusty Russell
2009-06-10  8:11   ` Stephen Rothwell
2009-03-17  2:45 Stephen Rothwell
2009-03-05  8:33 Stephen Rothwell
2009-03-06  5:23 ` Rusty Russell
2009-01-07  3:04 Stephen Rothwell
2009-01-06  3:41 Stephen Rothwell
2008-12-29  8:12 Stephen Rothwell
2008-12-29 15:23 ` Mike Travis
2008-12-29 21:01 ` Rusty Russell
2008-11-25  6:45 Stephen Rothwell
2008-11-25 11:47 ` Rusty Russell
2008-11-25 12:36   ` Christian Borntraeger
2008-11-27  8:11     ` Rusty Russell
2008-11-24  3:31 Stephen Rothwell
2008-11-24 17:07 ` Rusty Russell
2008-11-21  3:19 Stephen Rothwell
2008-11-21 10:58 ` Rusty Russell
2008-11-21 18:34   ` Greg KH
2008-11-20  3:50 Stephen Rothwell
2008-10-23  4:52 Stephen Rothwell
2008-10-23 13:31 ` Rusty Russell
2008-10-23  4:51 Stephen Rothwell
2008-10-23 13:02 ` Rusty Russell
2008-06-26  6:50 Stephen Rothwell
2008-06-26  7:49 ` Christian Borntraeger
2008-06-27  3:15   ` Rusty Russell
2008-06-25  6:58 Stephen Rothwell
2008-06-25  7:35 ` Christian Borntraeger
2008-06-25  8:30   ` Rusty Russell
2008-06-25  9:08     ` Christian Borntraeger
2008-06-25  6:44 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908031422.28171.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp$(echo .)com \
    --cc=len.brown@intel$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=rusty@rustcorp$(echo .)com.au \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox