From: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@elte•hu>, "H. Peter Anvin" <hpa@zytor•com>
Subject: Re: linux-next: rcu build warnings
Date: Fri, 29 Aug 2008 07:42:00 -0700 [thread overview]
Message-ID: <20080829144200.GB6725@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080829191948.95cde73f.sfr@canb.auug.org.au>
On Fri, Aug 29, 2008 at 07:19:48PM +1000, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit cd95851785bcfe95fdf73689e8ecb5a1c5959231 ("rcu: fix classic RCU
> locking cleanup lockdep problem") from the sched tree used a long
> (instead of unsigned long) for the flags argument to
> spin_lock_irqsave/restore producing these warnings:
>
> kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
> kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
> kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast
Hello, Steve,
Commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4 from linux-2.6-tip in the
tip/core/rcu section addresses this problem. Please accept my apologies
for the hassle!!!
Thanx, Paul
commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4
Author: Hiroshi Shimamoto <h-shimamoto@ct•jp.nec.com>
Date: Mon Aug 18 14:39:21 2008 -0700
rcuclassic: fix compiler warning
CC kernel/rcuclassic.o
kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
kernel/rcuclassic.c:705: warning: comparison of distinct pointer
types lacks
kernel/rcuclassic.c:713: warning: comparison of distinct pointer
types lacks
flags should be unsigned long.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct•jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte•hu>
next prev parent reply other threads:[~2008-08-29 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 9:19 linux-next: rcu build warnings Stephen Rothwell
2008-08-29 14:42 ` Paul E. McKenney [this message]
2008-08-30 5:44 ` Stephen Rothwell
2008-08-30 14:38 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829144200.GB6725@linux.vnet.ibm.com \
--to=paulmck@linux$(echo .)vnet.ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox