* linux-next: rcu build warnings
@ 2008-08-29 9:19 Stephen Rothwell
2008-08-29 14:42 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2008-08-29 9:19 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: linux-next, Thomas Gleixner, Ingo Molnar, H. Peter Anvin
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
Hi Paul,
Commit cd95851785bcfe95fdf73689e8ecb5a1c5959231 ("rcu: fix classic RCU
locking cleanup lockdep problem") from the sched tree used a long
(instead of unsigned long) for the flags argument to
spin_lock_irqsave/restore producing these warnings:
kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: rcu build warnings
2008-08-29 9:19 linux-next: rcu build warnings Stephen Rothwell
@ 2008-08-29 14:42 ` Paul E. McKenney
2008-08-30 5:44 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2008-08-29 14:42 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Thomas Gleixner, Ingo Molnar, H. Peter Anvin
On Fri, Aug 29, 2008 at 07:19:48PM +1000, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit cd95851785bcfe95fdf73689e8ecb5a1c5959231 ("rcu: fix classic RCU
> locking cleanup lockdep problem") from the sched tree used a long
> (instead of unsigned long) for the flags argument to
> spin_lock_irqsave/restore producing these warnings:
>
> kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
> kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
> kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast
Hello, Steve,
Commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4 from linux-2.6-tip in the
tip/core/rcu section addresses this problem. Please accept my apologies
for the hassle!!!
Thanx, Paul
commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4
Author: Hiroshi Shimamoto <h-shimamoto@ct•jp.nec.com>
Date: Mon Aug 18 14:39:21 2008 -0700
rcuclassic: fix compiler warning
CC kernel/rcuclassic.o
kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
kernel/rcuclassic.c:705: warning: comparison of distinct pointer
types lacks
kernel/rcuclassic.c:713: warning: comparison of distinct pointer
types lacks
flags should be unsigned long.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct•jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte•hu>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: rcu build warnings
2008-08-29 14:42 ` Paul E. McKenney
@ 2008-08-30 5:44 ` Stephen Rothwell
2008-08-30 14:38 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2008-08-30 5:44 UTC (permalink / raw)
To: paulmck; +Cc: linux-next, Thomas Gleixner, Ingo Molnar, H. Peter Anvin
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Hi Paul,
On Fri, 29 Aug 2008 07:42:00 -0700 "Paul E. McKenney" <paulmck@linux•vnet.ibm.com> wrote:
>
> Commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4 from linux-2.6-tip in the
> tip/core/rcu section addresses this problem. Please accept my apologies
> for the hassle!!!
Not a real hassle, I just point out warnings from my builds to people
when I get bored. :-)
I assume that patch will make it into linux-next at some point.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: rcu build warnings
2008-08-30 5:44 ` Stephen Rothwell
@ 2008-08-30 14:38 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2008-08-30 14:38 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Thomas Gleixner, Ingo Molnar, H. Peter Anvin
On Sat, Aug 30, 2008 at 03:44:11PM +1000, Stephen Rothwell wrote:
> Hi Paul,
>
> On Fri, 29 Aug 2008 07:42:00 -0700 "Paul E. McKenney" <paulmck@linux•vnet.ibm.com> wrote:
> >
> > Commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4 from linux-2.6-tip in the
> > tip/core/rcu section addresses this problem. Please accept my apologies
> > for the hassle!!!
>
> Not a real hassle, I just point out warnings from my builds to people
> when I get bored. :-)
>
> I assume that patch will make it into linux-next at some point.
Might be a good time to move it ahead. ;-)
Hmmm... Should I ask the git developers about some way of marking
commits as being interdependent? "Don't take commit #1 unless you also
take commit #2?"
Thanx, Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-30 14:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-29 9:19 linux-next: rcu build warnings Stephen Rothwell
2008-08-29 14:42 ` Paul E. McKenney
2008-08-30 5:44 ` Stephen Rothwell
2008-08-30 14:38 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox