* linux-next: i2c tree build warning
@ 2009-11-26 3:06 Stephen Rothwell
2009-11-26 8:18 ` Jean Delvare
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2009-11-26 3:06 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-next, linux-kernel, Wolfram Sang
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
Hi Jean,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/misc/eeprom/at24.c: In function 'at24_eeprom_read':
drivers/misc/eeprom/at24.c:230: warning: format '%zd' expects type 'signed size_t', but argument 6 has type 'int'
Introduced by commit 39bfab2519e6f148f2508d719f9fc5f4581aeefd ("at24: Use
timeout also for read").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: i2c tree build warning 2009-11-26 3:06 linux-next: i2c tree build warning Stephen Rothwell @ 2009-11-26 8:18 ` Jean Delvare 2009-11-26 8:50 ` Stephen Rothwell 2009-11-26 10:50 ` Wolfram Sang 0 siblings, 2 replies; 4+ messages in thread From: Jean Delvare @ 2009-11-26 8:18 UTC (permalink / raw) To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Wolfram Sang Hi Stephen, On Thu, 26 Nov 2009 14:06:00 +1100, Stephen Rothwell wrote: > Today's linux-next build (x86_64 allmodconfig) produced this warning: > > drivers/misc/eeprom/at24.c: In function 'at24_eeprom_read': > drivers/misc/eeprom/at24.c:230: warning: format '%zd' expects type 'signed size_t', but argument 6 has type 'int' > > Introduced by commit 39bfab2519e6f148f2508d719f9fc5f4581aeefd ("at24: Use > timeout also for read"). Thanks for reporting. The warning did not show on my 32-bit x86 system, and I guess it did not show on Wolfram's system either, otherwise we'd have fixed it. Does the following patch fix the warning for you? --- linux-2.6.32-rc8.orig/drivers/misc/eeprom/at24.c 2009-11-26 09:14:45.000000000 +0100 +++ linux-2.6.32-rc8/drivers/misc/eeprom/at24.c 2009-11-26 09:14:15.000000000 +0100 @@ -227,7 +227,7 @@ static ssize_t at24_eeprom_read(struct a if (status == 2) status = count; } - dev_dbg(&client->dev, "read %zu@%d --> %zd (%ld)\n", + dev_dbg(&client->dev, "read %zu@%d --> %d (%ld)\n", count, offset, status, jiffies); if (status == count) If it does then I'll merge this into Wolfram's patch. Thanks, -- Jean Delvare ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: i2c tree build warning 2009-11-26 8:18 ` Jean Delvare @ 2009-11-26 8:50 ` Stephen Rothwell 2009-11-26 10:50 ` Wolfram Sang 1 sibling, 0 replies; 4+ messages in thread From: Stephen Rothwell @ 2009-11-26 8:50 UTC (permalink / raw) To: Jean Delvare; +Cc: linux-next, linux-kernel, Wolfram Sang [-- Attachment #1: Type: text/plain, Size: 433 bytes --] Hi Jean, On Thu, 26 Nov 2009 09:18:29 +0100 Jean Delvare <khali@linux-fr•org> wrote: > > Thanks for reporting. The warning did not show on my 32-bit x86 system, > and I guess it did not show on Wolfram's system either, otherwise we'd > have fixed it. > > Does the following patch fix the warning for you? Yes. -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: i2c tree build warning 2009-11-26 8:18 ` Jean Delvare 2009-11-26 8:50 ` Stephen Rothwell @ 2009-11-26 10:50 ` Wolfram Sang 1 sibling, 0 replies; 4+ messages in thread From: Wolfram Sang @ 2009-11-26 10:50 UTC (permalink / raw) To: Jean Delvare; +Cc: Stephen Rothwell, linux-next, linux-kernel [-- Attachment #1: Type: text/plain, Size: 526 bytes --] > Thanks for reporting. The warning did not show on my 32-bit x86 system, > and I guess it did not show on Wolfram's system either, otherwise we'd > have fixed it. Yes, I tested it on a few embedded boards which are all 32-bit. Will try to get a 64-bit machine into my test-process. Sorry for this! Thank you Stephen for reporting and Jean for helping out! -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-26 10:51 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-11-26 3:06 linux-next: i2c tree build warning Stephen Rothwell 2009-11-26 8:18 ` Jean Delvare 2009-11-26 8:50 ` Stephen Rothwell 2009-11-26 10:50 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox