From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Ingo Molnar <mingo@elte•hu>, Andrew Morton <akpm@linux-foundation•org>
Cc: Ananth N Mavinakayanahalli <ananth@in•ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello•nl>,
Peter Zijlstra <peterz@infradead•org>,
Fr??d??ric Weisbecker <fweisbec@gmail•com>,
LKML <linux-kernel@vger•kernel.org>,
Steven Rostedt <rostedt@goodmis•org>,
Arnaldo Carvalho de Melo <acme@redhat•com>,
"Frank Ch. Eigler" <fche@redhat•com>,
linux-next@vger•kernel.org, "H. Peter Anvin" <hpa@zytor•com>,
utrace-devel@redhat•com, Thomas Gleixner <tglx@linutronix•de>,
Linus <torvalds@linux-foundation•org>
Subject: Re: linux-next: add utrace tree
Date: Fri, 22 Jan 2010 11:17:47 +1100 [thread overview]
Message-ID: <20100122111747.3c224dfd.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20100121013822.28781960.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 4369 bytes --]
Hi Ingo, Andrew,
Any thoughts?
On Thu, 21 Jan 2010 01:38:22 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> On Wed, 20 Jan 2010 08:29:25 +0100 Ingo Molnar <mingo@elte•hu> wrote:
> >
> >
> > * Ingo Molnar <mingo@elte•hu> wrote:
> >
> > >
> > > * Ananth N Mavinakayanahalli <ananth@in•ibm.com> wrote:
> > >
> > > > On Wed, Jan 20, 2010 at 06:49:50AM +0100, Ingo Molnar wrote:
> > > >
> > > > Ingo,
> > > >
> > > > > Note, i'm not yet convinced that this (and the rest: uprobes and systemtap,
> > > > > etc.) can go uptream in its present form.
> > > >
> > > > Agreed, uprobes is still not upstream ready -- it was an RFC. We are
> > > > working through the comments there to get it ready for merger.
> > > >
> > > > > IMHO the far more important thing to address beyond formalities and workflow
> > > > > cleanliness are the (many) technical observations and objections offered by
> > > > > Peter Zijstra on lkml. Not just the git history but also the abstractions and
> > > > > concepts are messy and should be reworked IMO, and also good and working perf
> > > > > events integration should be achieved, etc.
> > > >
> > > > I think Oleg addressed most of Peter's concerns on utrace when the
> > > > ptrace/utrace patchset was reposted.
> > >
> > > Peter is Cc:-ed and he might want to chime in.
> > >
> > > > Perf integration with uprobes will be done and discussions have started with
> > > > Masami and Frederic. There are a couple of fundamental technical aspects
> > > > (XOL vma vs. emulation; breakpoint insertion through CoW and not through
> > > > quiesce) that need resolution.
> > > >
> > > > > The fact that there's a well established upstream workflow for instrumentation
> > > > > patches, which is being routed around by the utrace/uprobes/systemtap code
> > > > > here is not a good sign in terms of reaching a good upstream solution. Lets
> > > > > hope it works out well though.
> > > >
> > > > Agreed.
> > > >
> > > > On the other hand, having ptrace/utrace in the -next tree will give it a
> > > > lot more testing, while any outstanding technical issues are being addressed.
> > >
> > > Including experimental code that is RFC and which is not certain to go
> > > upstream is certainly not the purpose of linux-next though.
> > >
> > > It will cause conflicts with various other trees and increases the overhead
> > > all around. It also causes us to trust linux-next bugreports less - as it's
> > > not the 'next Linux' anymore. Also, there's virtually no high-level
> > > technical review done in linux-next: the trees are implicitly trusted
> > > (because they are pushed by maintainers), bugs and conflicts are reported
> > > but otherwise it's a neutral tree that includes pretty much any commit
> > > indiscriminately.
> > >
> > > If you need review and testing there's a number of trees you can get
> > > inclusion into.
> >
> > Btw., the utrace code has lived in -mm for quite some time - that's an
> > excellent route as Andrew does thorough review and testing.
> >
> > If Andrew agrees with this particular tree as-is and wants these bits to live
> > in linux-next and have it in -mm that way then that's a fair approach
> > obviously and i have no objections ...
>
> So, what is it to be? In or out?
>
> Frank, please be clear as to which branch you want included (master or
> utrace-ptrace). Also note that neither of those branches matches what
> was posted in the sense that they both have lots of history and merges
> not represented in the patches. (I assume that they do produce the same
> final source tree, though).
>
> > The point is to have at least one relevant maintainer request and track it and
> > then supervise the completion of it (which includes the resolution of all
> > outstanding objections) and then push it to Linus.
>
> If we do include it, it is still possible for people to decide (when the
> next merge window opens) that it is still not ready. It adds a bit of
> maybe unneeded complication to linux-next, but we had the same problem in
> this merge window and we have all survived. :-)
>
> In the end, Linus is the final arbitrator of course.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-01-22 0:17 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100119211646.GF16096@redhat.com>
2010-01-20 0:12 ` linux-next: add utrace tree Stephen Rothwell
2010-01-20 5:49 ` Ingo Molnar
2010-01-20 6:15 ` Ananth N Mavinakayanahalli
2010-01-20 6:28 ` Ingo Molnar
2010-01-20 6:40 ` Ananth N Mavinakayanahalli
2010-01-20 10:43 ` Frederic Weisbecker
2010-01-20 6:59 ` Stephen Rothwell
2010-01-20 13:24 ` Frank Ch. Eigler
2010-01-20 7:29 ` Ingo Molnar
2010-01-20 14:38 ` Stephen Rothwell
2010-01-21 1:22 ` Roland McGrath
2010-01-22 0:17 ` Stephen Rothwell [this message]
2010-01-22 0:30 ` Andrew Morton
2010-01-22 0:31 ` Andrew Morton
2010-01-22 0:51 ` Frank Ch. Eigler
2010-01-22 1:05 ` Andrew Morton
2010-01-22 1:25 ` Frank Ch. Eigler
2010-01-22 1:32 ` Linus Torvalds
2010-01-22 2:22 ` Frank Ch. Eigler
2010-01-22 2:35 ` Linus Torvalds
2010-01-22 20:51 ` Oleg Nesterov
2010-01-23 6:04 ` Ingo Molnar
2010-01-23 12:03 ` Frank Ch. Eigler
2010-01-24 16:36 ` Thomas Gleixner
2010-01-22 1:28 ` Linus Torvalds
2010-01-22 5:21 ` Ananth N Mavinakayanahalli
2010-01-22 13:43 ` Valdis.Kletnieks
2010-01-22 19:39 ` Oleg Nesterov
2010-01-26 13:58 ` Pavel Machek
2010-01-22 18:28 ` Oleg Nesterov
2010-01-22 20:01 ` Frank Ch. Eigler
2010-01-22 20:16 ` Peter Zijlstra
2010-01-22 21:44 ` Frank Ch. Eigler
2010-01-22 21:59 ` Linus Torvalds
2010-01-22 22:13 ` Frank Ch. Eigler
2010-01-23 0:11 ` Linus Torvalds
2010-01-23 0:22 ` Linus Torvalds
2010-01-23 6:20 ` Kyle Moffett
2010-01-23 11:01 ` Alan Cox
2010-01-23 11:51 ` Frank Ch. Eigler
2010-01-23 15:57 ` Arnaldo Carvalho de Melo
2010-01-23 11:23 ` Ingo Molnar
2010-01-23 11:47 ` Frank Ch. Eigler
2010-01-23 19:48 ` tytso
2010-01-24 18:01 ` Frank Ch. Eigler
2010-01-25 1:42 ` Kyle Moffett
2010-01-25 4:55 ` tytso
2010-01-25 16:52 ` Linus Torvalds
2010-01-25 17:02 ` Frank Ch. Eigler
2010-01-25 17:36 ` Linus Torvalds
2010-01-25 17:45 ` Linus Torvalds
2010-01-25 17:54 ` Steven Rostedt
2010-01-25 18:03 ` Alan Cox
2010-01-25 18:12 ` Linus Torvalds
2010-01-25 18:30 ` Steven Rostedt
2010-01-25 18:45 ` Thomas Gleixner
2010-01-25 20:34 ` Ingo Molnar
2010-01-25 20:30 ` Mark Wielaard
2010-01-25 20:42 ` Linus Torvalds
2010-01-26 0:02 ` Renzo Davoli
2010-01-26 0:07 ` Linus Torvalds
2010-01-26 16:08 ` Johannes Stezenbach
2010-01-26 16:28 ` Linus Torvalds
2010-01-26 16:34 ` Christoph Hellwig
2010-01-28 23:53 ` Benjamin Herrenschmidt
2010-01-29 0:21 ` Linus Torvalds
2010-01-25 4:59 ` Ananth N Mavinakayanahalli
2010-01-25 10:13 ` Peter Zijlstra
2010-01-24 5:04 ` Linus Torvalds
2010-01-24 10:25 ` tytso
2010-01-24 13:20 ` Frank Ch. Eigler
2010-01-25 21:05 ` Tom Tromey
2010-01-25 21:41 ` Linus Torvalds
2010-01-26 14:21 ` Ananth N Mavinakayanahalli
2010-01-26 23:20 ` Tom Tromey
2010-01-26 23:37 ` Linus Torvalds
2010-01-27 6:52 ` Peter Zijlstra
2010-01-27 8:54 ` Ingo Molnar
2010-01-28 1:52 ` Jim Keniston
2010-01-28 8:55 ` Ingo Molnar
2010-01-29 0:59 ` Jim Keniston
2010-01-29 7:39 ` Ingo Molnar
2010-01-29 7:52 ` Ananth N Mavinakayanahalli
2010-01-29 7:55 ` Ananth N Mavinakayanahalli
2010-01-29 9:16 ` Ingo Molnar
2010-01-29 9:11 ` Ingo Molnar
2010-01-29 9:31 ` Ananth N Mavinakayanahalli
2010-01-29 9:51 ` Ingo Molnar
2010-01-29 18:13 ` Frank Ch. Eigler
2010-01-29 4:55 ` Ananth N Mavinakayanahalli
2010-01-29 7:42 ` Ingo Molnar
2010-01-30 17:49 ` Steven Rostedt
2010-01-30 17:59 ` Linus Torvalds
2010-02-02 6:47 ` Masami Hiramatsu
2010-01-27 10:43 ` Linus Torvalds
2010-01-27 10:55 ` Peter Zijlstra
2010-01-27 10:58 ` Peter Zijlstra
2010-01-27 11:04 ` Linus Torvalds
2010-01-27 16:01 ` Frederic Weisbecker
2010-01-27 11:05 ` Ananth N Mavinakayanahalli
2010-01-27 11:08 ` Peter Zijlstra
2010-01-27 11:20 ` Ananth N Mavinakayanahalli
2010-02-08 10:09 ` Avi Kivity
2010-01-27 11:07 ` Srikar Dronamraju
2010-01-27 13:59 ` Steven Rostedt
2010-01-27 17:42 ` H. Peter Anvin
2010-01-27 18:53 ` Steven Rostedt
2010-02-08 6:54 ` Pavel Machek
2010-02-08 9:30 ` H. Peter Anvin
2010-02-08 9:53 ` Arjan van de Ven
2010-01-27 19:18 ` H. Peter Anvin
2010-01-27 0:38 ` Frank Ch. Eigler
2010-01-26 15:00 ` Frank Ch. Eigler
2010-01-26 17:33 ` Andi Kleen
2010-01-26 18:46 ` Linus Torvalds
2010-01-26 21:02 ` Andi Kleen
2010-01-26 21:53 ` Oleg Nesterov
2010-01-26 22:03 ` Andi Kleen
2010-01-26 23:32 ` Oleg Nesterov
2010-01-26 21:30 ` Oleg Nesterov
2010-01-26 23:27 ` Tom Tromey
2010-01-23 8:05 ` Alexey Dobriyan
2010-01-22 17:45 ` Oleg Nesterov
2010-01-20 8:52 ` Peter Zijlstra
2010-01-20 13:01 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100122111747.3c224dfd.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=acme@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ananth@in$(echo .)ibm.com \
--cc=fche@redhat$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=utrace-devel@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox