* linux-next: build failure after merge of the final tree (hwpoison tree related)
@ 2010-09-27 5:55 Stephen Rothwell
2010-09-29 2:57 ` Stephen Rothwell
2010-09-30 2:54 ` Naoya Horiguchi
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2010-09-27 5:55 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-next, linux-kernel, Naoya Horiguchi, Jun'ichi Nomura
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
Hi Andi,
After merging the final tree, today's linux-next build (powerpc allnoconfig)
failed like this:
mm/mprotect.o: In function `migrate_huge_page_move_mapping':
mprotect.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping'
mm/shmem.o:shmem.c:(.text+0x0): first defined here
mm/rmap.o: In function `migrate_huge_page_move_mapping':
rmap.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping'
mm/shmem.o:shmem.c:(.text+0x0): first defined here
Caused by commit 7b217c52ce7f33379beb27aa7685109fa74ed6bf ("hugetlb:
hugepage migration core").
This function is declared as "extern int ..." with a body in
include/linux/migrate.h for the non CONFIG_MIGRATION case.
I reverted the whole hwpoison tree for today.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the final tree (hwpoison tree related) 2010-09-27 5:55 linux-next: build failure after merge of the final tree (hwpoison tree related) Stephen Rothwell @ 2010-09-29 2:57 ` Stephen Rothwell 2010-10-03 23:36 ` Stephen Rothwell 2010-09-30 2:54 ` Naoya Horiguchi 1 sibling, 1 reply; 4+ messages in thread From: Stephen Rothwell @ 2010-09-29 2:57 UTC (permalink / raw) To: Andi Kleen; +Cc: linux-next, linux-kernel, Naoya Horiguchi, Jun'ichi Nomura [-- Attachment #1: Type: text/plain, Size: 1083 bytes --] Hi Andi, On Mon, 27 Sep 2010 15:55:51 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote: > > After merging the final tree, today's linux-next build (powerpc allnoconfig) > failed like this: > > mm/mprotect.o: In function `migrate_huge_page_move_mapping': > mprotect.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' > mm/shmem.o:shmem.c:(.text+0x0): first defined here > mm/rmap.o: In function `migrate_huge_page_move_mapping': > rmap.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' > mm/shmem.o:shmem.c:(.text+0x0): first defined here > > Caused by commit 7b217c52ce7f33379beb27aa7685109fa74ed6bf ("hugetlb: > hugepage migration core"). > > This function is declared as "extern int ..." with a body in > include/linux/migrate.h for the non CONFIG_MIGRATION case. > > I reverted the whole hwpoison tree for today. This is still not fixed ... so I am still using the hwpoison tree from next-20100924. -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the final tree (hwpoison tree related) 2010-09-29 2:57 ` Stephen Rothwell @ 2010-10-03 23:36 ` Stephen Rothwell 0 siblings, 0 replies; 4+ messages in thread From: Stephen Rothwell @ 2010-10-03 23:36 UTC (permalink / raw) To: Andi Kleen; +Cc: linux-next, linux-kernel, Naoya Horiguchi, Jun'ichi Nomura [-- Attachment #1: Type: text/plain, Size: 1222 bytes --] Hi Andi, On Wed, 29 Sep 2010 12:57:56 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote: > > On Mon, 27 Sep 2010 15:55:51 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote: > > > > After merging the final tree, today's linux-next build (powerpc allnoconfig) > > failed like this: > > > > mm/mprotect.o: In function `migrate_huge_page_move_mapping': > > mprotect.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' > > mm/shmem.o:shmem.c:(.text+0x0): first defined here > > mm/rmap.o: In function `migrate_huge_page_move_mapping': > > rmap.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' > > mm/shmem.o:shmem.c:(.text+0x0): first defined here > > > > Caused by commit 7b217c52ce7f33379beb27aa7685109fa74ed6bf ("hugetlb: > > hugepage migration core"). > > > > This function is declared as "extern int ..." with a body in > > include/linux/migrate.h for the non CONFIG_MIGRATION case. > > > > I reverted the whole hwpoison tree for today. > > This is still not fixed ... so I am still using the hwpoison tree from > next-20100924. Ping? -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the final tree (hwpoison tree related) 2010-09-27 5:55 linux-next: build failure after merge of the final tree (hwpoison tree related) Stephen Rothwell 2010-09-29 2:57 ` Stephen Rothwell @ 2010-09-30 2:54 ` Naoya Horiguchi 1 sibling, 0 replies; 4+ messages in thread From: Naoya Horiguchi @ 2010-09-30 2:54 UTC (permalink / raw) To: Stephen Rothwell Cc: Andi Kleen, linux-next, linux-kernel, Jun'ichi Nomura Hi, On Mon, Sep 27, 2010 at 03:55:51PM +1000, Stephen Rothwell wrote: > Hi Andi, > > After merging the final tree, today's linux-next build (powerpc allnoconfig) > failed like this: > > mm/mprotect.o: In function `migrate_huge_page_move_mapping': > mprotect.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' > mm/shmem.o:shmem.c:(.text+0x0): first defined here > mm/rmap.o: In function `migrate_huge_page_move_mapping': > rmap.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' > mm/shmem.o:shmem.c:(.text+0x0): first defined here > > Caused by commit 7b217c52ce7f33379beb27aa7685109fa74ed6bf ("hugetlb: > hugepage migration core"). > > This function is declared as "extern int ..." with a body in > include/linux/migrate.h for the non CONFIG_MIGRATION case. This build error reappears for x86_64 with !CONFIG_MIGRATION. As you commented, "extern int" declaration causes it. So please apply the following patch. Thank you for reporting. Thanks, Naoya Horiguchi --- Date: Thu, 30 Sep 2010 09:56:02 +0900 Subject: [PATCH] fix build error with !CONFIG_MIGRATION migrate_huge_page_move_mapping() is declared as "extern int ..." in include/linux/migrate.h for !CONFIG_MIGRATION, which causes the build error like below: mm/mprotect.o: In function `migrate_huge_page_move_mapping': mprotect.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' mm/shmem.o:shmem.c:(.text+0x0): first defined here mm/rmap.o: In function `migrate_huge_page_move_mapping': rmap.c:(.text+0x0): multiple definition of `migrate_huge_page_move_mapping' mm/shmem.o:shmem.c:(.text+0x0): first defined here Reported-by: Stephen Rothwell <sfr@canb•auug.org.au> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah•jp.nec.com> --- include/linux/migrate.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index 3c1941e..085527f 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -50,7 +50,7 @@ static inline int migrate_vmas(struct mm_struct *mm, static inline void migrate_page_copy(struct page *newpage, struct page *page) {} -extern int migrate_huge_page_move_mapping(struct address_space *mapping, +static inline int migrate_huge_page_move_mapping(struct address_space *mapping, struct page *newpage, struct page *page) { return -ENOSYS; -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-03 23:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-09-27 5:55 linux-next: build failure after merge of the final tree (hwpoison tree related) Stephen Rothwell 2010-09-29 2:57 ` Stephen Rothwell 2010-10-03 23:36 ` Stephen Rothwell 2010-09-30 2:54 ` Naoya Horiguchi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox