public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
* linux-next: build warning after merge of the final tree
@ 2010-03-01  8:14 Stephen Rothwell
  0 siblings, 0 replies; 25+ messages in thread
From: Stephen Rothwell @ 2010-03-01  8:14 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Alan Cox

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc allnoconfig)
produced these warnings:

drivers/char/tty_buffer.c: In function 'tty_insert_flip_string_fixed_flag':
drivers/char/tty_buffer.c:251: warning: comparison of distinct pointer types lacks a cast
drivers/char/tty_buffer.c: In function 'tty_insert_flip_string_flags':
drivers/char/tty_buffer.c:288: warning: comparison of distinct pointer types lacks a cast

Introduced by commit 96a421002f897237bcc44efd909dd58aa759319c ("tty: Keep
the default buffering to sub-page units") from the tty tree.  Its just
the min macro parameters.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2010-05-26  5:15 Stephen Rothwell
  0 siblings, 0 replies; 25+ messages in thread
From: Stephen Rothwell @ 2010-05-26  5:15 UTC (permalink / raw)
  To: Roland Dreier, linux-rdma-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-next-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Linus, Ralph Campbell

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

Hi Roland,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/infiniband/hw/qib/qib_fs.c: In function 'portcntrs_2_read':
drivers/infiniband/hw/qib/qib_fs.c:203: warning: 'counters' is used uninitialized in this function
drivers/infiniband/hw/qib/qib_fs.c: In function 'portcntrs_1_read':
drivers/infiniband/hw/qib/qib_fs.c:192: warning: 'counters' is used uninitialized in this function
drivers/infiniband/hw/qib/qib_fs.c: In function 'portnames_read':
drivers/infiniband/hw/qib/qib_fs.c:181: warning: 'names' is used uninitialized in this function
drivers/infiniband/hw/qib/qib_fs.c: In function 'dev_names_read':
drivers/infiniband/hw/qib/qib_fs.c:160: warning: 'names' is used uninitialized in this function
drivers/infiniband/hw/qib/qib_fs.c: In function 'dev_counters_read':
drivers/infiniband/hw/qib/qib_fs.c:149: warning: 'counters' is used uninitialized in this function

Introduced by commit f931551bafe1f10ded7f5282e2aa162c267a2e5d ("IB/qib:
Add new qib driver for QLogic PCIe InfiniBand adapters").

-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2010-09-16  5:05 Stephen Rothwell
  2010-09-16  6:29 ` Jens Axboe
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2010-09-16  5:05 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-next, linux-kernel, Tejun Heo

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi Jens,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/aic7xxx_old.c: In function 'aic7xxx_buildscb':
drivers/scsi/aic7xxx_old.c:10122: warning: unused variable 'req'

Introduced by commit 9cbbdca44ae1a6f512ea1e2be11ced8bbb9d430a ("block:
remove spurious uses of REQ_HARDBARRIER").

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2010-09-16  5:05 Stephen Rothwell
@ 2010-09-16  6:29 ` Jens Axboe
  0 siblings, 0 replies; 25+ messages in thread
From: Jens Axboe @ 2010-09-16  6:29 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Tejun Heo

On 2010-09-16 07:05, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/scsi/aic7xxx_old.c: In function 'aic7xxx_buildscb':
> drivers/scsi/aic7xxx_old.c:10122: warning: unused variable 'req'
> 
> Introduced by commit 9cbbdca44ae1a6f512ea1e2be11ced8bbb9d430a ("block:
> remove spurious uses of REQ_HARDBARRIER").

Fixed that up, thanks.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2010-09-29  4:02 Stephen Rothwell
  2010-09-29  4:16 ` linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree) Stephen Rothwell
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2010-09-29  4:02 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: linux-next, linux-kernel, Pavel Emelyanov

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) produced tis warning:

WARNING: net/sunrpc/sunrpc.o(.init.text+0x110): Section mismatch in reference from the function init_sunrpc() to the function .exit.text:rpcauth_remove_module()
The function __init init_sunrpc() references
a function __exit rpcauth_remove_module().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __exit annotation of
rpcauth_remove_module() so it may be used outside an exit section.

Probably caused by commit 2f72c9b73730c335381b13e2bd221abe1acea394
("sunrpc: The per-net skeleton").
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree)
  2010-09-29  4:02 linux-next: build warning after merge of the final tree Stephen Rothwell
@ 2010-09-29  4:16 ` Stephen Rothwell
  2010-09-29 11:28   ` Pavel Emelyanov
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2010-09-29  4:16 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: linux-next, linux-kernel, Pavel Emelyanov

Hi all,

On Wed, 29 Sep 2010 14:02:38 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) produced tis warning:
> 
> WARNING: net/sunrpc/sunrpc.o(.init.text+0x110): Section mismatch in reference from the function init_sunrpc() to the function .exit.text:rpcauth_remove_module()
> The function __init init_sunrpc() references
> a function __exit rpcauth_remove_module().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> rpcauth_remove_module() so it may be used outside an exit section.
> 
> Probably caused by commit 2f72c9b73730c335381b13e2bd221abe1acea394
> ("sunrpc: The per-net skeleton").

This actually causes a build failure on a sparc32 defconfig build:

`rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Wed, 29 Sep 2010 14:07:07 +1000
Subject: [PATCH] sunrpc: fix up section mismatch

Fixes:

`rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 include/linux/sunrpc/auth.h |    4 ++--
 net/sunrpc/auth.c           |    2 +-
 net/sunrpc/auth_generic.c   |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/sunrpc/auth.h b/include/linux/sunrpc/auth.h
index 5bbc447..b202475 100644
--- a/include/linux/sunrpc/auth.h
+++ b/include/linux/sunrpc/auth.h
@@ -122,8 +122,8 @@ extern const struct rpc_authops	authnull_ops;
 int __init		rpc_init_authunix(void);
 int __init		rpc_init_generic_auth(void);
 int __init		rpcauth_init_module(void);
-void __exit		rpcauth_remove_module(void);
-void __exit		rpc_destroy_generic_auth(void);
+void			rpcauth_remove_module(void);
+void			rpc_destroy_generic_auth(void);
 void 			rpc_destroy_authunix(void);
 
 struct rpc_cred *	rpc_lookup_cred(void);
diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index e9eaaf7..2c0d9e6 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -658,7 +658,7 @@ out1:
 	return err;
 }
 
-void __exit rpcauth_remove_module(void)
+void rpcauth_remove_module(void)
 {
 	rpc_destroy_authunix();
 	rpc_destroy_generic_auth();
diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
index 43162bb..e010a01 100644
--- a/net/sunrpc/auth_generic.c
+++ b/net/sunrpc/auth_generic.c
@@ -158,7 +158,7 @@ int __init rpc_init_generic_auth(void)
 	return rpcauth_init_credcache(&generic_auth);
 }
 
-void __exit rpc_destroy_generic_auth(void)
+void rpc_destroy_generic_auth(void)
 {
 	rpcauth_destroy_credcache(&generic_auth);
 }
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree)
  2010-09-29  4:16 ` linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree) Stephen Rothwell
@ 2010-09-29 11:28   ` Pavel Emelyanov
  2010-09-29 16:30     ` J. Bruce Fields
  0 siblings, 1 reply; 25+ messages in thread
From: Pavel Emelyanov @ 2010-09-29 11:28 UTC (permalink / raw)
  To: Stephen Rothwell, J. Bruce Fields; +Cc: linux-next, linux-kernel

> This actually causes a build failure on a sparc32 defconfig build:
> 
> `rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> 
> I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Wed, 29 Sep 2010 14:07:07 +1000
> Subject: [PATCH] sunrpc: fix up section mismatch
> 
> Fixes:
> 
> `rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> 
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>

Oops :(

Acked-by: Pavel Emelyanov <xemul@openvz•org>

> ---
>  include/linux/sunrpc/auth.h |    4 ++--
>  net/sunrpc/auth.c           |    2 +-
>  net/sunrpc/auth_generic.c   |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/sunrpc/auth.h b/include/linux/sunrpc/auth.h
> index 5bbc447..b202475 100644
> --- a/include/linux/sunrpc/auth.h
> +++ b/include/linux/sunrpc/auth.h
> @@ -122,8 +122,8 @@ extern const struct rpc_authops	authnull_ops;
>  int __init		rpc_init_authunix(void);
>  int __init		rpc_init_generic_auth(void);
>  int __init		rpcauth_init_module(void);
> -void __exit		rpcauth_remove_module(void);
> -void __exit		rpc_destroy_generic_auth(void);
> +void			rpcauth_remove_module(void);
> +void			rpc_destroy_generic_auth(void);
>  void 			rpc_destroy_authunix(void);
>  
>  struct rpc_cred *	rpc_lookup_cred(void);
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index e9eaaf7..2c0d9e6 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -658,7 +658,7 @@ out1:
>  	return err;
>  }
>  
> -void __exit rpcauth_remove_module(void)
> +void rpcauth_remove_module(void)
>  {
>  	rpc_destroy_authunix();
>  	rpc_destroy_generic_auth();
> diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
> index 43162bb..e010a01 100644
> --- a/net/sunrpc/auth_generic.c
> +++ b/net/sunrpc/auth_generic.c
> @@ -158,7 +158,7 @@ int __init rpc_init_generic_auth(void)
>  	return rpcauth_init_credcache(&generic_auth);
>  }
>  
> -void __exit rpc_destroy_generic_auth(void)
> +void rpc_destroy_generic_auth(void)
>  {
>  	rpcauth_destroy_credcache(&generic_auth);
>  }

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree)
  2010-09-29 11:28   ` Pavel Emelyanov
@ 2010-09-29 16:30     ` J. Bruce Fields
  0 siblings, 0 replies; 25+ messages in thread
From: J. Bruce Fields @ 2010-09-29 16:30 UTC (permalink / raw)
  To: Pavel Emelyanov; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Wed, Sep 29, 2010 at 03:28:26PM +0400, Pavel Emelyanov wrote:
> > This actually causes a build failure on a sparc32 defconfig build:
> > 
> > `rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> > 
> > I applied the following patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb•auug.org.au>
> > Date: Wed, 29 Sep 2010 14:07:07 +1000
> > Subject: [PATCH] sunrpc: fix up section mismatch
> > 
> > Fixes:
> > 
> > `rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> 
> Oops :(
> 
> Acked-by: Pavel Emelyanov <xemul@openvz•org>

Thanks, applied, and I'll push that out soon.

--b.

> 
> > ---
> >  include/linux/sunrpc/auth.h |    4 ++--
> >  net/sunrpc/auth.c           |    2 +-
> >  net/sunrpc/auth_generic.c   |    2 +-
> >  3 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/include/linux/sunrpc/auth.h b/include/linux/sunrpc/auth.h
> > index 5bbc447..b202475 100644
> > --- a/include/linux/sunrpc/auth.h
> > +++ b/include/linux/sunrpc/auth.h
> > @@ -122,8 +122,8 @@ extern const struct rpc_authops	authnull_ops;
> >  int __init		rpc_init_authunix(void);
> >  int __init		rpc_init_generic_auth(void);
> >  int __init		rpcauth_init_module(void);
> > -void __exit		rpcauth_remove_module(void);
> > -void __exit		rpc_destroy_generic_auth(void);
> > +void			rpcauth_remove_module(void);
> > +void			rpc_destroy_generic_auth(void);
> >  void 			rpc_destroy_authunix(void);
> >  
> >  struct rpc_cred *	rpc_lookup_cred(void);
> > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> > index e9eaaf7..2c0d9e6 100644
> > --- a/net/sunrpc/auth.c
> > +++ b/net/sunrpc/auth.c
> > @@ -658,7 +658,7 @@ out1:
> >  	return err;
> >  }
> >  
> > -void __exit rpcauth_remove_module(void)
> > +void rpcauth_remove_module(void)
> >  {
> >  	rpc_destroy_authunix();
> >  	rpc_destroy_generic_auth();
> > diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
> > index 43162bb..e010a01 100644
> > --- a/net/sunrpc/auth_generic.c
> > +++ b/net/sunrpc/auth_generic.c
> > @@ -158,7 +158,7 @@ int __init rpc_init_generic_auth(void)
> >  	return rpcauth_init_credcache(&generic_auth);
> >  }
> >  
> > -void __exit rpc_destroy_generic_auth(void)
> > +void rpc_destroy_generic_auth(void)
> >  {
> >  	rpcauth_destroy_credcache(&generic_auth);
> >  }
> 

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2011-07-22  6:24 Stephen Rothwell
  2011-07-22  6:26 ` David Miller
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2011-07-22  6:24 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Matt Evans

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc64
allnoconfig) produced this warning:

warning: (PPC) selects HAVE_BPF_JIT which has unmet direct dependencies (NET)

Introduced by commit 0ca87f05ba8b ("net: filter: BPF 'JIT' compiler for
PPC64").

I suspect that the fix is to move the

config HAVE_BPF_JIT
        bool

lines to outside the "if NET" in net/Kconfig.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2011-07-22  6:24 Stephen Rothwell
@ 2011-07-22  6:26 ` David Miller
  0 siblings, 0 replies; 25+ messages in thread
From: David Miller @ 2011-07-22  6:26 UTC (permalink / raw)
  To: sfr; +Cc: netdev, linux-next, linux-kernel, matt

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Fri, 22 Jul 2011 16:24:33 +1000

> warning: (PPC) selects HAVE_BPF_JIT which has unmet direct dependencies (NET)
> 
> Introduced by commit 0ca87f05ba8b ("net: filter: BPF 'JIT' compiler for
> PPC64").
> 
> I suspect that the fix is to move the
> 
> config HAVE_BPF_JIT
>         bool
> 
> lines to outside the "if NET" in net/Kconfig.

I'm going to fix this the way it's dealt with in the x86_64 case
for now, thanks for the report:

--------------------
net: Fix ppc64 BPF JIT dependencies.

Signed-off-by: David S. Miller <davem@davemloft•net>
---
 arch/powerpc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 39860fc..cdf7a0a 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -134,7 +134,7 @@ config PPC
 	select GENERIC_IRQ_SHOW_LEVEL
 	select HAVE_RCU_TABLE_FREE if SMP
 	select HAVE_SYSCALL_TRACEPOINTS
-	select HAVE_BPF_JIT if PPC64
+	select HAVE_BPF_JIT if (PPC64 && NET)
 
 config EARLY_PRINTK
 	bool
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2011-08-16  5:22 Stephen Rothwell
  2011-08-16  6:04 ` Herbert Xu
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2011-08-16  5:22 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Mathias Krause

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

In file included from security/integrity/ima/../integrity.h:16:0,
                 from security/integrity/ima/ima.h:27,
                 from security/integrity/ima/ima_policy.c:20:
include/crypto/sha.h:86:10: warning: 'struct shash_desc' declared inside parameter list
include/crypto/sha.h:86:10: warning: its scope is only this definition or declaration, which is probably not what you want

Introduced by commit 7c390170b493 ("crypto: sha1 - export sha1_update for
reuse").  I guess you need to include crypto/hash.h in crypto/sha.h.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2011-08-16  5:22 Stephen Rothwell
@ 2011-08-16  6:04 ` Herbert Xu
  2011-08-16  7:03   ` Stephen Rothwell
  0 siblings, 1 reply; 25+ messages in thread
From: Herbert Xu @ 2011-08-16  6:04 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Mathias Krause

On Tue, Aug 16, 2011 at 03:22:34PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> In file included from security/integrity/ima/../integrity.h:16:0,
>                  from security/integrity/ima/ima.h:27,
>                  from security/integrity/ima/ima_policy.c:20:
> include/crypto/sha.h:86:10: warning: 'struct shash_desc' declared inside parameter list
> include/crypto/sha.h:86:10: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> Introduced by commit 7c390170b493 ("crypto: sha1 - export sha1_update for
> reuse").  I guess you need to include crypto/hash.h in crypto/sha.h.

Thanks for the report.

Does this patch fix the problem?

commit 4619b6bdb71362d95810f475cc61a6de9d0b1904
Author: Herbert Xu <herbert@gondor•apana.org.au>
Date:   Tue Aug 16 14:03:05 2011 +0800

    crypto: sha - Fix build error due to crypto_sha1_update
    
    On Tue, Aug 16, 2011 at 03:22:34PM +1000, Stephen Rothwell wrote:
    >
    > After merging the final tree, today's linux-next build (powerpc
    > allyesconfig) produced this warning:
    >
    > In file included from security/integrity/ima/../integrity.h:16:0,
    >                  from security/integrity/ima/ima.h:27,
    >                  from security/integrity/ima/ima_policy.c:20:
    > include/crypto/sha.h:86:10: warning: 'struct shash_desc' declared inside parameter list
    > include/crypto/sha.h:86:10: warning: its scope is only this definition or declaration, which is probably not what you want
    >
    > Introduced by commit 7c390170b493 ("crypto: sha1 - export sha1_update for
    > reuse").  I guess you need to include crypto/hash.h in crypto/sha.h.
    
    This patch fixes this by providing a declaration for struct shash_desc.
    
    Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
    Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>

diff --git a/include/crypto/sha.h b/include/crypto/sha.h
index 83e6be5..c6c9c1f 100644
--- a/include/crypto/sha.h
+++ b/include/crypto/sha.h
@@ -82,6 +82,8 @@ struct sha512_state {
 	u8 buf[SHA512_BLOCK_SIZE];
 };
 
+struct shash_desc;
+
 extern int crypto_sha1_update(struct shash_desc *desc, const u8 *data,
 			      unsigned int len);
 
Cheers,
-- 
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2011-08-16  6:04 ` Herbert Xu
@ 2011-08-16  7:03   ` Stephen Rothwell
  2011-08-16  7:08     ` Herbert Xu
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2011-08-16  7:03 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Mathias Krause

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hi Herbert,

On Tue, 16 Aug 2011 14:04:10 +0800 Herbert Xu <herbert@gondor•apana.org.au> wrote:
>
> Does this patch fix the problem?

Yes, it does.

Tested-by: Stephen Rothwell <sfr@canb•auug.org.au>

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2011-08-16  7:03   ` Stephen Rothwell
@ 2011-08-16  7:08     ` Herbert Xu
  0 siblings, 0 replies; 25+ messages in thread
From: Herbert Xu @ 2011-08-16  7:08 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Mathias Krause

On Tue, Aug 16, 2011 at 05:03:11PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> On Tue, 16 Aug 2011 14:04:10 +0800 Herbert Xu <herbert@gondor•apana.org.au> wrote:
> >
> > Does this patch fix the problem?
> 
> Yes, it does.
> 
> Tested-by: Stephen Rothwell <sfr@canb•auug.org.au>

Thanks for checking!
-- 
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2012-03-26  4:11 Stephen Rothwell
  2012-03-28  7:59 ` Williams, Dan J
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2012-03-26  4:11 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Dan Williams

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc32 defconfig)
produced these warnings (and many similar):

In file included from drivers/scsi/hosts.c:41:0:
drivers/scsi/scsi_priv.h:166:1: warning: "__enabled_CONFIG_PM" is not defined [-Wundef]
drivers/scsi/scsi_priv.h:166:1: warning: "__enabled_CONFIG_PM_MODULE" is not defined [-Wundef]

Introduced by commit a6a95fad44f1 ("scsi, sd: limit the scope of the
async probe domain").

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2012-03-26  4:11 Stephen Rothwell
@ 2012-03-28  7:59 ` Williams, Dan J
  0 siblings, 0 replies; 25+ messages in thread
From: Williams, Dan J @ 2012-03-28  7:59 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: James Bottomley, linux-next, linux-kernel

On Sun, Mar 25, 2012 at 9:11 PM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc32 defconfig)
> produced these warnings (and many similar):
>
> In file included from drivers/scsi/hosts.c:41:0:
> drivers/scsi/scsi_priv.h:166:1: warning: "__enabled_CONFIG_PM" is not defined [-Wundef]
> drivers/scsi/scsi_priv.h:166:1: warning: "__enabled_CONFIG_PM_MODULE" is not defined [-Wundef]
>
> Introduced by commit a6a95fad44f1 ("scsi, sd: limit the scope of the
> async probe domain").

So, sparc does not source kernel/power/Kconfig or define config PM
locally.  Compiling out this list_head (scsi_sd_probe_domain) in the
!PM && !BLK_DEV_SD case may be more trouble then it is worth.  I'll
re-spin the patch without the IS_ENABLED conditionals.

--
Dan

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2012-08-02  4:04 Stephen Rothwell
  2012-08-02 14:45 ` Nathan Zimmer
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2012-08-02  4:04 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-next, linux-kernel, Nathan Zimmer

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
produced this warning:

mm/shmem.c: In function 'shmem_interleave':
mm/shmem.c:1343:9: warning: assignment makes integer from pointer without a cast [enabled by default]

Introduced by commit c3cfa3129c03 ("tmpfs: interleave the starting node
of /dev/shmem") from the akpm tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2012-08-02  4:04 Stephen Rothwell
@ 2012-08-02 14:45 ` Nathan Zimmer
  0 siblings, 0 replies; 25+ messages in thread
From: Nathan Zimmer @ 2012-08-02 14:45 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Andrew Morton, linux-next, linux-kernel

On 08/01/2012 11:04 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
>
> mm/shmem.c: In function 'shmem_interleave':
> mm/shmem.c:1343:9: warning: assignment makes integer from pointer without a cast [enabled by default]
>
> Introduced by commit c3cfa3129c03 ("tmpfs: interleave the starting node
> of /dev/shmem") from the akpm tree.
>
That should disappear shortly.  The patch responsible was obsoleted.

Nate

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2012-12-17  3:22 Stephen Rothwell
  2012-12-17  3:34 ` Stephen Rothwell
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2012-12-17  3:22 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev
  Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc allnoconfig)
produced this warning:

warning: (PPC) selects SPARSE_IRQ which has unmet direct dependencies (HAVE_GENERIC_HARDIRQS && (IRQ_DOMAIN && DEBUG_FS || MAY_HAVE_SPARSE_IRQ))

I don't know what introduced that.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2012-12-17  3:22 Stephen Rothwell
@ 2012-12-17  3:34 ` Stephen Rothwell
  2012-12-17 20:59   ` Andrew Morton
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2012-12-17  3:34 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-next, linux-kernel, Paul Thompson, Benjamin Herrenschmidt,
	Paul Mackerras, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi all,

On Mon, 17 Dec 2012 14:22:38 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (powerpc allnoconfig)
> produced this warning:
> 
> warning: (PPC) selects SPARSE_IRQ which has unmet direct dependencies (HAVE_GENERIC_HARDIRQS && (IRQ_DOMAIN && DEBUG_FS || MAY_HAVE_SPARSE_IRQ))
> 
> I don't know what introduced that.

Actually probably caused by commit a1eaa3bc8247 ("Kconfig: fix Irq
Subsystem menu") from the akpm tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2012-12-17  3:34 ` Stephen Rothwell
@ 2012-12-17 20:59   ` Andrew Morton
  0 siblings, 0 replies; 25+ messages in thread
From: Andrew Morton @ 2012-12-17 20:59 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Paul Thompson, Benjamin Herrenschmidt,
	Paul Mackerras, linuxppc-dev

On Mon, 17 Dec 2012 14:34:15 +1100
Stephen Rothwell <sfr@canb•auug.org.au> wrote:

> Hi all,
> 
> On Mon, 17 Dec 2012 14:22:38 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc allnoconfig)
> > produced this warning:
> > 
> > warning: (PPC) selects SPARSE_IRQ which has unmet direct dependencies (HAVE_GENERIC_HARDIRQS && (IRQ_DOMAIN && DEBUG_FS || MAY_HAVE_SPARSE_IRQ))
> > 
> > I don't know what introduced that.
> 
> Actually probably caused by commit a1eaa3bc8247 ("Kconfig: fix Irq
> Subsystem menu") from the akpm tree.

kconfig-fix-irq-subsystem-menu.patch was causing various problems so I
have dropped it.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2013-04-19  8:07 Stephen Rothwell
  2013-04-19  9:44 ` Joerg Roedel
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2013-04-19  8:07 UTC (permalink / raw)
  To: Joerg Roedel; +Cc: linux-next, linux-kernel, Neil Horman

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
produced this warning:

In file included from arch/x86/kernel/early-quirks.c:21:0:
arch/x86/include/asm/irq_remapping.h:87:58: warning: 'struct irq_chip' declared inside parameter list [enabled by default]
arch/x86/include/asm/irq_remapping.h:87:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
arch/x86/include/asm/irq_remapping.h:93:18: warning: 'struct irq_chip' declared inside parameter list [enabled by default]

Probably caused by commit 03bbcb2e7e29 ("iommu/vt-d: add quirk for broken
interrupt remapping on 55XX chipsets") from the iommu tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2013-04-19  8:07 Stephen Rothwell
@ 2013-04-19  9:44 ` Joerg Roedel
  0 siblings, 0 replies; 25+ messages in thread
From: Joerg Roedel @ 2013-04-19  9:44 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Neil Horman

On Fri, Apr 19, 2013 at 06:07:24PM +1000, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (i386 defconfig)
> produced this warning:
> 
> In file included from arch/x86/kernel/early-quirks.c:21:0:
> arch/x86/include/asm/irq_remapping.h:87:58: warning: 'struct irq_chip' declared inside parameter list [enabled by default]
> arch/x86/include/asm/irq_remapping.h:87:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/x86/include/asm/irq_remapping.h:93:18: warning: 'struct irq_chip' declared inside parameter list [enabled by default]
> 
> Probably caused by commit 03bbcb2e7e29 ("iommu/vt-d: add quirk for broken
> interrupt remapping on 55XX chipsets") from the iommu tree.

Thanks for the report, Stephen. I will queue a fix for that problem
asap.


	Joerg

^ permalink raw reply	[flat|nested] 25+ messages in thread

* linux-next: build warning after merge of the final tree
@ 2013-05-29  5:29 Stephen Rothwell
  2013-05-29  5:44 ` David Miller
  0 siblings, 1 reply; 25+ messages in thread
From: Stephen Rothwell @ 2013-05-29  5:29 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-next, linux-kernel, Simon Horman

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig, i386 defconfig, sparc32 defconfig) produced these
warning:

In file included from /scratch/sfr/next/include/net/tcp.h:44:0,
                 from /scratch/sfr/next/net/core/sock.c:139:
/scratch/sfr/next/include/net/inet_ecn.h: In function 'INET_ECN_set_ce':
/scratch/sfr/next/include/net/inet_ecn.h:137:50: warning: comparison between pointer and integer [enabled by default]
/scratch/sfr/next/include/net/inet_ecn.h:142:52: warning: comparison between pointer and integer [enabled by default]

I got lots of these :-(

Introduced by commit 1a37e412a022 ("net: Use 16bits for *_headers fields
of struct skbuff") from the net-next tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: linux-next: build warning after merge of the final tree
  2013-05-29  5:29 linux-next: build warning after merge of the final tree Stephen Rothwell
@ 2013-05-29  5:44 ` David Miller
  0 siblings, 0 replies; 25+ messages in thread
From: David Miller @ 2013-05-29  5:44 UTC (permalink / raw)
  To: sfr; +Cc: netdev, linux-next, linux-kernel, horms

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Wed, 29 May 2013 15:29:15 +1000

> Introduced by commit 1a37e412a022 ("net: Use 16bits for *_headers fields
> of struct skbuff") from the net-next tree.

Simon just posted fixes for this, sorry about that.

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2013-05-29  5:44 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-29  4:02 linux-next: build warning after merge of the final tree Stephen Rothwell
2010-09-29  4:16 ` linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree) Stephen Rothwell
2010-09-29 11:28   ` Pavel Emelyanov
2010-09-29 16:30     ` J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2013-05-29  5:29 linux-next: build warning after merge of the final tree Stephen Rothwell
2013-05-29  5:44 ` David Miller
2013-04-19  8:07 Stephen Rothwell
2013-04-19  9:44 ` Joerg Roedel
2012-12-17  3:22 Stephen Rothwell
2012-12-17  3:34 ` Stephen Rothwell
2012-12-17 20:59   ` Andrew Morton
2012-08-02  4:04 Stephen Rothwell
2012-08-02 14:45 ` Nathan Zimmer
2012-03-26  4:11 Stephen Rothwell
2012-03-28  7:59 ` Williams, Dan J
2011-08-16  5:22 Stephen Rothwell
2011-08-16  6:04 ` Herbert Xu
2011-08-16  7:03   ` Stephen Rothwell
2011-08-16  7:08     ` Herbert Xu
2011-07-22  6:24 Stephen Rothwell
2011-07-22  6:26 ` David Miller
2010-09-16  5:05 Stephen Rothwell
2010-09-16  6:29 ` Jens Axboe
2010-05-26  5:15 Stephen Rothwell
2010-03-01  8:14 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox