From: Greg KH <gregkh@linuxfoundation•org>
To: Alexey Dobriyan <adobriyan@gmail•com>
Cc: James Bottomley <James.Bottomley@HansenPartnership•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: build failure after merge of the scsi tree
Date: Wed, 28 Mar 2012 16:54:35 -0700 [thread overview]
Message-ID: <20120328235435.GB17212@kroah.com> (raw)
In-Reply-To: <20120327223939.GC3233@p183.telecom.by>
On Wed, Mar 28, 2012 at 01:39:39AM +0300, Alexey Dobriyan wrote:
> On Wed, Mar 28, 2012 at 01:35:10AM +0300, Alexey Dobriyan wrote:
> > On Tue, Mar 27, 2012 at 03:22:16PM -0700, Greg KH wrote:
>
> > > > The amount of code once removed from staging prevented me from doing
> > > > any work on them.
> > > >
> > > > Looking at staging ->read_proc users this is going to be a problem for
> > > > its removal. :-(
> > >
> > > Why?
> >
> > Because if staging does count, I can't remove the interface
> > without breaking allmodconfig and it would take forever to convert
> > staging stuff. I don't have energy to do it anymore.
> > Mainline still have several _hard_ ->read_proc conversions.
> > I've tried several times and failed.
> >
> > If staging doesn't count, I will break allmodconfig and all those nasty
> > emails will show up anyway implying that staging does count.
>
> It's comparable to what mainline has besides staging.
> I'm talking about this.
>
> $ grep -e read_proc -w -n -r drivers/staging/
> drivers/staging/comedi/proc.c:92: comedi_proc->read_proc = comedi_read;
> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:298: e->read_proc = show_debug_level;
> drivers/staging/serial/68360serial.c:2428: /* .read_proc = rs_360_read_proc, */
> drivers/staging/rtl8192e/rtllib_module.c:262: e->read_proc = show_debug_level;
Only the comedi one should probably stick around, and even then, it
really should be moved to a sysfs file or three, or even better, a
debugfs file.
> $ grep -e create_proc_read_entry -w -n -r drivers/staging/
> drivers/staging/telephony/ixj.c:7763: create_proc_read_entry ("ixj", 0, NULL, ixj_read_proc, NULL);
> drivers/staging/ft1000/ft1000-usb/ft1000_proc.c:189: ft1000_proc_file = create_proc_read_entry(dev->name, 0644,
> drivers/staging/ft1000/ft1000-usb/ft1000_proc.c:221: create_proc_read_entry(dev->name, 0644,
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:181: create_proc_read_entry(dev->name, 0644, info->proc_ft1000,
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:200: create_proc_read_entry(dev->name, 0644, info->proc_ft1000,
> drivers/staging/rtl8192u/r8192U_core.c:714: e = create_proc_read_entry("stats-rx", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192u/r8192U_core.c:724: e = create_proc_read_entry("stats-tx", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192u/r8192U_core.c:733: e = create_proc_read_entry("stats-ap", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192u/r8192U_core.c:742: e = create_proc_read_entry("registers", S_IFREG | S_IRUGO,
> drivers/staging/cxt1e1/sbeproc.c:325: e = create_proc_read_entry ("info", S_IFREG | S_IRUGO,
> drivers/staging/rtl8187se/r8180_core.c:343: e = create_proc_read_entry("stats-hw", S_IFREG | S_IRUGO,
> drivers/staging/rtl8187se/r8180_core.c:351: e = create_proc_read_entry("stats-rx", S_IFREG | S_IRUGO,
> drivers/staging/rtl8187se/r8180_core.c:360: e = create_proc_read_entry("stats-tx", S_IFREG | S_IRUGO,
> drivers/staging/rtl8187se/r8180_core.c:368: e = create_proc_read_entry("registers", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:873: e = create_proc_read_entry("stats-rx", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:881: e = create_proc_read_entry("stats-tx", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:889: e = create_proc_read_entry("stats-ap", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:897: e = create_proc_read_entry("registers-0", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:903: e = create_proc_read_entry("registers-1", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:909: e = create_proc_read_entry("registers-2", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:915: e = create_proc_read_entry("registers-3", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:921: e = create_proc_read_entry("registers-4", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:927: e = create_proc_read_entry("registers-5", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:933: e = create_proc_read_entry("registers-6", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:939: e = create_proc_read_entry("registers-7", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:945: e = create_proc_read_entry("registers-8", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:951: e = create_proc_read_entry("registers-9", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:957: e = create_proc_read_entry("registers-a", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:963: e = create_proc_read_entry("registers-b", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:969: e = create_proc_read_entry("registers-c", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:975: e = create_proc_read_entry("registers-d", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:981: e = create_proc_read_entry("registers-e", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:987: e = create_proc_read_entry("RF-A", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:993: e = create_proc_read_entry("RF-B", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:999: e = create_proc_read_entry("RF-C", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:1005: e = create_proc_read_entry("RF-D", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:1011: e = create_proc_read_entry("SEC-CAM-1", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:1017: e = create_proc_read_entry("SEC-CAM-2", S_IFREG | S_IRUGO,
> drivers/staging/rtl8192e/rtl8192e/rtl_debug.c:1023: e = create_proc_read_entry("SEC-CAM-3", S_IFREG | S_IRUGO,
> drivers/staging/wlags49_h2/wl_main.c:912: create_proc_read_entry( "wlags", 0, NULL, scull_read_procmem, dev );
I don't understand, I thought you were talking about scsi drivers, why
list all of these? What does your patch do?
greg k-h
next prev parent reply other threads:[~2012-03-28 23:54 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 1:17 linux-next: build failure after merge of the scsi tree Stephen Rothwell
2012-03-26 7:57 ` James Bottomley
2012-03-26 14:07 ` Greg KH
2012-03-27 7:29 ` James Bottomley
2012-03-27 22:17 ` Alexey Dobriyan
2012-03-27 22:22 ` Greg KH
2012-03-27 22:35 ` Alexey Dobriyan
2012-03-27 22:39 ` Alexey Dobriyan
2012-03-28 23:54 ` Greg KH [this message]
2012-03-29 19:38 ` Greg KH
2012-03-28 23:52 ` Greg KH
2012-03-29 7:32 ` Gerard Snitselaar
2012-03-29 8:25 ` Stephen Rothwell
2012-03-29 8:35 ` James Bottomley
2012-03-29 9:03 ` Gerard Snitselaar
2012-03-29 16:15 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-03-20 0:48 Stephen Rothwell
2017-08-28 8:02 Stephen Rothwell
2017-02-06 5:04 Stephen Rothwell
2017-02-13 0:32 ` Stephen Rothwell
2017-02-13 16:18 ` Jens Axboe
2016-12-23 0:45 Stephen Rothwell
2016-12-23 0:56 ` James Bottomley
[not found] ` <20161224123853.08284e8a@canb.auug.org.au>
2016-12-24 10:15 ` Ingo Molnar
2016-12-24 10:44 ` Stephen Rothwell
2016-12-24 11:46 ` Thomas Gleixner
2016-12-24 16:48 ` James Bottomley
2015-11-13 1:35 Stephen Rothwell
2015-11-13 8:32 ` Sreekanth Reddy
2015-06-02 8:06 Stephen Rothwell
2015-06-02 15:02 ` James Bottomley
2015-02-04 6:29 Stephen Rothwell
2015-02-04 6:47 ` Joe Perches
2015-02-04 15:26 ` James Bottomley
2014-11-10 6:15 Stephen Rothwell
2014-11-10 6:27 ` Anish Bhatt
2014-11-10 13:46 ` Christoph Hellwig
2014-11-10 15:21 ` James Bottomley
2014-11-10 15:48 ` Christoph Hellwig
2014-11-10 15:50 ` James Bottomley
2014-11-10 16:01 ` Christoph Hellwig
2014-11-04 4:43 Stephen Rothwell
2014-11-04 7:07 ` Hannes Reinecke
2014-11-05 4:48 ` Stephen Rothwell
2014-11-03 2:52 Stephen Rothwell
2014-11-03 7:51 ` Hannes Reinecke
2014-11-03 18:31 ` Christoph Hellwig
2014-09-26 8:34 Stephen Rothwell
2014-09-26 8:36 ` Christoph Hellwig
2014-09-26 9:57 ` James Bottomley
2014-09-26 12:43 ` Brian King
2013-01-12 2:23 wenxiong
2013-01-11 1:03 Stephen Rothwell
2013-01-11 7:34 ` James Bottomley
2013-01-11 15:27 ` Brian King
2013-01-11 15:37 ` James Bottomley
2013-01-11 16:05 ` Greg KH
2013-01-11 17:35 ` Brian King
2013-01-11 18:04 ` James Bottomley
2012-07-20 0:41 Stephen Rothwell
2012-07-20 8:50 ` James Bottomley
2012-03-23 2:00 Stephen Rothwell
2012-03-23 4:50 ` Benjamin Herrenschmidt
2012-03-23 8:14 ` James Bottomley
2012-03-23 8:53 ` Benjamin Herrenschmidt
2012-03-23 9:01 ` James Bottomley
2012-03-23 15:22 ` Jeff Garzik
2012-03-23 10:26 ` Alexey Dobriyan
2012-03-23 15:30 ` Jeff Garzik
2012-03-23 8:20 ` James Bottomley
2012-03-23 9:24 ` Stephen Rothwell
2011-12-15 1:58 Stephen Rothwell
2011-12-15 6:53 ` James Bottomley
2011-08-29 2:09 Stephen Rothwell
2011-08-29 7:17 ` James Bottomley
2011-08-29 8:07 ` Giridhar Malavali
2011-05-27 3:25 Stephen Rothwell
2011-05-27 13:47 ` James Bottomley
2010-10-26 0:19 Stephen Rothwell
2010-10-26 15:50 ` James Bottomley
2010-02-10 1:33 Stephen Rothwell
2010-02-10 22:16 ` James Bottomley
2010-02-10 23:11 ` Stephen Rothwell
2010-02-16 0:38 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328235435.GB17212@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox