Re: linux-next: build failure after merge of the scsi tree

public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Hannes Reinecke <hare@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
	James Bottomley <James.Bottomley@HansenPartnership•com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Christoph Hellwig <hch@infradead•org>
Subject: Re: linux-next: build failure after merge of the scsi tree
Date: Mon, 03 Nov 2014 08:51:09 +0100	[thread overview]
Message-ID: <545733ED.2080705@suse.de> (raw)
In-Reply-To: <20141103135229.7916c23c@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/03/2014 03:52 AM, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/scsi/scsi_lib.c: In function 'scsi_io_completion': 
> drivers/scsi/scsi_lib.c:1048:5: error: implicit declaration of
> function 'SCSI_LOG_LEVEL'
> [-Werror=implicit-function-declaration] level =
> SCSI_LOG_LEVEL(SCSI_LOG_MLCOMPLETE_SHIFT, ^
> 
> Caused by commit b6568e80be82 ("scsi: simplify 
> scsi_log_(send|completion)").  SCSI_LOG_LEVEL is defined in 
> drivers/scsi/scsi_logging.h, but only if CONFIG_SCSI_LOGGING is
> defined.
> 
> I have used the version of the scsi tree from next-20141031 for
> today.
> 
Ah, missed that. Here's the patch.

Cheers,

Hannes
- -- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse•de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJUVzPtAAoJEGz4yi9OyKjPX/YP/2CmPtJDed4+ckb0gjJ8bdlW
i6F532mihXN1WuFYahFujCmZczF8aPEZrViKp/6BZGaqezhqg7BdoH/dXzsYzWAh
Slwlqu52WIj4Eo0B39dN8uuWRPJXV+jvSRE2NucVVhICYYYghR8YhK3HeY2Mw/g7
M1G82a3Ry0g/NpJePzdLImvWj8QoLhua9p61aias0kJjf3p+JskMV3PK9QbroVp/
QsubWkj2yaSs/j21E77JMMzLaQsRK0SIwDvN7AdGxh+h5e9r+eWJrpfdJscAZ4td
FsPApfQR9fxtG9mDPZigf2Oy3XX++N1TPQN6Y7s1KE78d+XGJFxtXEIf1gmp07Pg
lCQACp2WVA14mA+A5PTN7xYtYwvPgMPez63XnAjFkVVXpSMYilRqSPQs82ruN42w
0GGX293ay2s6o1CcFNk/xJp/l7KomKlQbjdIMCkWVbKb3gpO8ivxThPzJv001SN8
zOF7u9YxATQS5EG0Cja9/aLVrhjg0GWFjtmvs9ToSrSgsFrrLycg7zP+DtfP4uz8
2hsAU9Ss9PlxfgbOIMoH42S0YZe4vo6RJmY25POuSfHQVsn+FTVpxqYErMUnNql6
dPfcQq+YqcfcT4n0rBV8VtzRulU11SzNZBEwbJhML4zUs4DCLteemYCWyp/5F+hw
hmmeOMsJfUW8EiLgoLbf
=nK00
-----END PGP SIGNATURE-----

[-- Attachment #2: 0001-scsi-define-SCSI_LOG_LEVEL.patch --]
[-- Type: text/x-patch, Size: 827 bytes --]

>From e5c943164a981e32d88c7083c84a85ff513bb0ee Mon Sep 17 00:00:00 2001
From: Hannes Reinecke <hare@suse•de>
Date: Mon, 3 Nov 2014 08:03:48 +0100
Subject: [PATCH] scsi: define SCSI_LOG_LEVEL

SCSI_LOG_LEVEL needs to be defined even if CONFIG_SCSI_LOGGING
is not enabled.

Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Hannes Reinecke <hare@suse•de>
---
 drivers/scsi/scsi_logging.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_logging.h b/drivers/scsi/scsi_logging.h
index 1f65139..7fe64a8 100644
--- a/drivers/scsi/scsi_logging.h
+++ b/drivers/scsi/scsi_logging.h
@@ -51,6 +51,7 @@ do {								\
 		} while (0);					\
 } while (0)
 #else
+#define SCSI_LOG_LEVEL(SHIFT, BITS) 0
 #define SCSI_CHECK_LOGGING(SHIFT, BITS, LEVEL, CMD)
 #endif /* CONFIG_SCSI_LOGGING */
 
-- 
1.8.4.5

next prev parent reply	other threads:[~2014-11-03  7:51 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03  2:52 linux-next: build failure after merge of the scsi tree Stephen Rothwell
2014-11-03  7:51 ` Hannes Reinecke [this message]
2014-11-03 18:31   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2019-03-20  0:48 Stephen Rothwell
2017-08-28  8:02 Stephen Rothwell
2017-02-06  5:04 Stephen Rothwell
2017-02-13  0:32 ` Stephen Rothwell
2017-02-13 16:18   ` Jens Axboe
2016-12-23  0:45 Stephen Rothwell
2016-12-23  0:56 ` James Bottomley
     [not found]   ` <20161224123853.08284e8a@canb.auug.org.au>
2016-12-24 10:15     ` Ingo Molnar
2016-12-24 10:44       ` Stephen Rothwell
2016-12-24 11:46     ` Thomas Gleixner
2016-12-24 16:48       ` James Bottomley
2015-11-13  1:35 Stephen Rothwell
2015-11-13  8:32 ` Sreekanth Reddy
2015-06-02  8:06 Stephen Rothwell
2015-06-02 15:02 ` James Bottomley
2015-02-04  6:29 Stephen Rothwell
2015-02-04  6:47 ` Joe Perches
2015-02-04 15:26 ` James Bottomley
2014-11-10  6:15 Stephen Rothwell
2014-11-10  6:27 ` Anish Bhatt
2014-11-10 13:46   ` Christoph Hellwig
2014-11-10 15:21     ` James Bottomley
2014-11-10 15:48       ` Christoph Hellwig
2014-11-10 15:50         ` James Bottomley
2014-11-10 16:01           ` Christoph Hellwig
2014-11-04  4:43 Stephen Rothwell
2014-11-04  7:07 ` Hannes Reinecke
2014-11-05  4:48   ` Stephen Rothwell
2014-09-26  8:34 Stephen Rothwell
2014-09-26  8:36 ` Christoph Hellwig
2014-09-26  9:57   ` James Bottomley
2014-09-26 12:43     ` Brian King
2013-01-12  2:23 wenxiong
2013-01-11  1:03 Stephen Rothwell
2013-01-11  7:34 ` James Bottomley
2013-01-11 15:27   ` Brian King
2013-01-11 15:37     ` James Bottomley
2013-01-11 16:05       ` Greg KH
2013-01-11 17:35         ` Brian King
2013-01-11 18:04           ` James Bottomley
2012-07-20  0:41 Stephen Rothwell
2012-07-20  8:50 ` James Bottomley
2012-03-26  1:17 Stephen Rothwell
2012-03-26  7:57 ` James Bottomley
2012-03-26 14:07   ` Greg KH
2012-03-27  7:29     ` James Bottomley
2012-03-27 22:17     ` Alexey Dobriyan
2012-03-27 22:22       ` Greg KH
2012-03-27 22:35         ` Alexey Dobriyan
2012-03-27 22:39           ` Alexey Dobriyan
2012-03-28 23:54             ` Greg KH
2012-03-29 19:38             ` Greg KH
2012-03-28 23:52           ` Greg KH
2012-03-29  7:32             ` Gerard Snitselaar
2012-03-29  8:25               ` Stephen Rothwell
2012-03-29  8:35                 ` James Bottomley
2012-03-29  9:03                 ` Gerard Snitselaar
2012-03-29 16:15                   ` Greg KH
2012-03-23  2:00 Stephen Rothwell
2012-03-23  4:50 ` Benjamin Herrenschmidt
2012-03-23  8:14   ` James Bottomley
2012-03-23  8:53     ` Benjamin Herrenschmidt
2012-03-23  9:01       ` James Bottomley
2012-03-23 15:22         ` Jeff Garzik
2012-03-23 10:26   ` Alexey Dobriyan
2012-03-23 15:30     ` Jeff Garzik
2012-03-23  8:20 ` James Bottomley
2012-03-23  9:24   ` Stephen Rothwell
2011-12-15  1:58 Stephen Rothwell
2011-12-15  6:53 ` James Bottomley
2011-08-29  2:09 Stephen Rothwell
2011-08-29  7:17 ` James Bottomley
2011-08-29  8:07   ` Giridhar Malavali
2011-05-27  3:25 Stephen Rothwell
2011-05-27 13:47 ` James Bottomley
2010-10-26  0:19 Stephen Rothwell
2010-10-26 15:50 ` James Bottomley
2010-02-10  1:33 Stephen Rothwell
2010-02-10 22:16 ` James Bottomley
2010-02-10 23:11   ` Stephen Rothwell
2010-02-16  0:38   ` Stephen Rothwell

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:1f65139 dfblob:7fe64a8 )
 OR (
bs:"scsi: define SCSI_LOG_LEVEL" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545733ED.2080705@suse.de \
    --to=hare@suse$(echo .)de \
    --cc=James.Bottomley@HansenPartnership$(echo .)com \
    --cc=hch@infradead$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox